Re: [dpdk-dev] [PATCH v7 7/8] examples/vhost_crypto: add vhost crypto sample application
On 04/15/2018 07:35 PM, Thomas Monjalon wrote: 15/04/2018 16:34, Thomas Monjalon: Hi, 05/04/2018 18:01, Fan Zhang: This patch adds vhost_crypto sample application to DPDK. Signed-off-by: Fan Zhang --- examples/vhost_crypto/Makefile| 32 +++ examples/vhost_crypto/main.c | 541 ++ examples/vhost_crypto/meson.build | 14 + 3 files changed, 587 insertions(+) There are 3 misses: - not in examples/Makefile - not in MAINTAINERS - no documentation in doc/guides/sample_app_ug/ It won't be accepted in master as-is. The doc is (curiously) in the next patch. I will move it here. I will also fix the Makefile and the MAINTAINERS file: ifeq ($(CONFIG_RTE_LIBRTE_CRYPTODEV),y) DIRS-$(CONFIG_RTE_LIBRTE_VHOST) += vhost_crypto endif Vhost-user M: Maxime Coquelin M: Jianfeng Tan T: git://dpdk.org/next/dpdk-next-virtio F: lib/librte_vhost/ [...] F: examples/vhost_crypto/ Ferruh, Maxime, I hope you agree with this last-minute fix. Agreed. thanks. Maxime
Re: [dpdk-dev] [PATCH v7 7/8] examples/vhost_crypto: add vhost crypto sample application
15/04/2018 16:34, Thomas Monjalon: > Hi, > > 05/04/2018 18:01, Fan Zhang: > > This patch adds vhost_crypto sample application to DPDK. > > > > Signed-off-by: Fan Zhang > > --- > > examples/vhost_crypto/Makefile| 32 +++ > > examples/vhost_crypto/main.c | 541 > > ++ > > examples/vhost_crypto/meson.build | 14 + > > 3 files changed, 587 insertions(+) > > There are 3 misses: > > - not in examples/Makefile > - not in MAINTAINERS > - no documentation in doc/guides/sample_app_ug/ > > It won't be accepted in master as-is. The doc is (curiously) in the next patch. I will move it here. I will also fix the Makefile and the MAINTAINERS file: ifeq ($(CONFIG_RTE_LIBRTE_CRYPTODEV),y) DIRS-$(CONFIG_RTE_LIBRTE_VHOST) += vhost_crypto endif Vhost-user M: Maxime Coquelin M: Jianfeng Tan T: git://dpdk.org/next/dpdk-next-virtio F: lib/librte_vhost/ [...] F: examples/vhost_crypto/ Ferruh, Maxime, I hope you agree with this last-minute fix.
Re: [dpdk-dev] [PATCH v7 7/8] examples/vhost_crypto: add vhost crypto sample application
Hi, 05/04/2018 18:01, Fan Zhang: > This patch adds vhost_crypto sample application to DPDK. > > Signed-off-by: Fan Zhang > --- > examples/vhost_crypto/Makefile| 32 +++ > examples/vhost_crypto/main.c | 541 > ++ > examples/vhost_crypto/meson.build | 14 + > 3 files changed, 587 insertions(+) There are 3 misses: - not in examples/Makefile - not in MAINTAINERS - no documentation in doc/guides/sample_app_ug/ It won't be accepted in master as-is.
