Re: [dpdk-dev] [RFC 1/2] hash: add lock free support for extendable bucket

2019-03-25 Thread Dharmik Thakkar
Hi Honnappa, Thank you for the review comments! > On Mar 14, 2019, at 7:31 PM, Honnappa Nagarahalli > wrote: > > > @@ -1072,10 +1071,23 @@ __rte_hash_add_key_with_hash(const struct >> rte_hash *h, const void *key, bkt_id = (uint32_t)((uintptr_t)ext_bkt_id) - 1; /* Use th

Re: [dpdk-dev] [RFC 1/2] hash: add lock free support for extendable bucket

2019-03-14 Thread Honnappa Nagarahalli
> >> @@ -1072,10 +1071,23 @@ __rte_hash_add_key_with_hash(const struct > rte_hash *h, const void *key, > >>bkt_id = (uint32_t)((uintptr_t)ext_bkt_id) - 1; > >>/* Use the first location of the new bucket */ > >>(h->buckets_ext[bkt_id]).sig_current[0] = short_sig; > >> - (h->buckets_ex

Re: [dpdk-dev] [RFC 1/2] hash: add lock free support for extendable bucket

2019-03-07 Thread Dharmik Thakkar
+ Honnappa Hi Yipeng, Thank you for the review comments! > On Mar 7, 2019, at 11:49 AM, Wang, Yipeng1 wrote: > > Thanks for this patch! Some initial comments inlined: > >> -Original Message- >> From: Dharmik Thakkar [mailto:dharmik.thak...@arm.com] >> Sent: Friday, March 1, 2019 4:24

Re: [dpdk-dev] [RFC 1/2] hash: add lock free support for extendable bucket

2019-03-07 Thread Wang, Yipeng1
Thanks for this patch! Some initial comments inlined: >-Original Message- >From: Dharmik Thakkar [mailto:dharmik.thak...@arm.com] >Sent: Friday, March 1, 2019 4:24 PM >To: Wang, Yipeng1 ; Gobriel, Sameh >; Richardson, Bruce >; De Lara Guarch, Pablo >; Mcnamara, John >; Kovacevic, Marko