chrismattmann commented on issue #135: Initial Commit of adding new UI designed
with vue
URL: https://github.com/apache/drat/pull/135#issuecomment-410497078
i was able to fully test this. For a start, it works. Which is great! Areas
of improvement:
1. It does not include the DRAT
chrismattmann commented on issue #135: Initial Commit of adding new UI designed
with vue
URL: https://github.com/apache/drat/pull/135#issuecomment-406374268
please just make it a Maven build step to call npm. Someone shouldn't have
to do anything else other than calling mvn install on the
chrismattmann commented on issue #135: Initial Commit of adding new UI designed
with vue
URL: https://github.com/apache/drat/pull/135#issuecomment-406354905
@ahmedifhaam really need you to address these issues and put out a new PR in
the next few days for review. Thanks.
chrismattmann commented on issue #135: Initial Commit of adding new UI designed
with vue
URL: https://github.com/apache/drat/pull/135#issuecomment-404639338
will check today @ahmedifhaam
This is an automated message from
chrismattmann commented on issue #135: Initial Commit of adding new UI designed
with vue
URL: https://github.com/apache/drat/pull/135#issuecomment-402559104
whoah - i think you checked in like a fully built version of the project.
Can you just check in the source code @ahmedifhaam ? It
chrismattmann commented on issue #135: Initial Commit of adding new UI designed
with vue
URL: https://github.com/apache/drat/pull/135#issuecomment-401850573
this includes generated JS and CSS minified. We need the original source,
not the minified stuff. I can't review this.
