[GitHub] chrismattmann commented on issue #135: Initial Commit of adding new UI designed with vue
chrismattmann commented on issue #135: Initial Commit of adding new UI designed with vue URL: https://github.com/apache/drat/pull/135#issuecomment-410497078 i was able to fully test this. For a start, it works. Which is great! Areas of improvement: 1. It does not include the DRAT reset command, or the ability to call specify commands one by one, like Proteus. 2. It does not all for git clone as Proteus does, or remote checkout of SVN or GIT 3. there is a bug in the logic for checking if all mappers have completed. I'll fix this separately. 4. the gravatar makes no sense in the upper left. 5. the views give a weird message when clicking between the audit and statistics view. Overall great start, but a lot to work on! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] chrismattmann commented on issue #135: Initial Commit of adding new UI designed with vue
chrismattmann commented on issue #135: Initial Commit of adding new UI designed with vue URL: https://github.com/apache/drat/pull/135#issuecomment-406374268 please just make it a Maven build step to call npm. Someone shouldn't have to do anything else other than calling mvn install on the module and then the result is to call npm. This is easily done with Maven Ant Tasks, e.g., see https://gist.github.com/phillipgreenii/7c954e3c3911e5c32bd0 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] chrismattmann commented on issue #135: Initial Commit of adding new UI designed with vue
chrismattmann commented on issue #135: Initial Commit of adding new UI designed with vue URL: https://github.com/apache/drat/pull/135#issuecomment-406354905 @ahmedifhaam really need you to address these issues and put out a new PR in the next few days for review. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] chrismattmann commented on issue #135: Initial Commit of adding new UI designed with vue
chrismattmann commented on issue #135: Initial Commit of adding new UI designed with vue URL: https://github.com/apache/drat/pull/135#issuecomment-404639338 will check today @ahmedifhaam This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] chrismattmann commented on issue #135: Initial Commit of adding new UI designed with vue
chrismattmann commented on issue #135: Initial Commit of adding new UI designed with vue URL: https://github.com/apache/drat/pull/135#issuecomment-402559104 whoah - i think you checked in like a fully built version of the project. Can you just check in the source code @ahmedifhaam ? It shouldn't be 2M lines of codeI think that's the built version of the project. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] chrismattmann commented on issue #135: Initial Commit of adding new UI designed with vue
chrismattmann commented on issue #135: Initial Commit of adding new UI designed with vue URL: https://github.com/apache/drat/pull/135#issuecomment-401850573 this includes generated JS and CSS minified. We need the original source, not the minified stuff. I can't review this. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
