[GitHub] drill issue #518: DRILL-4653.json - Malformed JSON should not stop the entir...

Github user ssriniva123 commented on the issue: https://github.com/apache/drill/pull/518 I have a similar data set checked in. Hope that is good enough. On Fri, Oct 7, 2016 at 10:00 AM, Paul Rogers wrote: > Base data set: >

[jira] [Created] (DRILL-4934) ServiceEngine does not use property useIP for DrillbitStartup

Joe Swingle created DRILL-4934: -- Summary: ServiceEngine does not use property useIP for DrillbitStartup Key: DRILL-4934 URL: https://issues.apache.org/jira/browse/DRILL-4934 Project: Apache Drill

[GitHub] drill issue #518: DRILL-4653.json - Malformed JSON should not stop the entir...

Github user zfong commented on the issue: https://github.com/apache/drill/pull/518 @paul-rogers - since you had concerns about particular test cases, and it looks like you've confirmed that those are non-issues, would it make sense for you to share those with @ssriniva123 and he can

[GitHub] drill issue #518: DRILL-4653.json - Malformed JSON should not stop the entir...

Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/518 Base data set: { "p": 1, "a": { "x": 10, "y": 20, "z": 30 }, "b": 50, "c": 60 } { "p": 2, "a": { "x": 11, "y": 21, "z": 31 }, "b": 51, "c": 61 } { "p": 3, "a": { "x":

[GitHub] drill issue #595: DRILL-4203: Parquet File. Date is stored wrongly

Github user vdiravka commented on the issue: https://github.com/apache/drill/pull/595 The branch is rebased to the master version. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] drill pull request #605: DRILL-4870 drill-config.sh sets JAVA_HOME incorrect...

Github user chunhui-shi commented on a diff in the pull request: https://github.com/apache/drill/pull/605#discussion_r82488363 --- Diff: distribution/src/resources/drill-config.sh --- @@ -392,5 +392,7 @@ export DRILL_HOME export DRILL_CONF_DIR export DRILL_LOG_DIR

[GitHub] drill pull request #605: DRILL-4870 drill-config.sh sets JAVA_HOME incorrect...

GitHub user paul-rogers opened a pull request: https://github.com/apache/drill/pull/605 DRILL-4870 drill-config.sh sets JAVA_HOME incorrectly for the Mac Recent script revisions uncommented a line to export the Drill-computed JAVA_HOME. Turns out, we should not do this; we should

[GitHub] drill pull request #605: DRILL-4870 drill-config.sh sets JAVA_HOME incorrect...

Github user chunhui-shi commented on a diff in the pull request: https://github.com/apache/drill/pull/605#discussion_r82488367 --- Diff: distribution/src/resources/drill-config.sh --- @@ -392,5 +392,7 @@ export DRILL_HOME export DRILL_CONF_DIR export DRILL_LOG_DIR

[jira] [Created] (DRILL-4935) Allow drillbits to advertise a configurable host address to Zookeeper

Harrison Mebane created DRILL-4935: -- Summary: Allow drillbits to advertise a configurable host address to Zookeeper Key: DRILL-4935 URL: https://issues.apache.org/jira/browse/DRILL-4935 Project:

[GitHub] drill issue #593: DRILL-3178 csv reader should allow newlines inside quotes

Github user fmethot commented on the issue: https://github.com/apache/drill/pull/593 Thanks for the comments so far, See my newer changes, I suggest that we remove the flag and add an extra method instead. There is no more check for a boolean in nextChar, but instead there is an

[GitHub] drill pull request #605: DRILL-4870 drill-config.sh sets JAVA_HOME incorrect...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/605#discussion_r82495596 --- Diff: distribution/src/resources/drill-config.sh --- @@ -392,5 +392,7 @@ export DRILL_HOME export DRILL_CONF_DIR export DRILL_LOG_DIR

[GitHub] drill pull request #536: DRILL-4699: Add description column to sys.options t...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/536#discussion_r82495422 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java --- @@ -237,71 +281,81 @@ * DEFAULT: 64 MB * MAXIMUM: 2048

[GitHub] drill pull request #536: DRILL-4699: Add description column to sys.options t...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/536#discussion_r82485277 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java --- @@ -33,110 +33,122 @@ import

[GitHub] drill pull request #536: DRILL-4699: Add description column to sys.options t...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/536#discussion_r82495511 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/PlannerSettings.java --- @@ -46,40 +46,83 @@ // max off heap memory

[GitHub] drill pull request #536: DRILL-4699: Add description column to sys.options t...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/536#discussion_r82485619 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java --- @@ -33,110 +33,122 @@ import

[GitHub] drill pull request #536: DRILL-4699: Add description column to sys.options t...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/536#discussion_r82495374 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java --- @@ -146,89 +158,121 @@ *|-bar -

[GitHub] drill pull request #605: DRILL-4870 drill-config.sh sets JAVA_HOME incorrect...

Github user chunhui-shi commented on a diff in the pull request: https://github.com/apache/drill/pull/605#discussion_r82496282 --- Diff: distribution/src/resources/drill-config.sh --- @@ -392,5 +392,7 @@ export DRILL_HOME export DRILL_CONF_DIR export DRILL_LOG_DIR

[GitHub] drill pull request #536: DRILL-4699: Add description column to sys.options t...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/536#discussion_r82485322 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java --- @@ -33,110 +33,122 @@ import

[GitHub] drill pull request #536: DRILL-4699: Add description column to sys.options t...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/536#discussion_r82495479 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/compile/QueryClassLoader.java --- @@ -42,7 +42,17 @@ private static final

[GitHub] drill pull request #536: DRILL-4699: Add description column to sys.options t...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/536#discussion_r82495346 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java --- @@ -146,89 +158,121 @@ *|-bar -

[GitHub] drill pull request #536: DRILL-4699: Add description column to sys.options t...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/536#discussion_r82495464 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java --- @@ -237,71 +281,81 @@ * DEFAULT: 64 MB * MAXIMUM: 2048

[GitHub] drill pull request #536: DRILL-4699: Add description column to sys.options t...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/536#discussion_r82495404 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java --- @@ -237,71 +281,81 @@ * DEFAULT: 64 MB * MAXIMUM: 2048

[GitHub] drill pull request #536: DRILL-4699: Add description column to sys.options t...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/536#discussion_r82495353 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java --- @@ -146,89 +158,121 @@ *|-bar -

[GitHub] drill pull request #536: DRILL-4699: Add description column to sys.options t...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/536#discussion_r82495327 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java --- @@ -146,89 +158,121 @@ *|-bar -

[GitHub] drill pull request #536: DRILL-4699: Add description column to sys.options t...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/536#discussion_r82485491 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java --- @@ -33,110 +33,122 @@ import

[GitHub] drill pull request #536: DRILL-4699: Add description column to sys.options t...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/536#discussion_r82495497 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/PlannerSettings.java --- @@ -46,40 +46,83 @@ // max off heap memory