Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/660
Revised title to include correct JIRA title.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Vitalii Diravka created DRILL-5097:
--
Summary: Need to change the default width of the timestamp vector
Key: DRILL-5097
URL: https://issues.apache.org/jira/browse/DRILL-5097
Project: Apache Drill
Github user parthchandra commented on the issue:
https://github.com/apache/drill/pull/638
LGTM too. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user laurentgo commented on a diff in the pull request:
https://github.com/apache/drill/pull/675#discussion_r90688989
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/schedule/AssignmentCreator.java
---
@@ -50,7 +50,8 @@
private static
Github user parthchandra commented on the issue:
https://github.com/apache/drill/pull/674
+1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/672#discussion_r90689224
--- Diff: exec/java-exec/src/main/resources/drill-module.conf ---
@@ -45,11 +45,13 @@ drill.client: {
supports-complex-types: true
}
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/672#discussion_r90687630
--- Diff: distribution/src/resources/drill-override-example.conf ---
@@ -170,7 +170,17 @@ drill.exec: {
threadpool_size: 8,
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/672#discussion_r90688304
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/registry/RemoteFunctionRegistry.java
---
@@ -189,6 +188,7 @@ private void
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/672#discussion_r90687564
--- Diff: distribution/src/resources/drill-override-example.conf ---
@@ -170,7 +170,17 @@ drill.exec: {
threadpool_size: 8,
Github user Serhii-Harnyk commented on the issue:
https://github.com/apache/drill/pull/673
@parthchandra, I have made some changes and added few test values. Could
you please review it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/673#discussion_r90694144
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ParquetFixedWidthDictionaryReaders.java
---
@@ -56,6 +58,31 @@
Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/673#discussion_r90694935
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ParquetFixedWidthDictionaryReaders.java
---
@@ -56,6 +58,31 @@
Github user zfong commented on the issue:
https://github.com/apache/drill/pull/675
Looks good to me. +1 (non-binding)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user amansinha100 commented on the issue:
https://github.com/apache/drill/pull/659
+1 based on @laurentgo 's review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user chunhui-shi commented on the issue:
https://github.com/apache/drill/pull/638
Addressed your comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
15 matches
Mail list logo
