[GitHub] drill pull request #685: Drill 5043: Function that returns a unique id per s...

Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/685#discussion_r96446816 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ops/ContextInformation.java --- @@ -28,12 +28,14 @@ private final String

[GitHub] drill pull request #685: Drill 5043: Function that returns a unique id per s...

Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/685#discussion_r96463387 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlOperator.java --- @@ -147,6 +166,14 @@ public

[GitHub] drill pull request #685: Drill 5043: Function that returns a unique id per s...

Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/685#discussion_r96451356 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlOperator.java --- @@ -147,6 +166,14 @@ public

[GitHub] drill issue #666: DRILL-4956: Temporary tables support

Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/666 @paul-rogers I have made changes after second round of CR. Main changes include: 1. disallow view over temporary tables; 2. case-insensitive temporary tables names; 3.

[GitHub] drill pull request #666: DRILL-4956: Temporary tables support

Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/666#discussion_r95811350 --- Diff: distribution/src/resources/drill-override-example.conf --- @@ -184,7 +184,12 @@ drill.exec: { # Set this property if custom

[GitHub] drill pull request #666: DRILL-4956: Temporary tables support

Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/666#discussion_r95408561 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetRecordWriter.java --- @@ -382,4 +391,20 @@ public void cleanup()

[GitHub] drill pull request #666: DRILL-4956: Temporary tables support

Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/666#discussion_r94760664 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/DropTableHandler.java --- @@ -55,35 +58,79 @@ public

[GitHub] drill pull request #666: DRILL-4956: Temporary tables support

Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/666#discussion_r94779958 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/SqlConverter.java --- @@ -447,4 +458,50 @@ public RexNode ensureType(

[GitHub] drill pull request #666: DRILL-4956: Temporary tables support

Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/666#discussion_r94759119 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/CreateTableHandler.java --- @@ -67,43 +71,64 @@ public

[GitHub] drill pull request #666: DRILL-4956: Temporary tables support

Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/666#discussion_r95580538 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/CreateTableHandler.java --- @@ -67,43 +71,64 @@ public

[GitHub] drill issue #685: Drill 5043: Function that returns a unique id per session/...

Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/685 @nagarajanchinnasamy Good job, thank you! Please address minor review comments, squash commits into one and rebase on current master. --- If your project is set up for it, you can reply

[GitHub] drill pull request #666: DRILL-4956: Temporary tables support

Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/666#discussion_r94757405 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/WriterRecordBatch.java --- @@ -174,13 +174,23 @@ protected void

[GitHub] drill pull request #666: DRILL-4956: Temporary tables support

Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/666#discussion_r95408912 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/JsonRecordWriter.java --- @@ -82,6 +84,9 @@ public void

[GitHub] drill pull request #666: DRILL-4956: Temporary tables support

Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/666#discussion_r96142710 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/DropTableHandler.java --- @@ -55,35 +58,79 @@ public

[GitHub] drill pull request #666: DRILL-4956: Temporary tables support

Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/666#discussion_r95354313 --- Diff: exec/rpc/src/main/java/org/apache/drill/exec/rpc/RpcBus.java --- @@ -164,6 +164,8 @@ public void operationComplete(ChannelFuture future)

[GitHub] drill pull request #666: DRILL-4956: Temporary tables support

Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/666#discussion_r94761133 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/DropTableHandler.java --- @@ -55,35 +58,79 @@ public

[GitHub] drill pull request #666: DRILL-4956: Temporary tables support

Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/666#discussion_r95813048 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserSession.java --- @@ -207,18 +245,85 @@ public SchemaPlus

[GitHub] drill pull request #666: DRILL-4956: Temporary tables support

Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/666#discussion_r95580468 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/SqlConverter.java --- @@ -447,4 +458,50 @@ public RexNode ensureType(

[GitHub] drill pull request #666: DRILL-4956: Temporary tables support

Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/666#discussion_r94757849 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/SqlConverter.java --- @@ -447,4 +458,50 @@ public RexNode ensureType(

[GitHub] drill pull request #666: DRILL-4956: Temporary tables support

Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/666#discussion_r96142721 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/DropTableHandler.java --- @@ -55,35 +58,79 @@ public

[GitHub] drill pull request #666: DRILL-4956: Temporary tables support

Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/666#discussion_r94758373 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/SqlConverter.java --- @@ -447,4 +458,50 @@ public RexNode ensureType(

[GitHub] drill pull request #666: DRILL-4956: Temporary tables support

Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/666#discussion_r94757371 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/WriterRecordBatch.java --- @@ -174,13 +174,23 @@ protected void

[GitHub] drill pull request #666: DRILL-4956: Temporary tables support

Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/666#discussion_r94768957 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/ViewHandler.java --- @@ -74,36 +74,51 @@ public PhysicalPlan

[GitHub] drill pull request #666: DRILL-4956: Temporary tables support

Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/666#discussion_r96421340 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserSession.java --- @@ -54,18 +66,41 @@ private Map

[GitHub] drill pull request #666: DRILL-4956: Temporary tables support

Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/666#discussion_r95408445 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/rpc/user/TemporaryTablesAutomaticDropTest.java --- @@ -0,0 +1,99 @@ +/** ---

[GitHub] drill pull request #666: DRILL-4956: Temporary tables support

Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/666#discussion_r94763501 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/ViewHandler.java --- @@ -49,6 +50,24 @@ public

[GitHub] drill pull request #666: DRILL-4956: Temporary tables support

Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/666#discussion_r94760594 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/DropTableHandler.java --- @@ -55,35 +58,79 @@ public

[GitHub] drill pull request #666: DRILL-4956: Temporary tables support

Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/666#discussion_r94760042 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/CreateTableHandler.java --- @@ -242,4 +267,53 @@ private RexNode

[GitHub] drill pull request #666: DRILL-4956: Temporary tables support

Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/666#discussion_r96142739 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/ViewHandler.java --- @@ -74,36 +93,49 @@ public PhysicalPlan

[GitHub] drill pull request #666: DRILL-4956: Temporary tables support

Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/666#discussion_r95805039 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserSession.java --- @@ -207,18 +245,85 @@ public SchemaPlus

[GitHub] drill pull request #666: DRILL-4956: Temporary tables support

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/666#discussion_r96509598 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/SchemaUtilites.java --- @@ -177,4 +186,34 @@ public static AbstractSchema

[GitHub] drill issue #720: Indexr plugin

Github user jinfengni commented on the issue: https://github.com/apache/drill/pull/720 Can you please open a Apache Drill JIRA at https://issues.apache.org/jira/browse/DRILL/? Put all the related links for IndexR storage plugin in the Drill JIRA. Also, update the commit message with

[GitHub] drill pull request #720: Indexr plugin

Github user jinfengni commented on a diff in the pull request: https://github.com/apache/drill/pull/720#discussion_r96553793 --- Diff: contrib/storage-indexr/pom.xml --- @@ -0,0 +1,170 @@ + + +http://maven.apache.org/POM/4.0.0; +

[GitHub] drill pull request #720: Indexr plugin

Github user jinfengni commented on a diff in the pull request: https://github.com/apache/drill/pull/720#discussion_r96553531 --- Diff: contrib/storage-indexr/pom.xml --- @@ -0,0 +1,170 @@ + + +http://maven.apache.org/POM/4.0.0; +