[GitHub] drill pull request #1109: DRILL-6128: Wrong Result with Nested Loop Join

2018-02-08 Thread amansinha100
Github user amansinha100 commented on a diff in the pull request: https://github.com/apache/drill/pull/1109#discussion_r166981670 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/NestedLoopJoinTemplate.java --- @@ -117,9 +117,12 @@ private int

[GitHub] drill issue #1117: DRILL-6089 Removed ordering trait from HashJoin in planne...

2018-02-08 Thread HanumathRao
Github user HanumathRao commented on the issue: https://github.com/apache/drill/pull/1117 @ilooner Changes look fine to me. However, as discussed offline I couldn't reproduce the plan which was sorting one of the inputs for a HASHJOIN. This might be because in the hashjoinprule we

[GitHub] drill issue #1113: DRILL-5902: Regression: Queries encounter random failure ...

2018-02-08 Thread ilooner
Github user ilooner commented on the issue: https://github.com/apache/drill/pull/1113 K thx @vrozov ---

[GitHub] drill issue #1113: DRILL-5902: Regression: Queries encounter random failure ...

2018-02-08 Thread ilooner
Github user ilooner commented on the issue: https://github.com/apache/drill/pull/1113 @vrozov Can you provide a brief description of the issue? I have recently filed https://issues.apache.org/jira/browse/DRILL-6143 and I want to verify that these are two separate issues.

[jira] [Created] (DRILL-6146) UNION with empty input on any one side returns incorrect results

2018-02-08 Thread Khurram Faraaz (JIRA)
Khurram Faraaz created DRILL-6146: - Summary: UNION with empty input on any one side returns incorrect results Key: DRILL-6146 URL: https://issues.apache.org/jira/browse/DRILL-6146 Project: Apache

[GitHub] drill issue #1101: DRILL-6032: Made the batch sizing for HashAgg more accura...

2018-02-08 Thread ilooner
Github user ilooner commented on the issue: https://github.com/apache/drill/pull/1101 @Ben-Zvi I have addressed review comments. All unit tests and functional tests (except for typical random failures are passing). I have included a commit for DRILL-6144 in this PR in order to fix

[GitHub] drill issue #1113: DRILL-5902: Regression: Queries encounter random failure ...

2018-02-08 Thread vrozov
Github user vrozov commented on the issue: https://github.com/apache/drill/pull/1113 @ilooner DRILL-6143 is not related to DRILL-5902. DRILL-6143 requires a separate RCA. See DRILL-5902 for details. ---

[GitHub] drill issue #1118: DRILL-6144: Increase direct memory for unit tests

2018-02-08 Thread ilooner
Github user ilooner commented on the issue: https://github.com/apache/drill/pull/1118 @Ben-Zvi Please review ---

[GitHub] drill pull request #1118: DRILL-6144: Increase direct memory for unit tests

2018-02-08 Thread ilooner
GitHub user ilooner opened a pull request: https://github.com/apache/drill/pull/1118 DRILL-6144: Increase direct memory for unit tests Travis builds have been hanging as well as unit tests on our Jenkins server. It is not clear what the underlying cause is but increasing direct

[GitHub] drill issue #1109: DRILL-6128: Wrong Result with Nested Loop Join

2018-02-08 Thread sohami
Github user sohami commented on the issue: https://github.com/apache/drill/pull/1109 Updated the comment and rebased on top of latest master ---

[GitHub] drill pull request #1114: Drill-6104: Added Logfile Reader

2018-02-08 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1114#discussion_r167131250 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/log/LogFormatPlugin.java --- @@ -0,0 +1,151 @@ +package

[GitHub] drill pull request #1114: Drill-6104: Added Logfile Reader

2018-02-08 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1114#discussion_r167131709 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/log/LogRecordReader.java --- @@ -0,0 +1,261 @@ +package

[GitHub] drill pull request #1114: Drill-6104: Added Logfile Reader

2018-02-08 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1114#discussion_r167131014 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/log/LogRecordReader.java --- @@ -0,0 +1,261 @@ +package

[GitHub] drill pull request #1114: Drill-6104: Added Logfile Reader

2018-02-08 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1114#discussion_r167128873 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/log/LogFormatPlugin.java --- @@ -0,0 +1,151 @@ +package

[GitHub] drill pull request #1114: Drill-6104: Added Logfile Reader

2018-02-08 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1114#discussion_r167129411 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/log/LogRecordReader.java --- @@ -0,0 +1,261 @@ +package

[GitHub] drill pull request #1114: Drill-6104: Added Logfile Reader

2018-02-08 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1114#discussion_r167129981 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/log/LogRecordReader.java --- @@ -0,0 +1,261 @@ +package

[GitHub] drill pull request #1114: Drill-6104: Added Logfile Reader

2018-02-08 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1114#discussion_r167132395 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/log/LogRecordReader.java --- @@ -0,0 +1,261 @@ +package

[GitHub] drill pull request #1114: Drill-6104: Added Logfile Reader

2018-02-08 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1114#discussion_r167131536 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/log/LogRecordReader.java --- @@ -0,0 +1,261 @@ +package

[GitHub] drill pull request #1114: Drill-6104: Added Logfile Reader

2018-02-08 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1114#discussion_r167130388 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/log/LogRecordReader.java --- @@ -0,0 +1,261 @@ +package

[GitHub] drill pull request #1114: Drill-6104: Added Logfile Reader

2018-02-08 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1114#discussion_r167132068 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/log/LogRecordReader.java --- @@ -0,0 +1,261 @@ +package

[GitHub] drill pull request #1114: Drill-6104: Added Logfile Reader

2018-02-08 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1114#discussion_r167131794 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/log/LogRecordReader.java --- @@ -0,0 +1,261 @@ +package

[GitHub] drill pull request #1114: Drill-6104: Added Logfile Reader

2018-02-08 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1114#discussion_r167129510 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/log/LogRecordReader.java --- @@ -0,0 +1,261 @@ +package

[GitHub] drill pull request #1114: Drill-6104: Added Logfile Reader

2018-02-08 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1114#discussion_r167130781 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/log/LogRecordReader.java --- @@ -0,0 +1,261 @@ +package

[GitHub] drill pull request #1114: Drill-6104: Added Logfile Reader

2018-02-08 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1114#discussion_r167130581 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/log/LogRecordReader.java --- @@ -0,0 +1,261 @@ +package

[GitHub] drill pull request #1114: Drill-6104: Added Logfile Reader

2018-02-08 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1114#discussion_r167129205 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/log/LogRecordReader.java --- @@ -0,0 +1,261 @@ +package

[GitHub] drill pull request #1114: Drill-6104: Added Logfile Reader

2018-02-08 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1114#discussion_r167130507 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/log/LogRecordReader.java --- @@ -0,0 +1,261 @@ +package

[GitHub] drill pull request #1114: Drill-6104: Added Logfile Reader

2018-02-08 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1114#discussion_r167129450 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/log/LogRecordReader.java --- @@ -0,0 +1,261 @@ +package

[GitHub] drill pull request #1114: Drill-6104: Added Logfile Reader

2018-02-08 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1114#discussion_r167131367 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/log/LogRecordReader.java --- @@ -0,0 +1,261 @@ +package

[GitHub] drill pull request #1114: Drill-6104: Added Logfile Reader

2018-02-08 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1114#discussion_r167131439 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/log/LogRecordReader.java --- @@ -0,0 +1,261 @@ +package

[GitHub] drill pull request #1114: Drill-6104: Added Logfile Reader

2018-02-08 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1114#discussion_r167128074 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/log/LogFormatPlugin.java --- @@ -0,0 +1,151 @@ +package

[GitHub] drill pull request #1114: Drill-6104: Added Logfile Reader

2018-02-08 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1114#discussion_r167128268 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/log/LogFormatPlugin.java --- @@ -0,0 +1,151 @@ +package

[GitHub] drill pull request #1114: Drill-6104: Added Logfile Reader

2018-02-08 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1114#discussion_r167128552 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/log/LogFormatPlugin.java --- @@ -0,0 +1,151 @@ +package

[GitHub] drill pull request #1114: Drill-6104: Added Logfile Reader

2018-02-08 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1114#discussion_r167132178 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/log/LogRecordReader.java --- @@ -0,0 +1,261 @@ +package

[GitHub] drill pull request #1114: Drill-6104: Added Logfile Reader

2018-02-08 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1114#discussion_r167131092 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/log/LogRecordReader.java --- @@ -0,0 +1,261 @@ +package

[GitHub] drill pull request #1114: Drill-6104: Added Logfile Reader

2018-02-08 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1114#discussion_r167130905 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/log/LogRecordReader.java --- @@ -0,0 +1,261 @@ +package

[GitHub] drill pull request #1114: Drill-6104: Added Logfile Reader

2018-02-08 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1114#discussion_r167131126 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/log/LogRecordReader.java --- @@ -0,0 +1,261 @@ +package

Re: Test cases for Drill-6104: Added Logfile Reader

2018-02-08 Thread Charles Givre
HAHAHA! I totally agree. The log parser I wrote does support some cool stuff. In addition to breaking up the fields, you can specify data types for each field as well as date and time formats. The way I set it up in the configuration is not elegant, and would welcome input as to how to do it

[GitHub] drill issue #1119: DRILL-6143: Made FragmentsRunner's rpc timeout a SystemOp...

2018-02-08 Thread ilooner
Github user ilooner commented on the issue: https://github.com/apache/drill/pull/1119 @arina-ielchiieva ---

[GitHub] drill pull request #1119: DRILL-6143: Made FragmentsRunner's rpc timeout lar...

2018-02-08 Thread ilooner
GitHub user ilooner opened a pull request: https://github.com/apache/drill/pull/1119 DRILL-6143: Made FragmentsRunner's rpc timeout larger to reduce rando… …m failures and made it configurable as a SystemOption. You can merge this pull request into a Git repository by running:

[GitHub] drill pull request #1110: DRILL-6115: SingleMergeExchange is not scaling up ...

2018-02-08 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/1110#discussion_r167089878 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/PhysicalVisitor.java --- @@ -55,10 +56,10 @@ public RETURN

[GitHub] drill pull request #1110: DRILL-6115: SingleMergeExchange is not scaling up ...

2018-02-08 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/1110#discussion_r167092037 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/xsort/TestSortSpillWithException.java --- @@ -59,6 +59,7 @@ public static void

[GitHub] drill pull request #1110: DRILL-6115: SingleMergeExchange is not scaling up ...

2018-02-08 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/1110#discussion_r167088606 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/visitor/PrelVisitor.java --- @@ -35,7 +38,9 @@ public RETURN

[GitHub] drill pull request #1110: DRILL-6115: SingleMergeExchange is not scaling up ...

2018-02-08 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/1110#discussion_r167091413 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/OrderedMuxExchange.java --- @@ -0,0 +1,58 @@ +/** + * Licensed to the

[GitHub] drill pull request #1110: DRILL-6115: SingleMergeExchange is not scaling up ...

2018-02-08 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/1110#discussion_r167090991 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/OrderedMuxExchange.java --- @@ -0,0 +1,58 @@ +/** + * Licensed to the

Batch Sizing for Parquet Flat Reader

2018-02-08 Thread salim achouche
The following document describes a proposal for enforcing batch sizing constraints (count and memory) within the Parquet Reader (Flat Schema). Please feel free to take a look and provide feedback.

[GitHub] drill issue #1109: DRILL-6128: Wrong Result with Nested Loop Join

2018-02-08 Thread amansinha100
Github user amansinha100 commented on the issue: https://github.com/apache/drill/pull/1109 +1 . Thanks for adding the unit tests. ---

[jira] [Created] (DRILL-6145) Implement Hive MapR-DB JSON handler.

2018-02-08 Thread Vitalii Diravka (JIRA)
Vitalii Diravka created DRILL-6145: -- Summary: Implement Hive MapR-DB JSON handler. Key: DRILL-6145 URL: https://issues.apache.org/jira/browse/DRILL-6145 Project: Apache Drill Issue Type: