Re: [DISCUSS] 1.13.0 release

2018-03-06 Thread Volodymyr Tkach
Right now i haven't found the reason of TestDrillbitResilience.cancelAfterAllResultsProduced failure, most likely the cause of the failure is that the query is able to have been completed before cancellation request is processed. This test not only the case, there is one more ignored test

[GitHub] drill pull request #1138: DRILL-4120: Allow implicit columns for Avro storag...

2018-03-06 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/1138#discussion_r172600066 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/avro/AvroDrillTable.java --- @@ -58,16 +65,31 @@ public AvroDrillTable(String

[GitHub] drill pull request #1138: DRILL-4120: Allow implicit columns for Avro storag...

2018-03-06 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/1138#discussion_r172606583 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/SqlConverter.java --- @@ -277,6 +279,25 @@ public String deriveAlias(

[GitHub] drill issue #1105: DRILL-6125: Fix possible memory leak when query is cancel...

2018-03-06 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/1105 Looks good, @vrozov are you ok with the changes? ---

[GitHub] drill pull request #1138: DRILL-4120: Allow implicit columns for Avro storag...

2018-03-06 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/1138#discussion_r172606895 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/types/ExtendableRelDataTypeHolder.java --- @@ -0,0 +1,82 @@ +/* + *

[GitHub] drill pull request #1138: DRILL-4120: Allow implicit columns for Avro storag...

2018-03-06 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/1138#discussion_r172599233 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/ColumnExplorer.java --- @@ -78,6 +79,23 @@ public ColumnExplorer(OptionManager

Re: Interesting in contributing to Drill

2018-03-06 Thread Kunal Khatua
The code base is huge so many contributions that I doubt anyone knows all aspects of Drill. So don't be overwhelmed by the amount of code. :) Starting with the Architecture: http://drill.apache.org/docs/architecture/ There are plenty of resources here, and even online youtube/slideshare content

[GitHub] drill pull request #1135: DRILL-6040: Added usage for graceful_stop in drill...

2018-03-06 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/1135#discussion_r172621216 --- Diff: distribution/src/resources/drillbit.sh --- @@ -45,7 +45,7 @@ # configuration file. The option takes precedence over the #

[GitHub] drill issue #1105: DRILL-6125: Fix possible memory leak when query is cancel...

2018-03-06 Thread vrozov
Github user vrozov commented on the issue: https://github.com/apache/drill/pull/1105 @ilooner @arina-ielchiieva How `innerNext()` and `close()` can execute concurrently? Does not `FragmentExecutor.hasCloseoutThread` ensure that either `close()` is called on the `run()` thread or

[GitHub] drill pull request #1138: DRILL-4120: Allow implicit columns for Avro storag...

2018-03-06 Thread vvysotskyi
Github user vvysotskyi commented on a diff in the pull request: https://github.com/apache/drill/pull/1138#discussion_r172618093 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/types/ExtendableRelDataTypeHolder.java --- @@ -0,0 +1,82 @@ +/* + *

[GitHub] drill pull request #1138: DRILL-4120: Allow implicit columns for Avro storag...

2018-03-06 Thread vvysotskyi
Github user vvysotskyi commented on a diff in the pull request: https://github.com/apache/drill/pull/1138#discussion_r172630422 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/SqlConverter.java --- @@ -277,6 +279,25 @@ public String deriveAlias(

[GitHub] drill pull request #1138: DRILL-4120: Allow implicit columns for Avro storag...

2018-03-06 Thread vvysotskyi
Github user vvysotskyi commented on a diff in the pull request: https://github.com/apache/drill/pull/1138#discussion_r172618262 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/ColumnExplorer.java --- @@ -78,6 +79,23 @@ public ColumnExplorer(OptionManager

[GitHub] drill pull request #1138: DRILL-4120: Allow implicit columns for Avro storag...

2018-03-06 Thread vvysotskyi
Github user vvysotskyi commented on a diff in the pull request: https://github.com/apache/drill/pull/1138#discussion_r172620291 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/avro/AvroDrillTable.java --- @@ -58,16 +65,31 @@ public AvroDrillTable(String

Re: Drill Hangout tomorrow at 10 am PST

2018-03-06 Thread Arina Ielchiieva
Hangout starts now. Please join. On Tue, Mar 6, 2018 at 4:04 PM, Pritesh Maker wrote: > Can we also discuss the remaining items for the 1.13 release? If something > is not ready yet, we should change the fix version to the next release. > > -Original Message- > From:

[jira] [Created] (DRILL-6213) During restart drillbit be should be killed forcefully if exceeds allowed timeout

2018-03-06 Thread Arina Ielchiieva (JIRA)
Arina Ielchiieva created DRILL-6213: --- Summary: During restart drillbit be should be killed forcefully if exceeds allowed timeout Key: DRILL-6213 URL: https://issues.apache.org/jira/browse/DRILL-6213

[GitHub] drill pull request #1135: DRILL-6040: Added usage for graceful_stop in drill...

2018-03-06 Thread priteshm
Github user priteshm commented on a diff in the pull request: https://github.com/apache/drill/pull/1135#discussion_r172619940 --- Diff: distribution/src/resources/drillbit.sh --- @@ -45,7 +45,7 @@ # configuration file. The option takes precedence over the # DRILL_CONF_DIR

[GitHub] drill issue #1150: DRILL-6210: Enhanced test schema utilities

2018-03-06 Thread ppadma
Github user ppadma commented on the issue: https://github.com/apache/drill/pull/1150 @Ben-Zvi Boaz, can you do a committer review for this PR and include it in this week's batch commit ? ---

[GitHub] drill issue #1105: DRILL-6125: Fix possible memory leak when query is cancel...

2018-03-06 Thread ilooner
Github user ilooner commented on the issue: https://github.com/apache/drill/pull/1105 @vrozov Thanks for catching this, I believe you are right. hasClouseoutThread guarantees innerNext and close won't be called concurrently. However, I still believe innerNext and

[jira] [Created] (DRILL-6215) Use prepared statement instead of Statement in JdbcRecordReader class

2018-03-06 Thread Khurram Faraaz (JIRA)
Khurram Faraaz created DRILL-6215: - Summary: Use prepared statement instead of Statement in JdbcRecordReader class Key: DRILL-6215 URL: https://issues.apache.org/jira/browse/DRILL-6215 Project:

[GitHub] drill issue #1104: DRILL-6118: Handle item star columns during project / fil...

2018-03-06 Thread paul-rogers
Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/1104 I noticed this change when merging with the latest master. What does `DYNAMIC_STAR` mean? The original `WILDCARD` name was more theoretical. How is `DYNAMIC_STAR` different from `STAR` (other

Re: [DISCUSS] 1.13.0 release

2018-03-06 Thread Kunal Khatua
Hi Parth DRILL-6216 is a release blocker that is being currently looked into.  Ref:  DRILL-6216: Metadata mismatch when connecting to a Drill 1.12.0 with a Drill-1.13.0-SNAPSHOT driver https://issues.apache.org/jira/browse/DRILL-6216 Please add it to the list of required commits as well. 

[jira] [Created] (DRILL-6214) DrillRuntimeException: Unexpected byte 0xfe at position 0 encountered while decoding UTF8 string.

2018-03-06 Thread Khurram Faraaz (JIRA)
Khurram Faraaz created DRILL-6214: - Summary: DrillRuntimeException: Unexpected byte 0xfe at position 0 encountered while decoding UTF8 string. Key: DRILL-6214 URL: https://issues.apache.org/jira/browse/DRILL-6214

[GitHub] drill issue #258: DRILL-4091: Support for additional gis operations in gis c...

2018-03-06 Thread cgivre
Github user cgivre commented on the issue: https://github.com/apache/drill/pull/258 Hi Brendan, I can review it if you can complete it. —C > On Mar 6, 2018, at 10:57, Brendan Stennett wrote: > > +1 And would be happy to help get

[GitHub] drill pull request #:

2018-03-06 Thread gparai
Github user gparai commented on the pull request: https://github.com/apache/drill/commit/9073aed67d89e8b2188870d6c812706085c9c41b#commitcomment-27961774 In logical/src/main/java/org/apache/drill/common/expression/SchemaPath.java: In

[GitHub] drill issue #1138: DRILL-4120: Allow implicit columns for Avro storage forma...

2018-03-06 Thread paul-rogers
Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/1138 @vvysotskyi, thanks for addressing the schema issues! ---

[jira] [Created] (DRILL-6216) Metadata mismatch when connecting to a Drill 1.12.0 with a Drill-1.13.0-SNAPSHOT driver

2018-03-06 Thread Kunal Khatua (JIRA)
Kunal Khatua created DRILL-6216: --- Summary: Metadata mismatch when connecting to a Drill 1.12.0 with a Drill-1.13.0-SNAPSHOT driver Key: DRILL-6216 URL: https://issues.apache.org/jira/browse/DRILL-6216

[GitHub] drill pull request #1145: DRILL-6187: Exception in RPC communication between...

2018-03-06 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/1145#discussion_r172678483 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/control/ControlClient.java --- @@ -103,6 +96,23 @@ protected void handle(ControlConnection

[GitHub] drill pull request #1145: DRILL-6187: Exception in RPC communication between...

2018-03-06 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/1145#discussion_r172718426 --- Diff: exec/rpc/src/main/java/org/apache/drill/exec/rpc/BasicClient.java --- @@ -69,6 +74,11 @@ private final IdlePingHandler pingHandler;

[GitHub] drill pull request #1145: DRILL-6187: Exception in RPC communication between...

2018-03-06 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/1145#discussion_r172642452 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java --- @@ -371,17 +376,20 @@ protected void afterExecute(final Runnable r,

[GitHub] drill pull request #1145: DRILL-6187: Exception in RPC communication between...

2018-03-06 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/1145#discussion_r172667685 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java --- @@ -312,6 +312,11 @@ public synchronized void connect(String

[GitHub] drill pull request #1145: DRILL-6187: Exception in RPC communication between...

2018-03-06 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/1145#discussion_r172678133 --- Diff: exec/rpc/src/main/java/org/apache/drill/exec/rpc/BasicClient.java --- @@ -182,6 +196,66 @@ public boolean isActive() { protected

[GitHub] drill pull request #1153: DRILL-6044: Fixed shutdown button in Web UI when s...

2018-03-06 Thread dvjyothsna
GitHub user dvjyothsna opened a pull request: https://github.com/apache/drill/pull/1153 DRILL-6044: Fixed shutdown button in Web UI when ssl,auth are enabled Fixed shutdown button to avoid cross domain requests since they are causing some issues when ssl and auth are enabled You

Re: [1.13 - Release Blocker] - DRILL-6216: Metadata mismatch when connecting to a Drill 1.12.0 with a Drill-1.13.0-SNAPSHOT driver

2018-03-06 Thread Aman Sinha
Thanks Sorabh, for the analysis and the pointers to the relevant code. Doing the version check check for client and server would be the right thing to do but probably too disruptive at this stage of the release. We should do it for the next release. For 1.13, could the change of the $values$ be

Re: [DISCUSS] 1.13.0 release

2018-03-06 Thread Sorabh Hamirwasia
Just sent an email on RCA of DRILL-6216 to discuss next steps. Thanks, Sorabh From: Parth Chandra Sent: Tuesday, March 6, 2018 6:48:21 PM To: dev Subject: Re: [DISCUSS] 1.13.0 release We have two items remaining - DRILL-1491 - Ideally, I

Re: [1.13 - Release Blocker] - DRILL-6216: Metadata mismatch when connecting to a Drill 1.12.0 with a Drill-1.13.0-SNAPSHOT driver

2018-03-06 Thread Parth Chandra
+1 on reverting this if it doesn't break things. On Wed, Mar 7, 2018 at 11:11 AM, Aman Sinha wrote: > Thanks Sorabh, for the analysis and the pointers to the relevant code. > Doing the version check check for client and server would be the right > thing to do but probably

Re: [1.13 - Release Blocker] - DRILL-6216: Metadata mismatch when connecting to a Drill 1.12.0 with a Drill-1.13.0-SNAPSHOT driver

2018-03-06 Thread Paul Rogers
Hi Sorabh, Thanks for tracking this one down. Our unit tests did not uncover this issue when I did the original PR, unfortunately. The name change was done to be consistent with other places where we use special names and, as I recall, help with certain tasks. Clearly, however, if the client

Re: [DISCUSS] 1.13.0 release

2018-03-06 Thread Parth Chandra
We have two items remaining - DRILL-1491 - Ideally, I would like to make sure that CANCEL is handled correctly with JDK 8. If the failure of the unit test is because the cancel is received after the query is completed, then the issue is less severe, but I would like to be sure that this is the

[GitHub] drill issue #1144: DRILL-6202: Deprecate usage of IndexOutOfBoundsException ...

2018-03-06 Thread parthchandra
Github user parthchandra commented on the issue: https://github.com/apache/drill/pull/1144 AFAIK, IndexOutOfBoundsException is thrown by Netty when a write to a DrillBuf goes out of bounds (see

[GitHub] drill pull request #1150: DRILL-6210: Enhanced test schema utilities

2018-03-06 Thread Ben-Zvi
Github user Ben-Zvi commented on a diff in the pull request: https://github.com/apache/drill/pull/1150#discussion_r172735136 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/rowSet/schema/SchemaBuilder.java --- @@ -0,0 +1,214 @@ +/* + * Licensed to the Apache

[1.13 - Release Blocker] - DRILL-6216: Metadata mismatch when connecting to a Drill 1.12.0 with a Drill-1.13.0-SNAPSHOT driver

2018-03-06 Thread Sorabh Hamirwasia
Hi All, The root cause for DRILL-6216 is due to a recent change made as part of https://issues.apache.org/jira/browse/DRILL-6049. With this PR a default field name for values ValueVector inside any NullableValueVector was introduced which is $values$ [1]. Before this PR the values ValueVector

[GitHub] drill issue #1150: DRILL-6210: Enhanced test schema utilities

2018-03-06 Thread paul-rogers
Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/1150 Fixed the typo. @Ben-Zvi, thanks for pointing out the unit tests: I do have test file in my branch; forgot to include it with the PR. Just did. ---

[GitHub] drill pull request #1151: DRILL-6151: Fragment executors may terminate witho...

2018-03-06 Thread vrozov
GitHub user vrozov opened a pull request: https://github.com/apache/drill/pull/1151 DRILL-6151: Fragment executors may terminate without sending final batch to a downstream causing query to hang You can merge this pull request into a Git repository by running: $ git pull

[GitHub] drill pull request #1152: DRILL-6199: Add support for filter push down and p...

2018-03-06 Thread arina-ielchiieva
GitHub user arina-ielchiieva opened a pull request: https://github.com/apache/drill/pull/1152 DRILL-6199: Add support for filter push down and partition pruning wi… …th several nested star sub-queries Re-written original solution to apply rule on later stages when we

[GitHub] drill issue #1152: DRILL-6199: Add support for filter push down and partitio...

2018-03-06 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/1152 @chunhui-shi please review. ---

[GitHub] drill issue #1151: DRILL-6151: Fragment executors may terminate without send...

2018-03-06 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/1151 The reason of the change is that some other errors can be thrown. For example, `StackOverflowError`. +1, LGTM. ---

RE: Drill Hangout tomorrow at 10 am PST

2018-03-06 Thread Pritesh Maker
Can we also discuss the remaining items for the 1.13 release? If something is not ready yet, we should change the fix version to the next release. -Original Message- From: Sorabh Hamirwasia Sent: March 5, 2018 5:28 PM To: dev@drill.apache.org Subject: Re: Drill

[GitHub] drill issue #258: DRILL-4091: Support for additional gis operations in gis c...

2018-03-06 Thread brendanstennett
Github user brendanstennett commented on the issue: https://github.com/apache/drill/pull/258 +1 And would be happy to help get it across the finish line for you. ---

[GitHub] drill issue #258: DRILL-4091: Support for additional gis operations in gis c...

2018-03-06 Thread cgivre
Github user cgivre commented on the issue: https://github.com/apache/drill/pull/258 I also would really like to see this through to completion. If there is something I can do, please let me know. > On Mar 6, 2018, at 08:04, lherrmann974 wrote:

[GitHub] drill issue #258: DRILL-4091: Support for additional gis operations in gis c...

2018-03-06 Thread lherrmann974
Github user lherrmann974 commented on the issue: https://github.com/apache/drill/pull/258 Hello, any news on this PR ? The upgraded GIS abilities would be greatly appreciated. Thanks in advance. ---

[GitHub] drill issue #1138: DRILL-4120: Allow implicit columns for Avro storage forma...

2018-03-06 Thread vvysotskyi
Github user vvysotskyi commented on the issue: https://github.com/apache/drill/pull/1138 @arina-ielchiieva, @paul-rogers, I have reworked this pull request to use `AvroDrillTable`, as it was before my changes. Also, with `AvroDrillTable` there is no need to make changes in