Github user ChrisSandison commented on the issue:
https://github.com/apache/drill/pull/1201
@cgivre do you mean including that in this PR?
---
Github user ChrisSandison commented on the issue:
https://github.com/apache/drill/pull/1201
@cgivre added comments
---
Github user priteshm commented on the issue:
https://github.com/apache/drill/pull/1204
@ppadma can you review this?
---
Github user cgivre commented on a diff in the pull request:
https://github.com/apache/drill/pull/1201#discussion_r180411032
--- Diff:
contrib/gis/src/main/java/org/apache/drill/exec/expr/fn/impl/gis/STCrosses.java
---
@@ -0,0 +1,62 @@
+/**
+ * Licensed to the Apache
Github user cgivre commented on a diff in the pull request:
https://github.com/apache/drill/pull/1201#discussion_r180411754
--- Diff:
contrib/gis/src/main/java/org/apache/drill/exec/expr/fn/impl/gis/STDifference.java
---
@@ -0,0 +1,66 @@
+/**
+ * Licensed to the Apache
Github user cgivre commented on a diff in the pull request:
https://github.com/apache/drill/pull/1201#discussion_r180410015
--- Diff:
contrib/gis/src/main/java/org/apache/drill/exec/expr/fn/impl/gis/STBuffer.java
---
@@ -0,0 +1,65 @@
+/**
+ * Licensed to the Apache
Github user cgivre commented on a diff in the pull request:
https://github.com/apache/drill/pull/1201#discussion_r180412106
--- Diff:
contrib/gis/src/main/java/org/apache/drill/exec/expr/fn/impl/gis/STDisjoint.java
---
@@ -0,0 +1,62 @@
+/**
+ * Licensed to the Apache
Github user vdiravka commented on the issue:
https://github.com/apache/drill/pull/1205
@Wizwizard Please follow this guideline while opening PR:
https://drill.apache.org/docs/apache-drill-contribution-guidelines/#step-3:-get-your-code-reviewed-and-committed-to-the-project.
*
Github user amansinha100 commented on the issue:
https://github.com/apache/drill/pull/1204
@oleg-zinovev good catch with the empty array input for Flatten. I had
reviewed the original JIRA DRILL-6099 but did not consider the empty arrays.
It would be good for @gparai to also take
Github user priteshm commented on the issue:
https://github.com/apache/drill/pull/1204
@arina-ielchiieva or @vdiravka can you review this?
---
Github user cgivre commented on the issue:
https://github.com/apache/drill/pull/1201
If you want to include it on this PR that would be great, but Iâm fine
with including it in a separate PR as well. I want to get this functionality
into Drill asap, so it probably would be quicker
Thanks for all the suggestions everyone! It looks like table functions
are the closest to what I am looking for.
- Ryan
On 2018-04-08 02:25 AM, Paul Rogers wrote:
Hi Ryan,
There is an obscure, but very handy feature of Drill called table functions.
[1] These allow you to set parameters of
Github user cgivre commented on the issue:
https://github.com/apache/drill/pull/1201
@ChrisSandison This isn't a review comment, but @k255 was working on a
format plugin for ESRI shape files. Would you want to take a look and see if
we could get that in as well? I could see that
Charles Givre created DRILL-6319:
Summary: Format Plugin for ESRI Shape Files
Key: DRILL-6319
URL: https://issues.apache.org/jira/browse/DRILL-6319
Project: Apache Drill
Issue Type:
Github user cgivre commented on the issue:
https://github.com/apache/drill/pull/1201
@ChrisSandison Done. Here's a link to the JIRA
https://issues.apache.org/jira/browse/DRILL-6319
---
GitHub user Wizwizard opened a pull request:
https://github.com/apache/drill/pull/1205
1.13.0
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Wizwizard/drill 1.13.0
Alternatively you can review and apply these changes as the
Github user ChrisSandison commented on the issue:
https://github.com/apache/drill/pull/1201
@cgivre I agree. Would you be able to open a JIRA ticket with any details
of the work that @k255 was doing for it?
---
Github user ChrisSandison commented on the issue:
https://github.com/apache/drill/pull/1201
@cgivre I'm also needing to use ST_DWithin
(https://postgis.net/docs/ST_DWithin.html). I'm going to add it to this PR.
---
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/1204#discussion_r180539313
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/flatten/TestFlattenPlanning.java
---
@@ -66,8 +66,11 @@ public void
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/1204#discussion_r180539160
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillPushLimitToScanRule.java
---
@@ -89,14 +92,17 @@ public void
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/1204#discussion_r180538860
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillPushLimitToScanRule.java
---
@@ -74,9 +74,12 @@ public boolean
Timothy Farkas created DRILL-6320:
-
Summary: Don't Allow Javadoc comments for license headers
Key: DRILL-6320
URL: https://issues.apache.org/jira/browse/DRILL-6320
Project: Apache Drill
Thanks Paul, I'll try to incorporate your feedback, and I'll ask you to review
when I open a PR. By the way, would it be possible to copy your unit testing
docs from your wiki to the docs folder in the Drill repo as well? There is a
lot of good information that people may be missing out on
Hi Tim,
All the info on the wiki is public, so feel free to grab that which is useful.
Would be happy to review the PR when ready. Once the information is moved, I'll
change we Wiki to point to the new markdown doc within Drill source.
Thanks,
- Paul
On Tuesday, April 10, 2018,
Parth Chandra created DRILL-6321:
Summary: Lateral Join: Planning changes - enable submitting
physical plan
Key: DRILL-6321
URL: https://issues.apache.org/jira/browse/DRILL-6321
Project: Apache Drill
Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/1144#discussion_r180598658
--- Diff: exec/vector/src/main/codegen/templates/VariableLengthVectors.java
---
@@ -534,15 +534,11 @@ public void setSafe(int index, byte[] bytes) {
Parth Chandra created DRILL-6322:
Summary: Lateral Join: Common changes - Add new iterOutcome,
Operator types, MockRecordBatch for testing
Key: DRILL-6322
URL: https://issues.apache.org/jira/browse/DRILL-6322
Github user sohami commented on the issue:
https://github.com/apache/drill/pull/1202
@vrozov - Update the PR based on your suggestion. The command `mvn test
Parth Chandra created DRILL-6324:
Summary: Unnest - Initial Implementation
Key: DRILL-6324
URL: https://issues.apache.org/jira/browse/DRILL-6324
Project: Apache Drill
Issue Type: Task
Parth Chandra created DRILL-6323:
Summary: Lateral Join - Initial implementation
Key: DRILL-6323
URL: https://issues.apache.org/jira/browse/DRILL-6323
Project: Apache Drill
Issue Type: Task
Github user kkhatua commented on the issue:
https://github.com/apache/drill/pull/1168
@sachouche have you had a chance to test the generated JDBC driver with
Spotfire/SQuirreL ?
---
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/1203#discussion_r180553686
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/service/ServiceEngine.java
---
@@ -102,6 +105,7 @@ public DrillbitEndpoint start() throws
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/1205#discussion_r180565011
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java ---
@@ -577,6 +581,8 @@ public Version getServerVersion() {
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/1205#discussion_r180564939
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java ---
@@ -170,6 +170,8 @@ public DrillClient(DrillConfig config,
Github user kkhatua commented on the issue:
https://github.com/apache/drill/pull/1200
@Ben-Zvi / @paul-rogers I've updated the PR with changes based on your
comments. Waiting for a review.
---
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/1205#discussion_r180564452
--- Diff: exec/java-exec/src/main/resources/rest/query/query.ftl ---
@@ -21,11 +21,12 @@
-
+
--- End diff --
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/1205#discussion_r180564629
--- Diff: exec/java-exec/src/main/resources/rest/query/query_bak.ftl ---
@@ -0,0 +1,124 @@
+<#-- Licensed to the Apache Software Foundation (ASF) under
Github user sachouche commented on the issue:
https://github.com/apache/drill/pull/1168
No I didn't.
Regards,
Salim
Regards,
Salim
-Original Message-
From: Kunal Khatua [notificati...@github.com]
Received: Tuesday, 10 Apr 2018, 14:01
GitHub user oleg-zinovev opened a pull request:
https://github.com/apache/drill/pull/1204
DRILL-6318
Test for DRILL-6099 was changed due it's incorrect behavior
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/oleg-zinovev/drill
Hi Tim,
Great idea! Anything to improve tests is a Good Thing. You have my vote.
FWIW, my notes on Drill testing are in [1]. The three "Updated" links are
probably the most useful as they explain the test framework added over the last
year or so. See also the "ExampleTest" class that shows how
Oleg Zinoviev created DRILL-6318:
Summary: Push down limit into flatten is incorrect
Key: DRILL-6318
URL: https://issues.apache.org/jira/browse/DRILL-6318
Project: Apache Drill
Issue Type:
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1202
LGTM +1.
---
GitHub user paul-rogers opened a pull request:
https://github.com/apache/drill/pull/1206
DRILL_6314: Add complex types to result set loader
This PR is a bit of a large one as it adds Union, (non repeated) List and
Repeated List type support to the column accessors, row set
Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/1206
@ppadma can you look at this one? It's a big one. Suggestion: work through
small groups of files, perhaps one commit at a time as the layers are separated
into separate commits. Maybe do a
44 matches
Mail list logo
