[GitHub] paul-rogers commented on issue #1455: DRILL-6724: Convert IndexOutOfBounds exception to UserException with …

paul-rogers commented on issue #1455: DRILL-6724: Convert IndexOutOfBounds exception to UserException with … URL: https://github.com/apache/drill/pull/1455#issuecomment-418433987 @KazydubB, thanks for the explanation. You are inserting code everywhere you believe an IOBE could be thrown.

[GitHub] priteshm commented on issue #1453: DRILL-6710: Disallow negative scale for decimal data type

priteshm commented on issue #1453: DRILL-6710: Disallow negative scale for decimal data type URL: https://github.com/apache/drill/pull/1453#issuecomment-418447069 @vvysotskyi any update on the PR for the functional tests?

[jira] [Created] (DRILL-6728) DRILL-4864 - doc udfs for date, time, timestamp functions

Bridget Bevens created DRILL-6728: - Summary: DRILL-4864 - doc udfs for date, time, timestamp functions Key: DRILL-6728 URL: https://issues.apache.org/jira/browse/DRILL-6728 Project: Apache Drill

[GitHub] vdiravka commented on a change in pull request #1455: DRILL-6724: Convert IndexOutOfBounds exception to UserException with …

vdiravka commented on a change in pull request #1455: DRILL-6724: Convert IndexOutOfBounds exception to UserException with … URL: https://github.com/apache/drill/pull/1455#discussion_r214899539 ## File path:

[GitHub] denysord88 commented on issue #1453: DRILL-6710: Disallow negative scale for decimal data type

denysord88 commented on issue #1453: DRILL-6710: Disallow negative scale for decimal data type URL: https://github.com/apache/drill/pull/1453#issuecomment-418454385 @priteshm PR is ready, but I have some issues in drill-test-framework after baselines updates. In negative tests

[GitHub] arina-ielchiieva commented on a change in pull request #1454: DRILL-6684: Swap sys.options and sys.options_val tables

arina-ielchiieva commented on a change in pull request #1454: DRILL-6684: Swap sys.options and sys.options_val tables URL: https://github.com/apache/drill/pull/1454#discussion_r215002783 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/SystemTable.java

[GitHub] arina-ielchiieva edited a comment on issue #1455: DRILL-6724: Convert IndexOutOfBounds exception to UserException with …

arina-ielchiieva edited a comment on issue #1455: DRILL-6724: Convert IndexOutOfBounds exception to UserException with … URL: https://github.com/apache/drill/pull/1455#issuecomment-418445266 @paul-rogers one thing I am not sure about is that stack trace contains all needed

[GitHub] vdiravka commented on issue #1455: DRILL-6724: Convert IndexOutOfBounds exception to UserException with …

vdiravka commented on issue #1455: DRILL-6724: Convert IndexOutOfBounds exception to UserException with … URL: https://github.com/apache/drill/pull/1455#issuecomment-418492480 @KazydubB It would be useful to show the use case how the error was displayed and how it is changed after these

[GitHub] arina-ielchiieva commented on issue #1455: DRILL-6724: Convert IndexOutOfBounds exception to UserException with …

arina-ielchiieva commented on issue #1455: DRILL-6724: Convert IndexOutOfBounds exception to UserException with … URL: https://github.com/apache/drill/pull/1455#issuecomment-418445266 @paul-rogers one thing I am not sure about is that stack trace contains all needed information,

[GitHub] arina-ielchiieva commented on a change in pull request #1437: DRILL-6702: Disable CPU Reporting for non-HotSpot JDKs

arina-ielchiieva commented on a change in pull request #1437: DRILL-6702: Disable CPU Reporting for non-HotSpot JDKs URL: https://github.com/apache/drill/pull/1437#discussion_r215004905 ## File path: common/src/main/java/org/apache/drill/exec/metrics/CpuGaugeSet.java ##

[GitHub] kkhatua commented on a change in pull request #1454: DRILL-6684: Swap sys.options and sys.options_val tables

kkhatua commented on a change in pull request #1454: DRILL-6684: Swap sys.options and sys.options_val tables URL: https://github.com/apache/drill/pull/1454#discussion_r215012117 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/SystemTable.java ##

[GitHub] paul-rogers commented on issue #1455: DRILL-6724: Convert IndexOutOfBounds exception to UserException with …

paul-rogers commented on issue #1455: DRILL-6724: Convert IndexOutOfBounds exception to UserException with … URL: https://github.com/apache/drill/pull/1455#issuecomment-418465629 @arina-ielchiieva, very good point. Having that information is very useful regardless of the source of error.

[GitHub] vdiravka commented on a change in pull request #1455: DRILL-6724: Convert IndexOutOfBounds exception to UserException with …

vdiravka commented on a change in pull request #1455: DRILL-6724: Convert IndexOutOfBounds exception to UserException with … URL: https://github.com/apache/drill/pull/1455#discussion_r214906760 ## File path:

[GitHub] vdiravka commented on a change in pull request #1455: DRILL-6724: Convert IndexOutOfBounds exception to UserException with …

vdiravka commented on a change in pull request #1455: DRILL-6724: Convert IndexOutOfBounds exception to UserException with … URL: https://github.com/apache/drill/pull/1455#discussion_r214906574 ## File path:

[GitHub] vdiravka commented on a change in pull request #1455: DRILL-6724: Convert IndexOutOfBounds exception to UserException with …

vdiravka commented on a change in pull request #1455: DRILL-6724: Convert IndexOutOfBounds exception to UserException with … URL: https://github.com/apache/drill/pull/1455#discussion_r214904295 ## File path:

[GitHub] kkhatua closed pull request #1454: DRILL-6684: Swap sys.options and sys.options_val tables

kkhatua closed pull request #1454: DRILL-6684: Swap sys.options and sys.options_val tables URL: https://github.com/apache/drill/pull/1454 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] kkhatua closed pull request #1437: DRILL-6702: Disable CPU Reporting for non-HotSpot JDKs

kkhatua closed pull request #1437: DRILL-6702: Disable CPU Reporting for non-HotSpot JDKs URL: https://github.com/apache/drill/pull/1437 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[GitHub] Ben-Zvi commented on issue #1450: DRILL-6717: lower and upper functions not works with national characters

Ben-Zvi commented on issue #1450: DRILL-6717: lower and upper functions not works with national characters URL: https://github.com/apache/drill/pull/1450#issuecomment-418558342 @arina-ielchiieva - I'm still undecided; the Java technology is mature enough to handle national characters

[jira] [Created] (DRILL-6730) Possible connection leak while accessing S3

Siarhei Krukau created DRILL-6730: - Summary: Possible connection leak while accessing S3 Key: DRILL-6730 URL: https://issues.apache.org/jira/browse/DRILL-6730 Project: Apache Drill Issue

[GitHub] Ben-Zvi commented on issue #1455: DRILL-6724: Convert IndexOutOfBounds exception to UserException with …

Ben-Zvi commented on issue #1455: DRILL-6724: Convert IndexOutOfBounds exception to UserException with … URL: https://github.com/apache/drill/pull/1455#issuecomment-418573131 The IBM JVM has a special call: `com.ibm.jvm.Dump.SystemDump()` that generates a dump (similar to a Linux core

[GitHub] cgivre commented on issue #1443: DRILL-6705: Fix various failures in Crypto / Network / Phonetic functions when invalid input is given

cgivre commented on issue #1443: DRILL-6705: Fix various failures in Crypto / Network / Phonetic functions when invalid input is given URL: https://github.com/apache/drill/pull/1443#issuecomment-418498922 +1 Built from source, ran all tests, ran ad-hoc queries.

[GitHub] paul-rogers edited a comment on issue #1455: DRILL-6724: Convert IndexOutOfBounds exception to UserException with …

paul-rogers edited a comment on issue #1455: DRILL-6724: Convert IndexOutOfBounds exception to UserException with … URL: https://github.com/apache/drill/pull/1455#issuecomment-418506296 As it turns out, it is actually rather difficult to test an exceptions such as these. We are catching

[GitHub] paul-rogers commented on issue #1455: DRILL-6724: Convert IndexOutOfBounds exception to UserException with …

paul-rogers commented on issue #1455: DRILL-6724: Convert IndexOutOfBounds exception to UserException with … URL: https://github.com/apache/drill/pull/1455#issuecomment-418506296 Note that is is, in general, very hard to test an exception such as these. We are catching programming errors.

[jira] [Created] (DRILL-6729) Enabled unnest lateral join feature by default

Sorabh Hamirwasia created DRILL-6729: Summary: Enabled unnest lateral join feature by default Key: DRILL-6729 URL: https://issues.apache.org/jira/browse/DRILL-6729 Project: Apache Drill

[GitHub] sohami opened a new pull request #1456: DRILL-6729: Enable Unnest/Lateral Join feature by default

sohami opened a new pull request #1456: DRILL-6729: Enable Unnest/Lateral Join feature by default URL: https://github.com/apache/drill/pull/1456 @Ben-Zvi - Please help to review this PR. This is an automated message from the

[GitHub] agozhiy commented on issue #1449: DRILL-6544: Timestamp value in Drill UI showed inconsistently with th…

agozhiy commented on issue #1449: DRILL-6544: Timestamp value in Drill UI showed inconsistently with th… URL: https://github.com/apache/drill/pull/1449#issuecomment-418355164 Addressed the review comments. Added the following options to set the display format from a pattern:

[GitHub] arina-ielchiieva commented on a change in pull request #1449: DRILL-6544: Timestamp value in Drill UI showed inconsistently with th…

arina-ielchiieva commented on a change in pull request #1449: DRILL-6544: Timestamp value in Drill UI showed inconsistently with th… URL: https://github.com/apache/drill/pull/1449#discussion_r214915641 ## File path:

[GitHub] arina-ielchiieva commented on a change in pull request #1449: DRILL-6544: Timestamp value in Drill UI showed inconsistently with th…

arina-ielchiieva commented on a change in pull request #1449: DRILL-6544: Timestamp value in Drill UI showed inconsistently with th… URL: https://github.com/apache/drill/pull/1449#discussion_r214913061 ## File path:

[GitHub] arina-ielchiieva commented on a change in pull request #1449: DRILL-6544: Timestamp value in Drill UI showed inconsistently with th…

arina-ielchiieva commented on a change in pull request #1449: DRILL-6544: Timestamp value in Drill UI showed inconsistently with th… URL: https://github.com/apache/drill/pull/1449#discussion_r214913414 ## File path:

[GitHub] arina-ielchiieva commented on a change in pull request #1449: DRILL-6544: Timestamp value in Drill UI showed inconsistently with th…

arina-ielchiieva commented on a change in pull request #1449: DRILL-6544: Timestamp value in Drill UI showed inconsistently with th… URL: https://github.com/apache/drill/pull/1449#discussion_r214911963 ## File path:

[GitHub] arina-ielchiieva commented on a change in pull request #1449: DRILL-6544: Timestamp value in Drill UI showed inconsistently with th…

arina-ielchiieva commented on a change in pull request #1449: DRILL-6544: Timestamp value in Drill UI showed inconsistently with th… URL: https://github.com/apache/drill/pull/1449#discussion_r214911907 ## File path:

[GitHub] arina-ielchiieva commented on a change in pull request #1449: DRILL-6544: Timestamp value in Drill UI showed inconsistently with th…

arina-ielchiieva commented on a change in pull request #1449: DRILL-6544: Timestamp value in Drill UI showed inconsistently with th… URL: https://github.com/apache/drill/pull/1449#discussion_r214916478 ## File path:

[GitHub] vdiravka commented on a change in pull request #1455: DRILL-6724: Convert IndexOutOfBounds exception to UserException with …

vdiravka commented on a change in pull request #1455: DRILL-6724: Convert IndexOutOfBounds exception to UserException with … URL: https://github.com/apache/drill/pull/1455#discussion_r214906574 ## File path:

[GitHub] vdiravka commented on a change in pull request #1455: DRILL-6724: Convert IndexOutOfBounds exception to UserException with …

vdiravka commented on a change in pull request #1455: DRILL-6724: Convert IndexOutOfBounds exception to UserException with … URL: https://github.com/apache/drill/pull/1455#discussion_r214904295 ## File path:

[GitHub] vdiravka commented on a change in pull request #1455: DRILL-6724: Convert IndexOutOfBounds exception to UserException with …

vdiravka commented on a change in pull request #1455: DRILL-6724: Convert IndexOutOfBounds exception to UserException with … URL: https://github.com/apache/drill/pull/1455#discussion_r214899539 ## File path:

[GitHub] vdiravka commented on a change in pull request #1455: DRILL-6724: Convert IndexOutOfBounds exception to UserException with …

vdiravka commented on a change in pull request #1455: DRILL-6724: Convert IndexOutOfBounds exception to UserException with … URL: https://github.com/apache/drill/pull/1455#discussion_r214906760 ## File path:

[GitHub] vdiravka commented on a change in pull request #1455: DRILL-6724: Convert IndexOutOfBounds exception to UserException with …

vdiravka commented on a change in pull request #1455: DRILL-6724: Convert IndexOutOfBounds exception to UserException with … URL: https://github.com/apache/drill/pull/1455#discussion_r214878343 ## File path:

[GitHub] vdiravka commented on a change in pull request #1455: DRILL-6724: Convert IndexOutOfBounds exception to UserException with …

vdiravka commented on a change in pull request #1455: DRILL-6724: Convert IndexOutOfBounds exception to UserException with … URL: https://github.com/apache/drill/pull/1455#discussion_r214905003 ## File path:

[GitHub] KazydubB edited a comment on issue #1455: DRILL-6724: Convert IndexOutOfBounds exception to UserException with …

KazydubB edited a comment on issue #1455: DRILL-6724: Convert IndexOutOfBounds exception to UserException with … URL: https://github.com/apache/drill/pull/1455#issuecomment-418324098 @paul-rogers, possible sources of IOBE here is when allocating value vector buffers or reading records

[GitHub] KazydubB commented on a change in pull request #1455: DRILL-6724: Convert IndexOutOfBounds exception to UserException with …

KazydubB commented on a change in pull request #1455: DRILL-6724: Convert IndexOutOfBounds exception to UserException with … URL: https://github.com/apache/drill/pull/1455#discussion_r214858699 ## File path:

[GitHub] KazydubB commented on a change in pull request #1455: DRILL-6724: Convert IndexOutOfBounds exception to UserException with …

KazydubB commented on a change in pull request #1455: DRILL-6724: Convert IndexOutOfBounds exception to UserException with … URL: https://github.com/apache/drill/pull/1455#discussion_r214857836 ## File path: