Re: Drill JDBC Plugin limit queries

2018-10-18 Thread Vitalii Diravka
Rahul, Possibly *JdbcGroupScan* can be improved, for instance by overriding *supportsLimitPushdown()* and *applyLimit()* methods, *double rows *field can be updated by the limit value. I've performed the following query: select * from mysql.`testdb`.`table` limit 2; but the following one is

[GitHub] kkhatua opened a new pull request #1507: DRILL-6715: Update descriptions for System Options table

2018-10-18 Thread GitBox
kkhatua opened a new pull request #1507: DRILL-6715: Update descriptions for System Options table URL: https://github.com/apache/drill/pull/1507 With introduction of DRILL-5735 , the descriptions for about half the system options still remain missing. This commit collects descriptions

[GitHub] kkhatua commented on issue #1507: DRILL-6715: Update descriptions for System Options table

2018-10-18 Thread GitBox
kkhatua commented on issue #1507: DRILL-6715: Update descriptions for System Options table URL: https://github.com/apache/drill/pull/1507#issuecomment-431208488 Looks like I broke a couple of tests looking for `ORDERED_MUX_EXCHANGE`. Will update that.

[GitHub] kkhatua commented on issue #1507: DRILL-6715: Update descriptions for System Options table

2018-10-18 Thread GitBox
kkhatua commented on issue #1507: DRILL-6715: Update descriptions for System Options table URL: https://github.com/apache/drill/pull/1507#issuecomment-431207872 @vvysotskyi can you take a look at the commit "MD-4843 Patch" ? (commit ID:

[GitHub] kkhatua commented on issue #1502: DRILL-6785: DataClient is using RootAllocator in the bootstrap instea…

2018-10-18 Thread GitBox
kkhatua commented on issue #1502: DRILL-6785: DataClient is using RootAllocator in the bootstrap instea… URL: https://github.com/apache/drill/pull/1502#issuecomment-431205172 @sohami what is teh QA impact for this? This is

[GitHub] ilooner-mapr commented on a change in pull request #1465: DRILL-6719: Separate spilling queue logic from HashJoin and HashAgg.

2018-10-18 Thread GitBox
ilooner-mapr commented on a change in pull request #1465: DRILL-6719: Separate spilling queue logic from HashJoin and HashAgg. URL: https://github.com/apache/drill/pull/1465#discussion_r226435604 ## File path:

[GitHub] ilooner commented on issue #1465: DRILL-6719: Separate spilling queue logic from HashJoin and HashAgg.

2018-10-18 Thread GitBox
ilooner commented on issue #1465: DRILL-6719: Separate spilling queue logic from HashJoin and HashAgg. URL: https://github.com/apache/drill/pull/1465#issuecomment-431188548 @Ben-Zvi Thanks for the review, I applied your review comments. Please take another look.

[jira] [Created] (DRILL-6804) Simplify Usage of OperatorPhase in HashAgg Template

2018-10-18 Thread Timothy Farkas (JIRA)
Timothy Farkas created DRILL-6804: - Summary: Simplify Usage of OperatorPhase in HashAgg Template Key: DRILL-6804 URL: https://issues.apache.org/jira/browse/DRILL-6804 Project: Apache Drill

[GitHub] ilooner commented on a change in pull request #1465: DRILL-6719: Separate spilling queue logic from HashJoin and HashAgg.

2018-10-18 Thread GitBox
ilooner commented on a change in pull request #1465: DRILL-6719: Separate spilling queue logic from HashJoin and HashAgg. URL: https://github.com/apache/drill/pull/1465#discussion_r226441908 ## File path:

[GitHub] ilooner commented on a change in pull request #1465: DRILL-6719: Separate spilling queue logic from HashJoin and HashAgg.

2018-10-18 Thread GitBox
ilooner commented on a change in pull request #1465: DRILL-6719: Separate spilling queue logic from HashJoin and HashAgg. URL: https://github.com/apache/drill/pull/1465#discussion_r226446320 ## File path:

[GitHub] ilooner commented on a change in pull request #1465: DRILL-6719: Separate spilling queue logic from HashJoin and HashAgg.

2018-10-18 Thread GitBox
ilooner commented on a change in pull request #1465: DRILL-6719: Separate spilling queue logic from HashJoin and HashAgg. URL: https://github.com/apache/drill/pull/1465#discussion_r226436612 ## File path:

[GitHub] lushuifeng commented on issue #1481: DRILL-6763: Codegen optimization of SQL functions with constant values

2018-10-18 Thread GitBox
lushuifeng commented on issue #1481: DRILL-6763: Codegen optimization of SQL functions with constant values URL: https://github.com/apache/drill/pull/1481#issuecomment-430953524 @vvysotskyi setter method have been removed, the formula of `maxIndex` should be same as before.