Re: [GitHub] drill issue #507: DRILL-4690: CORS in REST API

I think to avoid that size increase is to revert back to the previous change which implemented the CORS manually and did not introduce this extra jar file. If our goal is to eat only one egg we don't need to buy a hen. On Mon, Jun 6, 2016 at 2:36 PM, sudheeshkatkam wrote: >

Re: how to create a second pull request?

Usually I create one branch under my own repo for one fix, then submit a new pull request from that branch. On Thu, Jun 9, 2016 at 12:46 PM, Dave Oshinsky wrote: > My user on github already has one Apache Drill fork, and one pull request ( >

Re: [ANNOUNCE] New PMC Chair of Apache Drill

Big congratulations to Parth! Thanks Jacques for founding Drill project and way to go drillers! Chunhui On Wed, May 25, 2016 at 11:45 AM, John Omernik wrote: > Congratz Parth, and thank you Jacques! > > On Wed, May 25, 2016 at 1:25 PM, Xiao Meng wrote: >

[GitHub] drill pull request: DRILL-4618: Fix hive function loader not corre...

GitHub user chunhui-shi opened a pull request: https://github.com/apache/drill/pull/509 DRILL-4618: Fix hive function loader not correctly take random flag; … …and function visitor should not use previous function holder if this function is nondeterministic You can merge

Re: are random numbers broken?

There are two issues, one is we use hive's deterministic flag in an opposite way, another one is when drill visit an expression, we take a previous found holder, but that is not right if this function is nondeterministic. A JIRA was created and a pull request of fix was posted:

[GitHub] drill pull request: DRILL-4237 DRILL-4478 fully implement hash to ...

GitHub user chunhui-shi opened a pull request: https://github.com/apache/drill/pull/430 DRILL-4237 DRILL-4478 fully implement hash to use murmur3 and corresp… Since we have to have our own implementations of hash functions, UNIT tests should guarantee the correctness

[GitHub] drill pull request: DRILL-4237 DRILL-4478 fully implement hash to ...

Github user chunhui-shi closed the pull request at: https://github.com/apache/drill/pull/408 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] drill pull request: DRILL-4143: Fix inconsistency in writing metad...

GitHub user chunhui-shi opened a pull request: https://github.com/apache/drill/pull/470 DRILL-4143: Fix inconsistency in writing metadata with different user's permission. When accessing readBlockMeta, use an impersonated special Filesystem object which is of drillbituser. So we

[GitHub] drill pull request: DRILL-4143: Fix inconsistency in writing metad...

Github user chunhui-shi commented on the pull request: https://github.com/apache/drill/pull/470#issuecomment-207939397 This function is one entrance to access metadata. Write (Automatic metadata update) will happen during this 'read' process if there is any directory/file under

[GitHub] drill pull request: DRILL-4237 DRILL-4478 fully implement hash to ...

Github user chunhui-shi commented on a diff in the pull request: https://github.com/apache/drill/pull/430#discussion_r59290217 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/DrillHash.java --- @@ -0,0 +1,50 @@ +/** + * Licensed to the Apache

[GitHub] drill pull request: DRILL-4237 DRILL-4478 fully implement hash to ...

Github user chunhui-shi commented on a diff in the pull request: https://github.com/apache/drill/pull/430#discussion_r59290818 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/MurmurHash3.java --- @@ -0,0 +1,280 @@ +/** + * Licensed to the Apache

[GitHub] drill pull request: DRILL-4237 DRILL-4478 fully implement hash to ...

Github user chunhui-shi commented on a diff in the pull request: https://github.com/apache/drill/pull/430#discussion_r59290968 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestHashBase.java --- @@ -0,0 +1,72 @@ +/** + * Licensed to the Apache

Re: are random numbers broken?

The rand([seed optional]) is loaded from hive's UDF, the 'random()' function is drill's implementation. Since drill has the logic to use the previous function container thus the previous result is reused. I would say this is a bug for random generator. The fix should be allowing some functions

[GitHub] drill pull request: DRILL-4143: Fix inconsistency in writing metad...

Github user chunhui-shi commented on the pull request: https://github.com/apache/drill/pull/470#issuecomment-208558947 This createMeta is only called in RefreshMetadataHandler using a DrillFileSystem created locally without impersonation, so the filesystem used in createMeta needs

[GitHub] drill pull request: DRILL-4237 DRILL-4478 fully implement hash to ...

Github user chunhui-shi commented on a diff in the pull request: https://github.com/apache/drill/pull/430#discussion_r56924863 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/HashHelper.java --- @@ -17,47 +17,77 @@ */ package

[GitHub] drill pull request: DRILL-4237 DRILL-4478 fully implement hash to ...

Github user chunhui-shi commented on a diff in the pull request: https://github.com/apache/drill/pull/430#discussion_r57202442 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/HashHelper.java --- @@ -17,47 +17,77 @@ */ package

[GitHub] drill pull request: DRILL-4237 DRILL-4478 fully implement hash to ...

Github user chunhui-shi commented on a diff in the pull request: https://github.com/apache/drill/pull/430#discussion_r57203072 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/MurmurHash3.java --- @@ -0,0 +1,264 @@ +/** + * Licensed to the Apache

[GitHub] drill pull request: DRILL-4237 DRILL-4478 fully implement hash to ...

Github user chunhui-shi commented on a diff in the pull request: https://github.com/apache/drill/pull/430#discussion_r57206301 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/MurmurHash3.java --- @@ -0,0 +1,264 @@ +/** + * Licensed to the Apache

[GitHub] drill pull request: DRILL-4237 DRILL-4478 fully implement hash to ...

Github user chunhui-shi commented on the pull request: https://github.com/apache/drill/pull/408#issuecomment-193430786 As to the test code that use original cpp implementation to generate the test vectors in murmur3_buf.json and murmur3_double.json. Please refer to here

Re: Configuring User Authentication failed

Hi Xueping, The drill-module.conf should be put into the your jar file. The logic about what jar to scan(thus to extract the class) during startup is based on if there is a drill-module.conf in that jar file. Hope this helps. Thanks, Chunhui On Tue, Mar 29, 2016 at 2:29 AM,

Re: [GitHub] drill pull request: DRILL-4237 DRILL-4478 fully implement hash to ...

Thanks for pointing to openHFT. I went through multiple Java implementations including this one. The reason I decided to use smhasher as the source of truth was, the smhasher implementation includes comprehensive tests to cover the attributes for measuring goodness of a non-cryptographic hash

[GitHub] drill pull request: DRILL-4143: Fix inconsistency in writing metad...

Github user chunhui-shi closed the pull request at: https://github.com/apache/drill/pull/470 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] drill pull request: DRILL-4237: Implement murmur3 for HashHelper

Github user chunhui-shi commented on the pull request: https://github.com/apache/drill/pull/485#issuecomment-212017670 Previous pull request and comments: https://github.com/apache/drill/pull/408 --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] drill pull request: DRILL-4237: Implement murmur3 for HashHelper

Github user chunhui-shi commented on the pull request: https://github.com/apache/drill/pull/485#issuecomment-212021177 https://github.com/apache/drill/pull/430 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] drill pull request: DRILL-4237 DRILL-4478 fully implement hash to ...

Github user chunhui-shi closed the pull request at: https://github.com/apache/drill/pull/430 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] drill pull request: DRILL-4237: Implement murmur3 for HashHelper

GitHub user chunhui-shi opened a pull request: https://github.com/apache/drill/pull/485 DRILL-4237: Implement murmur3 for HashHelper Unit Test was removed from this commit. Test codes and the the test vector generator program will be included in functional tests in a separate

[GitHub] drill pull request #518: DRILL-4653.json - Malformed JSON should not stop th...

Github user chunhui-shi commented on a diff in the pull request: https://github.com/apache/drill/pull/518#discussion_r70879473 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/store/json/TestJsonRecordReader.java --- @@ -159,64 +164,91 @@ public void drill_3353

[GitHub] drill pull request #518: DRILL-4653.json - Malformed JSON should not stop th...

Github user chunhui-shi commented on a diff in the pull request: https://github.com/apache/drill/pull/518#discussion_r70879554 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/store/json/TestJsonRecordReader.java --- @@ -159,64 +164,91 @@ public void drill_3353

[GitHub] drill issue #518: DRILL-4653.json - Malformed JSON should not stop the entir...

Github user chunhui-shi commented on the issue: https://github.com/apache/drill/pull/518 Thanks for providing a way to skip bad json records and addressing my comments. Besides the minor improvements I suggested above: comment format changes that may be due to line width in your

[GitHub] drill pull request #518: DRILL-4653.json - Malformed JSON should not stop th...

Github user chunhui-shi commented on a diff in the pull request: https://github.com/apache/drill/pull/518#discussion_r70872218 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/store/json/TestJsonRecordReader.java --- @@ -56,11 +57,19 @@ public void

Re: [VOTE] Release Apache Drill 1.8.0 - rc0

+1 Built from source zip file with unit test all passed on Linux Randomly verified DRILL-4825 On Fri, Aug 12, 2016 at 3:52 AM, Arina Yelchiyeva < arina.yelchiy...@gmail.com> wrote: > +1 (non-binding) > On Windows built from source, ran in embedded mode. > Installed on cluster. > Checked some

[GitHub] drill issue #546: DRILL-4783: flatten operator should not throw exception if...

Github user chunhui-shi commented on the issue: https://github.com/apache/drill/pull/546 Thanks @jaltekruse for the review. I updated exception text and added test case following your suggestion. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] drill pull request #546: DRILL-4783: flatten operator should not throw excep...

Github user chunhui-shi commented on a diff in the pull request: https://github.com/apache/drill/pull/546#discussion_r71634838 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/flatten/FlattenRecordBatch.java --- @@ -129,11 +129,21 @@ private void

[GitHub] drill issue #546: DRILL-4783: flatten operator should not throw exception if...

Github user chunhui-shi commented on the issue: https://github.com/apache/drill/pull/546 Update based on Jinfeng's comment. Jinfeng, could you check if I addressed your concern? Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] drill pull request #546: DRILL-4783: flatten operator should not throw excep...

GitHub user chunhui-shi opened a pull request: https://github.com/apache/drill/pull/546 DRILL-4783: flatten operator should not throw exception if there is empty resultset returned for underlying operator which is convert_from or other complex functions. You can merge this pull

[GitHub] drill issue #509: DRILL-4618: Fix hive function loader not correctly take ra...

Github user chunhui-shi commented on the issue: https://github.com/apache/drill/pull/509 @StevenMPhillips Hi Steven, is this fix addressing your concern now? Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] drill issue #546: DRILL-4783: flatten operator should not throw exception if...

Github user chunhui-shi commented on the issue: https://github.com/apache/drill/pull/546 @jaltekruse Hi Jason, could you help to review this change? Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] drill pull request #546: DRILL-4783: flatten operator should not throw excep...

Github user chunhui-shi commented on a diff in the pull request: https://github.com/apache/drill/pull/546#discussion_r71471032 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/flatten/FlattenRecordBatch.java --- @@ -129,8 +129,14 @@ private void

Re: A light-weight, versioned client API for Drill

Cool. And we know that there are already many 'light weight' APIs soon become the main stream APIs. On Tue, Jul 19, 2016 at 10:56 PM, Paul Rogers wrote: > Hi All, > > As I’ve been playing with and learning about Drill, it struck me that > Drill is a wonderful “industrial

[GitHub] drill pull request #518: DRILL-4653.json - Malformed JSON should not stop th...

Github user chunhui-shi commented on a diff in the pull request: https://github.com/apache/drill/pull/518#discussion_r70863798 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/fn/JsonReader.java --- @@ -110,21 +118,29 @@ public void

[GitHub] drill pull request #535: DRILL-4695: Log error thrown from drillbit.run

GitHub user chunhui-shi opened a pull request: https://github.com/apache/drill/pull/535 DRILL-4695: Log error thrown from drillbit.run You can merge this pull request into a Git repository by running: $ git pull https://github.com/chunhui-shi/drill errexit Alternatively you

[GitHub] drill pull request #535: DRILL-4695: Log error thrown from drillbit.run

Github user chunhui-shi closed the pull request at: https://github.com/apache/drill/pull/535 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] drill pull request #537: DRILL-4695: Log error thrown out of drillbit.run be...

GitHub user chunhui-shi opened a pull request: https://github.com/apache/drill/pull/537 DRILL-4695: Log error thrown out of drillbit.run before close Seems reverting previous change closes the pull request, have to send a new one. Thanks Sudheesh for prompt code review

[GitHub] drill pull request #722: DRILL-5196: init MongoDB cluster when run a single ...

Github user chunhui-shi closed the pull request at: https://github.com/apache/drill/pull/722 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] drill pull request #741: DRILL-5196: init MongoDB cluster when run a single ...

GitHub user chunhui-shi opened a pull request: https://github.com/apache/drill/pull/741 DRILL-5196: init MongoDB cluster when run a single test case directly… … through command line or IDE. Other fixes include: Sync mongo-java-driver versions to newer 3.2.0

[GitHub] drill pull request #741: DRILL-5196: init MongoDB cluster when run a single ...

Github user chunhui-shi commented on a diff in the pull request: https://github.com/apache/drill/pull/741#discussion_r99452939 --- Diff: contrib/storage-mongo/src/test/java/org/apache/drill/exec/store/mongo/MongoTestSuit.java --- @@ -234,15 +243,25 @@ private static void

[GitHub] drill pull request #702: DRILL-5088: set default codec for toJson

Github user chunhui-shi commented on a diff in the pull request: https://github.com/apache/drill/pull/702#discussion_r99448154 --- Diff: contrib/storage-mongo/src/test/java/org/apache/drill/exec/store/mongo/TestTableGenerator.java --- @@ -58,7 +59,16 @@ public static void

[GitHub] drill pull request #741: DRILL-5196: init MongoDB cluster when run a single ...

Github user chunhui-shi commented on a diff in the pull request: https://github.com/apache/drill/pull/741#discussion_r99453293 --- Diff: contrib/storage-mongo/src/test/java/org/apache/drill/exec/store/mongo/MongoTestSuit.java --- @@ -234,15 +243,25 @@ private static void

[GitHub] drill issue #594: DRILL-4842: SELECT * on JSON data results in NumberFormatE...

Github user chunhui-shi commented on the issue: https://github.com/apache/drill/pull/594 +1. LGTM. Need to address conflict before ready to commit. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] drill pull request #741: DRILL-5196: init MongoDB cluster when run a single ...

Github user chunhui-shi commented on a diff in the pull request: https://github.com/apache/drill/pull/741#discussion_r99455997 --- Diff: contrib/storage-mongo/src/test/java/org/apache/drill/exec/store/mongo/MongoTestSuit.java --- @@ -204,16 +209,20 @@ private static void cleanup

Re: Storage Plugin for accessing Hive ORC Table from Drill

I guess you are using Hive 2.0 as meta server while Drill has only 1.2 libraries. In Hive 2.0 above, This delta format could have more than one '_' as separator while 1.2 has only one '_'. I think Drill should eventually update to use Hive's 2.0/2.1 libraries.

[GitHub] drill pull request #750: DRILL-5273: CompliantTextReader excessive memory us...

Github user chunhui-shi commented on a diff in the pull request: https://github.com/apache/drill/pull/750#discussion_r102377194 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/text/compliant/CompliantTextRecordReader.java --- @@ -118,12 +118,21 @@ public

Hangout will start in minutes

The link of hangout is: https://plus.google.com/hangouts/_/event/ci4rdiju8bv04a64efj5fedd0lc

Drill's Hangout topics for tomorrow (10am-11am 8/23/2016 PDT)

The topics I think we should cover are: 1, Updates on 1.8.0 release. 2, Recently there are some thoughts on how to improve and shorten unit tests. Would like to get some more inputs on this topic. If there is any topic you feel that we should discuss, please feel free to bring them up here or

Re: [VOTE] Release Apache Drill 1.8.0 - rc1

+1(non binding) Built from source under apache profile with Unit tests passed. Ran some queries all got expected results. On Mon, Aug 29, 2016 at 2:13 PM, Paul Rogers wrote: > +1 (non binding) > > The Drill-on-YARN project is coming soon. That project has an exhaustive >

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

Github user chunhui-shi commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r78791984 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/security/plain/PlainServer.java --- @@ -0,0 +1,174 @@ +/** + * Licensed

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

Github user chunhui-shi commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r78798093 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserServer.java --- @@ -246,28 +154,80 @@ protected void handle

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

Github user chunhui-shi commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r78790827 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/security/plain/PlainServer.java --- @@ -0,0 +1,174 @@ +/** + * Licensed

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

Github user chunhui-shi commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r78791283 --- Diff: protocol/src/main/java/org/apache/drill/exec/proto/UserProtos.java --- @@ -47,157 +47,165 @@ public static void registerAllExtensions

[GitHub] drill pull request #605: DRILL-4870 drill-config.sh sets JAVA_HOME incorrect...

Github user chunhui-shi commented on a diff in the pull request: https://github.com/apache/drill/pull/605#discussion_r82488363 --- Diff: distribution/src/resources/drill-config.sh --- @@ -392,5 +392,7 @@ export DRILL_HOME export DRILL_CONF_DIR export DRILL_LOG_DIR

[GitHub] drill pull request #605: DRILL-4870 drill-config.sh sets JAVA_HOME incorrect...

Github user chunhui-shi commented on a diff in the pull request: https://github.com/apache/drill/pull/605#discussion_r82488367 --- Diff: distribution/src/resources/drill-config.sh --- @@ -392,5 +392,7 @@ export DRILL_HOME export DRILL_CONF_DIR export DRILL_LOG_DIR

[GitHub] drill pull request #604: DRILL-4862: binary_string should use another buffer...

Github user chunhui-shi commented on a diff in the pull request: https://github.com/apache/drill/pull/604#discussion_r82315506 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/StringFunctions.java --- @@ -1540,15 +1540,16 @@ public void eval

[GitHub] drill pull request #605: DRILL-4870 drill-config.sh sets JAVA_HOME incorrect...

Github user chunhui-shi commented on a diff in the pull request: https://github.com/apache/drill/pull/605#discussion_r82496282 --- Diff: distribution/src/resources/drill-config.sh --- @@ -392,5 +392,7 @@ export DRILL_HOME export DRILL_CONF_DIR export DRILL_LOG_DIR

[GitHub] drill issue #587: DRILL-4894: Fix unit test failure in 'storage-hive/core' m...

Github user chunhui-shi commented on the issue: https://github.com/apache/drill/pull/587 +1, unit test passed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

Re: Hangout will start in minutes

uild improvement, e.g. split java-exec into smaller pieces, remove stdout output of unit tests, maven run in parallel, timing unit tests, drill bit restart, etc. unit tests fails often. windows, Mac, linux, Chunhui On Tue, Aug 23, 2016 at 10:04 AM, Chunhui Shi <c...@maprtech.com> wrote:

[GitHub] drill pull request #594: DRILL-4842: SELECT * on JSON data results in Number...

Github user chunhui-shi commented on a diff in the pull request: https://github.com/apache/drill/pull/594#discussion_r81627752 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/fn/JsonReader.java --- @@ -56,6 +58,12 @@ private final boolean

[GitHub] drill pull request #594: DRILL-4842: SELECT * on JSON data results in Number...

Github user chunhui-shi commented on a diff in the pull request: https://github.com/apache/drill/pull/594#discussion_r81622069 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/fn/JsonReader.java --- @@ -131,14 +139,33 @@ public void

[GitHub] drill pull request #594: DRILL-4842: SELECT * on JSON data results in Number...

Github user chunhui-shi commented on a diff in the pull request: https://github.com/apache/drill/pull/594#discussion_r81619869 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/fn/JsonReader.java --- @@ -418,6 +447,7 @@ private void writeDataAllText

[GitHub] drill pull request #594: DRILL-4842: SELECT * on JSON data results in Number...

Github user chunhui-shi commented on a diff in the pull request: https://github.com/apache/drill/pull/594#discussion_r81617585 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/fn/JsonReader.java --- @@ -131,14 +139,33 @@ public void

[GitHub] drill pull request #594: DRILL-4842: SELECT * on JSON data results in Number...

Github user chunhui-shi commented on a diff in the pull request: https://github.com/apache/drill/pull/594#discussion_r81619047 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/fn/JsonReader.java --- @@ -337,6 +364,7 @@ private void writeData(MapWriter

[GitHub] drill pull request #636: DRILL-4951: Do Guava.patch earlier so we can run si...

GitHub user chunhui-shi opened a pull request: https://github.com/apache/drill/pull/636 DRILL-4951: Do Guava.patch earlier so we can run single Hbase's unit … …test through command line or IDE You can merge this pull request into a Git repository by running: $ git pull

[GitHub] drill issue #638: DRILL-4982: Separate Hive reader classes for different dat...

Github user chunhui-shi commented on the issue: https://github.com/apache/drill/pull/638 The performance degradation is worse with larger tables. The degradation is >300% on a 15GB table. After this fix, this degradation disappears. There are other visible performance ga

Hangout tomorrow

Hi all, We are going to have our bi-weekly hangout tomorrow (11/29/16, 10 AM PST). Please add your suggestions or topics to this thread. We will be asking for topics at the beginning of the hangout. Hangout link: https://hangouts.google.com/hangouts/_/event/ci4rdiju8bv04a64efj5fedd0lc Regards,

Re: [VOTE] Release Apache Drill 1.9.0 RC1

+1 (non-binding) 1, clone branch from https://github.com/sudheeshkatkam/drill/ switch to drill-1.9.0 branch 2, built drill from source with unit tests. All passes 3, check git-properties 4, run embedded mode and verify some parquet and

[GitHub] drill pull request #659: DRILL-5050: C++ client library has symbol resolutio...

Github user chunhui-shi commented on a diff in the pull request: https://github.com/apache/drill/pull/659#discussion_r88765929 --- Diff: contrib/native/client/readme.macos --- @@ -0,0 +1,79 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] drill pull request #659: DRILL-5050: C++ client library has symbol resolutio...

Github user chunhui-shi commented on a diff in the pull request: https://github.com/apache/drill/pull/659#discussion_r88765954 --- Diff: contrib/native/client/readme.macos --- @@ -0,0 +1,79 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] drill pull request #659: DRILL-5050: C++ client library has symbol resolutio...

Github user chunhui-shi commented on a diff in the pull request: https://github.com/apache/drill/pull/659#discussion_r88766028 --- Diff: contrib/native/client/readme.boost --- @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] drill pull request #659: DRILL-5050: C++ client library has symbol resolutio...

Github user chunhui-shi commented on a diff in the pull request: https://github.com/apache/drill/pull/659#discussion_r88765875 --- Diff: contrib/native/client/readme.boost --- @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [ANNOUNCE] - New Apache Drill Committer - Neeraja Rentachintala

Congratulations! On Thu, Nov 17, 2016 at 11:23 AM, Subbu Srinivasan wrote: > Congrats. > Wish I had more time to contribute more(, perils of working in a > startup) > > > On Thu, Nov 17, 2016 at 11:18 AM, Jason Altekruse > wrote: > > >

Re: About the IN condition push down.

I feel that we should allow preserving IN operator and not transforming it to OR or HashJoin, and seems this has to be done in Calcite. So we could allow pushing IN to scan/reader to utilize progressing data formats and index designs, e.g. min/max, a variety of bloom filters. On Wed, Nov 16, 2016

[GitHub] drill pull request #594: DRILL-4842: SELECT * on JSON data results in Number...

Github user chunhui-shi commented on a diff in the pull request: https://github.com/apache/drill/pull/594#discussion_r85984205 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/fn/JsonReader.java --- @@ -59,12 +59,13 @@ private final

[GitHub] drill pull request #638: DRILL-4982: Separate Hive reader classes for differ...

GitHub user chunhui-shi opened a pull request: https://github.com/apache/drill/pull/638 DRILL-4982: Separate Hive reader classes for different data formats t… …o improve performance. 1, Separating Hive reader classes allows optimization to apply on different classes

[GitHub] drill pull request #619: DRILL-4946: redirect System.err so users under embe...

Github user chunhui-shi commented on a diff in the pull request: https://github.com/apache/drill/pull/619#discussion_r86431608 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/util/StdErrCapturer.java --- @@ -0,0 +1,81 @@ +/** + * Licensed to the Apache

[GitHub] drill issue #607: Drill 3423:Add New HTTPD format plugin

Github user chunhui-shi commented on the issue: https://github.com/apache/drill/pull/607 Some generic questions: Do we expect to develop one format plugin for one kind of log? And is this format plugin designed to supporting multiple(e.g. hundreds) formats for one kind of log

[GitHub] drill pull request #619: DRILL-4946: redirect System.err so users under embe...

GitHub user chunhui-shi opened a pull request: https://github.com/apache/drill/pull/619 DRILL-4946: redirect System.err so users under embedded mode won't se… …e error stacks printed due to errors occurred in scalar replacement. You can merge this pull request into a Git

Questions about Scalar Replacement

Hi Drill devs, Since I recently worked on a bug fix for which I need to test with a query and that query triggered a mysterious error: org.objectweb.asm.tree.analysis.AnalyzerException: Expected an object reference, but found . The error stack was printed during drillbit running, meanwhile

[GitHub] drill issue #654: DRILL-5032: Drill query on hive parquet table failed with ...

Github user chunhui-shi commented on the issue: https://github.com/apache/drill/pull/654 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] drill pull request #696: DRILL-4558: BSonReader should prepare buffer size a...

GitHub user chunhui-shi opened a pull request: https://github.com/apache/drill/pull/696 DRILL-4558: BSonReader should prepare buffer size as actual need You can merge this pull request into a Git repository by running: $ git pull https://github.com/chunhui-shi/drill DRILL

[GitHub] drill pull request #695: DRILL-4868: fix how hive function set DrillBuf.

GitHub user chunhui-shi opened a pull request: https://github.com/apache/drill/pull/695 DRILL-4868: fix how hive function set DrillBuf. You can merge this pull request into a Git repository by running: $ git pull https://github.com/chunhui-shi/drill DRILL-4868 Alternatively

[GitHub] drill issue #682: DRILL-5113: Upgrade Maven RAT plugin to avoid annoying XML...

Github user chunhui-shi commented on the issue: https://github.com/apache/drill/pull/682 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] drill pull request #654: DRILL-5032: Drill query on hive parquet table faile...

Github user chunhui-shi commented on a diff in the pull request: https://github.com/apache/drill/pull/654#discussion_r91152465 --- Diff: contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveUtilities.java --- @@ -398,17 +399,13 @@ public static void

[GitHub] drill pull request #594: DRILL-4842: SELECT * on JSON data results in Number...

Github user chunhui-shi commented on a diff in the pull request: https://github.com/apache/drill/pull/594#discussion_r92452185 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/fn/JsonReader.java --- @@ -510,10 +517,13 @@ private void writeDataAllText

[GitHub] drill pull request #683: DRILL-5114: Rationalize use of Logback logging in u...

Github user chunhui-shi commented on a diff in the pull request: https://github.com/apache/drill/pull/683#discussion_r92451193 --- Diff: exec/memory/base/src/test/resources/logback-test.xml --- @@ -0,0 +1,42 @@ + --- End diff -- Why could not the test here use

[GitHub] drill pull request #683: DRILL-5114: Rationalize use of Logback logging in u...

Github user chunhui-shi commented on a diff in the pull request: https://github.com/apache/drill/pull/683#discussion_r92451306 --- Diff: logical/src/test/resources/logback-test.xml --- @@ -0,0 +1,42 @@ + +

[GitHub] drill pull request #687: DRILL-4996: Parquet Date auto-correction is not wor...

Github user chunhui-shi commented on a diff in the pull request: https://github.com/apache/drill/pull/687#discussion_r92882778 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestCorruptParquetDateCorrection.java --- @@ -201,68 +203,34 @@ public

[GitHub] drill pull request #687: DRILL-4996: Parquet Date auto-correction is not wor...

Github user chunhui-shi commented on a diff in the pull request: https://github.com/apache/drill/pull/687#discussion_r92883043 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestCorruptParquetDateCorrection.java --- @@ -273,26 +241,28 @@ public

[GitHub] drill issue #702: DRILL-5088: set default codec for toJson

Github user chunhui-shi commented on the issue: https://github.com/apache/drill/pull/702 MongoGroupScan tries to read first record to guess record width. So this toJson is called for only first record. Notice that MongoClient.getDefaultCodecRegistry() contains

[GitHub] drill pull request #594: DRILL-4842: SELECT * on JSON data results in Number...

Github user chunhui-shi commented on a diff in the pull request: https://github.com/apache/drill/pull/594#discussion_r90494185 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/fn/JsonReader.java --- @@ -59,12 +59,13 @@ private final

[GitHub] drill pull request #675: DRILL-5094: Comparator should guarantee transitive ...

GitHub user chunhui-shi opened a pull request: https://github.com/apache/drill/pull/675 DRILL-5094: Comparator should guarantee transitive attribute. You can merge this pull request into a Git repository by running: $ git pull https://github.com/chunhui-shi/drill DRILL-5094

[GitHub] drill issue #638: DRILL-4982: Separate Hive reader classes for different dat...

Github user chunhui-shi commented on the issue: https://github.com/apache/drill/pull/638 Addressed your comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

  1   2   3   >