[GitHub] drill issue #500: DRILL-3149: TextReader should support multibyte line delim...

2016-06-14 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/500 @parthchandra I have added / updated several unit test with second commit. Could you please take a look? --- If your project is set up for it, you can reply to this email and have your

[GitHub] drill pull request #523: DRILL-2593: 500 error when crc for a query profile ...

2016-06-14 Thread arina-ielchiieva
GitHub user arina-ielchiieva opened a pull request: https://github.com/apache/drill/pull/523 DRILL-2593: 500 error when crc for a query profile is out of sync In case we have corrupted profile, it will be skipped but dismissable warning will be generated. You can merge this pull

[GitHub] drill pull request #522: DRILL-4716: status.json doesn't work in drill ui

2016-06-14 Thread arina-ielchiieva
GitHub user arina-ielchiieva opened a pull request: https://github.com/apache/drill/pull/522 DRILL-4716: status.json doesn't work in drill ui 1. /status.json returns { "status" : "Running!" } 2. Removed link to System Options on /status as redun

[GitHub] drill issue #436: DRILL-4514 : Add describe schema command

2016-06-15 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/436 @jinfengni PR is updated, physical_location is removed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] drill pull request: DRILL-4701: Fix log name and missing lines in logs on We...

2016-06-01 Thread arina-ielchiieva
GitHub user arina-ielchiieva opened a pull request: https://github.com/apache/drill/pull/511 DRILL-4701: Fix log name and missing lines in logs on Web UI You can merge this pull request into a Git repository by running: $ git pull https://github.com/arina-ielchiieva/drill

[GitHub] drill issue #500: DRILL-3149: TextReader should support multibyte line delim...

2016-06-16 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/500 Done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] drill pull request #500: DRILL-3149: TextReader should support multibyte lin...

2016-06-21 Thread arina-ielchiieva
Github user arina-ielchiieva closed the pull request at: https://github.com/apache/drill/pull/500 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] drill issue #523: DRILL-2593: 500 error when crc for a query profile is out ...

2016-06-21 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/523 Merged into master with commit 2862beaf5c72ccaafc6c52b9956f2d0414948b67 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] drill pull request #523: DRILL-2593: 500 error when crc for a query profile ...

2016-06-21 Thread arina-ielchiieva
Github user arina-ielchiieva closed the pull request at: https://github.com/apache/drill/pull/523 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] drill pull request #511: DRILL-4701: Fix log name and missing lines in logs ...

2016-06-21 Thread arina-ielchiieva
Github user arina-ielchiieva closed the pull request at: https://github.com/apache/drill/pull/511 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] drill issue #511: DRILL-4701: Fix log name and missing lines in logs on Web ...

2016-06-21 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/511 Changes merged into master with commit id 4123ed2a539cd3f9812f22f96d56aa4709828acd --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] drill issue #500: DRILL-3149: TextReader should support multibyte line delim...

2016-06-21 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/500 Changed merged into master with commit id - 223507b76ff6c2227e667ae4a53f743c92edd295 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] drill pull request #522: DRILL-4716: status.json doesn't work in drill ui

2016-06-21 Thread arina-ielchiieva
Github user arina-ielchiieva closed the pull request at: https://github.com/apache/drill/pull/522 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] drill issue #522: DRILL-4716: status.json doesn't work in drill ui

2016-06-21 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/522 Chnages merged into master with commit 1c451a341e80c2372be47d999741240fb5495eea --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] drill pull request #531: DRILL-4733: max(dir0) reading more columns than nec...

2016-06-21 Thread arina-ielchiieva
GitHub user arina-ielchiieva opened a pull request: https://github.com/apache/drill/pull/531 DRILL-4733: max(dir0) reading more columns than necessary You can merge this pull request into a Git repository by running: $ git pull https://github.com/arina-ielchiieva/drill DRILL

[GitHub] drill pull request #531: DRILL-4733: max(dir0) reading more columns than nec...

2016-06-21 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/531#discussion_r67915875 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/store/TestImplicitFileColumns.java --- @@ -110,4 +111,20 @@ public void

[GitHub] drill pull request #531: DRILL-4733: max(dir0) reading more columns than nec...

2016-06-21 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/531#discussion_r67916478 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/easy/EasyFormatPlugin.java --- @@ -126,8 +127,12 @@ CloseableRecordBatch

[GitHub] drill pull request #531: DRILL-4733: max(dir0) reading more columns than nec...

2016-06-21 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/531#discussion_r67962703 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/store/TestImplicitFileColumns.java --- @@ -110,4 +111,20 @@ public void

[GitHub] drill pull request #531: DRILL-4733: max(dir0) reading more columns than nec...

2016-06-23 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/531#discussion_r68207004 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/store/TestImplicitFileColumns.java --- @@ -110,4 +111,20 @@ public void

[GitHub] drill pull request: DRILL-3944: Drill MAXDIR Unknown variable or t...

2016-02-26 Thread arina-ielchiieva
GitHub user arina-ielchiieva opened a pull request: https://github.com/apache/drill/pull/391 DRILL-3944: Drill MAXDIR Unknown variable or type "FILE_SEPARATOR" 1. Fixed issue with unknown variable or type "FILE_SEPARATOR". 2. Fixed error when directory functi

[GitHub] drill pull request: DRILL-3688: Drill should honor "skip.header.li...

2016-02-18 Thread arina-ielchiieva
GitHub user arina-ielchiieva opened a pull request: https://github.com/apache/drill/pull/382 DRILL-3688: Drill should honor "skip.header.line.count" and "skip.foo… Drill should honor "skip.header.line.count" and "skip.footer.line.count&qu

[GitHub] drill pull request: DRILL-3745: Hive CHAR not supported

2016-03-01 Thread arina-ielchiieva
GitHub user arina-ielchiieva opened a pull request: https://github.com/apache/drill/pull/399 DRILL-3745: Hive CHAR not supported 1. Added Hive Char support in queries and udf-s out parameter. Char is trimmed first and then treated as varchar. 2. Unit tests. You can merge

[GitHub] drill pull request: DRILL-4571: Add link to local Drill logs from ...

2016-04-07 Thread arina-ielchiieva
GitHub user arina-ielchiieva opened a pull request: https://github.com/apache/drill/pull/472 DRILL-4571: Add link to local Drill logs from the web UI You can merge this pull request into a Git repository by running: $ git pull https://github.com/arina-ielchiieva/drill DRILL

[GitHub] drill pull request: DRILL-4596: Drill should do version check amon...

2016-04-08 Thread arina-ielchiieva
GitHub user arina-ielchiieva opened a pull request: https://github.com/apache/drill/pull/474 DRILL-4596: Drill should do version check among drillbits You can merge this pull request into a Git repository by running: $ git pull https://github.com/arina-ielchiieva/drill DRILL

[GitHub] drill pull request: DRILL-4596: Drill should do version check amon...

2016-04-12 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/474#discussion_r59332891 --- Diff: common/src/main/java/org/apache/drill/common/util/DrillVersionInfo.java --- @@ -49,10 +53,52 @@ public static String getVersion

[GitHub] drill pull request: DRILL-4596: Drill should do version check amon...

2016-04-11 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the pull request: https://github.com/apache/drill/pull/474#issuecomment-208428822 Updated PR. New implementation approach: 1. we allow to register any drillbit (disregarding the version). 2. instead of getting available endpoints

[GitHub] drill pull request: DRILL-4523: Disallow using loopback address in...

2016-04-06 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the pull request: https://github.com/apache/drill/pull/445#issuecomment-206378459 1. Updated host file so hostname points to the localhost address: a. started Drill in embedded mode -> started successfully. b. started drill

[GitHub] drill pull request: DRILL-4596: Drill should do version check amon...

2016-04-08 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the pull request: https://github.com/apache/drill/pull/474#issuecomment-207529907 Drill version is defined from build manifest file [1]. There is no config setting to override it. Though if you want to change version in "master&quo

[GitHub] drill pull request: DRILL-4596: Drill should do version check amon...

2016-04-08 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/474#discussion_r59077998 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/Drillbit.java --- @@ -207,6 +209,28 @@ private void javaPropertiesToSystemOptions

[GitHub] drill pull request: DRILL-4596: Drill should do version check amon...

2016-04-11 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the pull request: https://github.com/apache/drill/pull/474#issuecomment-208521519 I thought it's hard to maintain backward compatibility. Quoting Parth comment from Jira: "Drill needs to be able to run queries that depend only on fea

[GitHub] drill pull request: DRILL-4596: Drill should do version check amon...

2016-04-11 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the pull request: https://github.com/apache/drill/pull/474#issuecomment-208557847 If we add new type to version 1.7, it can't work with version 1.6 where this type is absent, that's why I am adding support only for +1 version. At this point

[GitHub] drill pull request: DRILL-3745: Hive CHAR not supported

2016-03-19 Thread arina-ielchiieva
Github user arina-ielchiieva closed the pull request at: https://github.com/apache/drill/pull/399 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] drill pull request: DRILL-4514 : Add describe schema ...

2016-03-21 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/436#discussion_r56893518 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/SqlDescribeSchema.java --- @@ -0,0 +1,82

[GitHub] drill pull request: DRILL-4514 : Add describe schema ...

2016-03-22 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/436#discussion_r56957490 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/DescribeSchemaCommandResult.java --- @@ -0,0 +1,30

[GitHub] drill pull request: DRILL-4514 : Add describe schema ...

2016-03-22 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/436#discussion_r56957772 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/SqlDescribeSchema.java --- @@ -0,0 +1,82

[GitHub] drill pull request: DRILL-4514 : Add describe schema ...

2016-03-22 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/436#discussion_r57066817 --- Diff: exec/java-exec/src/main/codegen/includes/parserImpls.ftl --- @@ -278,3 +278,19 @@ SqlNode SqlRefreshMetadata

[GitHub] drill pull request: DRILL-4514 : Add describe schema ...

2016-03-24 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the pull request: https://github.com/apache/drill/pull/436#issuecomment-200934256 Created Calcite Jira - https://issues.apache.org/jira/browse/CALCITE-1168 --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] drill pull request: DRILL-4514 : Add describe schema ...

2016-03-21 Thread arina-ielchiieva
GitHub user arina-ielchiieva opened a pull request: https://github.com/apache/drill/pull/436 DRILL-4514 : Add describe schema command Syntax: describe database describe schema Current implementation covers only dfs schema. For all other "" will b

[GitHub] drill pull request: DRILL-4523: Disallow using loopback address in...

2016-04-04 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/445#discussion_r58358260 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/service/ServiceEngine.java --- @@ -177,6 +182,18 @@ public void run

[GitHub] drill pull request: DRILL-4523: Disallow using loopback address in...

2016-04-05 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/445#discussion_r58505168 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/service/ServiceEngine.java --- @@ -177,6 +182,13 @@ public void run

[GitHub] drill pull request: DRILL-4523: Disallow using loopback address in...

2016-04-05 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/445#discussion_r58505187 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/service/ServiceEngine.java --- @@ -177,6 +182,13 @@ public void run

[GitHub] drill pull request: DRILL-4544: Improve error messages for REFRESH...

2016-03-30 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the pull request: https://github.com/apache/drill/pull/448#issuecomment-203372090 Comment from Jacques was meant for https://github.com/apache/drill/pull/436 (DRILL-4514: Add describe schema command), sorry for confusion. --- If your

[GitHub] drill pull request: DRILL-4514 : Add describe schema ...

2016-03-30 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the pull request: https://github.com/apache/drill/pull/436#issuecomment-203372453 Comment from Jacques - Let's open a follow-up bug to move this to Calcite and get in Drill for now (was accidentally added to https://github.com/apache/drill

[GitHub] drill pull request: DRILL-4514 : Add describe schema ...

2016-03-30 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the pull request: https://github.com/apache/drill/pull/436#issuecomment-203501750 @hnfgns, @jacques-n Could you please review this pull request? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] drill pull request: DRILL-4544: Improve error messages for REFRESH...

2016-04-01 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/448#discussion_r58179906 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/RefreshMetadataHandler.java --- @@ -64,6 +65,11 @@ public

[GitHub] drill pull request: DRILL-4571: Add link to local Drill logs from ...

2016-04-14 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/472#discussion_r59694227 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java --- @@ -303,4 +303,9 @@ StringValidator

[GitHub] drill pull request: DRILL-4604: Generate warning on Web UI if dril...

2016-04-27 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the pull request: https://github.com/apache/drill/pull/482#issuecomment-215135279 @sudheeshkatkam, I have updated pull request according your comments: 1. renamed bit -> drillbit where applicable 2. updated warning mess

[GitHub] drill pull request: DRILL-4604: Generate warning on Web UI if dril...

2016-04-26 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/482#discussion_r61122648 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/DrillRoot.java --- @@ -55,44 +59,89 @@ public Viewable getStats

[GitHub] drill pull request: DRILL-4604: Generate warning on Web UI if dril...

2016-04-26 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/482#discussion_r61119749 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/DrillRoot.java --- @@ -55,44 +59,89 @@ public Viewable getStats

[GitHub] drill pull request: DRILL-3149: TextReader should support multibyt...

2016-05-09 Thread arina-ielchiieva
GitHub user arina-ielchiieva opened a pull request: https://github.com/apache/drill/pull/500 DRILL-3149: TextReader should support multibyte line delimiters You can merge this pull request into a Git repository by running: $ git pull https://github.com/arina-ielchiieva/drill

[GitHub] drill pull request: DRILL-3474: Add implicit file columns support

2016-05-11 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/491#discussion_r62879671 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/project/ProjectRecordBatch.java --- @@ -324,6 +324,11 @@ protected

[GitHub] drill pull request: DRILL-3474: Add implicit file columns support

2016-05-11 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/491#discussion_r62879209 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java --- @@ -148,6 +148,18 @@ String

[GitHub] drill pull request: DRILL-3474: Add implicit file columns support

2016-05-11 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/491#discussion_r62879684 --- Diff: contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveDrillNativeScanBatchCreator.java --- @@ -67,17 +67,15

[GitHub] drill pull request: DRILL-4514 : Add describe schema ...

2016-05-12 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the pull request: https://github.com/apache/drill/pull/436#issuecomment-218763967 @jinfengni, I agree that it could be useful to display content shown in webui storage tab as well. I have added new column `properties` which

[GitHub] drill pull request: DRILL-4514 : Add describe schema ...

2016-05-12 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the pull request: https://github.com/apache/drill/pull/436#issuecomment-218793124 By default physical location is returned as INFORMATION UNAVAILABLE (as defined in AbstractStoragePlugin.getPhysicalLocation method). When adding new storage

[GitHub] drill pull request: DRILL-4514 : Add describe schema ...

2016-05-13 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the pull request: https://github.com/apache/drill/pull/436#issuecomment-219052569 @jinfengni I have updated PR. Now describe command returns only one column `properties` which contains information shown in webui storage tab. Also I have

[GitHub] drill pull request: DRILL-4604: Generate warning on Web UI if dril...

2016-04-18 Thread arina-ielchiieva
GitHub user arina-ielchiieva opened a pull request: https://github.com/apache/drill/pull/482 DRILL-4604: Generate warning on Web UI if drillbits version mismatch … …is detected You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] drill pull request #436: DRILL-4514 : Add describe schema comm...

2016-07-12 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/436#discussion_r70406745 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/DescribeSchemaHandler.java --- @@ -0,0 +1,129

[GitHub] drill issue #445: DRILL-4523: Disallow using loopback address in distributed...

2016-07-26 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/445 @halevaavi you might check your /etc/hosts file. There should be line like this: 172.16.21.16 your.domain.com your_hostname --- If your project is set up for it, you can reply

[GitHub] drill pull request #554: DRILL-4801: Setting extractHeader attribute for CSV...

2016-07-26 Thread arina-ielchiieva
GitHub user arina-ielchiieva opened a pull request: https://github.com/apache/drill/pull/554 DRILL-4801: Setting extractHeader attribute for CSV format does not p… …ropagate to all drillbits You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] drill pull request #436: DRILL-4514 : Add describe schema comm...

2016-07-12 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/436#discussion_r70434370 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/DescribeSchemaHandler.java --- @@ -0,0 +1,129

[GitHub] drill pull request #436: DRILL-4514 : Add describe schema comm...

2016-07-12 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/436#discussion_r70433549 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/DescribeSchemaHandler.java --- @@ -0,0 +1,129

[GitHub] drill pull request #436: DRILL-4514 : Add describe schema comm...

2016-07-12 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/436#discussion_r70434670 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/sql/TestInfoSchema.java --- @@ -351,4 +359,51 @@ public void showFilesWithDefaultSchema

[GitHub] drill pull request #482: DRILL-4604: Generate warning on Web UI if drillbits...

2016-07-14 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/482#discussion_r70770934 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/Drillbit.java --- @@ -207,6 +210,21 @@ private void javaPropertiesToSystemOptions

[GitHub] drill pull request #551: DRILL-4792: Include session options used for a quer...

2016-07-21 Thread arina-ielchiieva
GitHub user arina-ielchiieva opened a pull request: https://github.com/apache/drill/pull/551 DRILL-4792: Include session options used for a query as part of the p… …rofile You can merge this pull request into a Git repository by running: $ git pull https://github.com/arina

[GitHub] drill pull request #436: DRILL-4514 : Add describe schema comm...

2016-07-12 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/436#discussion_r70434388 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/DescribeSchemaHandler.java --- @@ -0,0 +1,129

[GitHub] drill pull request #545: DRILL-4746: Verification Failures (Decimal values) ...

2016-07-18 Thread arina-ielchiieva
GitHub user arina-ielchiieva opened a pull request: https://github.com/apache/drill/pull/545 DRILL-4746: Verification Failures (Decimal values) in drill's regress… …ion tests You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] drill issue #491: DRILL-3474: Add implicit file columns support

2016-06-27 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/491 Changes merged into master with commit id 1ddd0ce7186afd164052d6aa8f63a75fd01148f4 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] drill pull request #491: DRILL-3474: Add implicit file columns support

2016-06-27 Thread arina-ielchiieva
Github user arina-ielchiieva closed the pull request at: https://github.com/apache/drill/pull/491 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] drill issue #436: DRILL-4514 : Add describe schema command

2016-07-11 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/436 @jinfengni, agree. Added schema in the output and updated PR comment with example. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] drill pull request #551: DRILL-4792: Include session options used for a quer...

2016-08-06 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/551#discussion_r73785925 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/QueryManager.java --- @@ -81,6 +85,7 @@ private final String

[GitHub] drill pull request #551: DRILL-4792: Include session options used for a quer...

2016-08-06 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/551#discussion_r73786030 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/QueryManager.java --- @@ -338,7 +345,8 @@ private QueryProfile

[GitHub] drill pull request #531: DRILL-4733: max(dir0) reading more columns than nec...

2016-08-07 Thread arina-ielchiieva
Github user arina-ielchiieva closed the pull request at: https://github.com/apache/drill/pull/531 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] drill pull request #560: DRILL-4823: Fix OOM while trying to prune partition...

2016-08-07 Thread arina-ielchiieva
GitHub user arina-ielchiieva opened a pull request: https://github.com/apache/drill/pull/560 DRILL-4823: Fix OOM while trying to prune partitions with reasonable … …data size You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] drill issue #560: DRILL-4823: Fix OOM while trying to prune partitions with ...

2016-08-07 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/560 @jinfengni , could you please review? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] drill pull request #551: DRILL-4792: Include session options used for a quer...

2016-07-22 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/551#discussion_r71869875 --- Diff: protocol/src/main/protobuf/UserBitShared.proto --- @@ -176,12 +176,18 @@ message QueryData { optional RecordBatchDef def = 3

[GitHub] drill pull request #551: DRILL-4792: Include session options used for a quer...

2016-07-22 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/551#discussion_r71869950 --- Diff: exec/java-exec/src/main/resources/rest/profile/profile.ftl --- @@ -107,6 +107,42 @@ FOREMAN: ${model.getProfile().getForeman

[GitHub] drill pull request #731: DRILL-5224: CTTAS: fix errors connected with system...

2017-02-03 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/731#discussion_r99391122 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserSession.java --- @@ -278,7 +277,7 @@ public boolean setSessionOption(String

[GitHub] drill pull request #736: DRILL-5238: CTTAS: unable to resolve temporary tabl...

2017-02-03 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/736#discussion_r99393786 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/SqlConverter.java --- @@ -527,5 +529,31 @@ public RelOptTableImpl getTable

[GitHub] drill issue #685: Drill 5043: Function that returns a unique id per session/...

2017-01-31 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/685 @nagarajanchinnasamy new changes look good, please squash commits into one. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] drill issue #685: Drill 5043: Function that returns a unique id per session/...

2017-02-01 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/685 @nagarajanchinnasamy thank you, looks good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] drill pull request #736: DRILL-5238: CTTAS: unable to resolve temporary tabl...

2017-02-02 Thread arina-ielchiieva
GitHub user arina-ielchiieva opened a pull request: https://github.com/apache/drill/pull/736 DRILL-5238: CTTAS: unable to resolve temporary table if workspace is … …indicated without schema 1. Added additional check for passed table is temporary if default workspace

[GitHub] drill pull request #743: DRILL-5243: Fix TestContextFunctions.sessionIdUDFWi...

2017-02-06 Thread arina-ielchiieva
GitHub user arina-ielchiieva opened a pull request: https://github.com/apache/drill/pull/743 DRILL-5243: Fix TestContextFunctions.sessionIdUDFWithinSameSession un… …it test You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] drill pull request #744: DRILL-5040: Parquet writer unable to delete table f...

2017-02-06 Thread arina-ielchiieva
GitHub user arina-ielchiieva opened a pull request: https://github.com/apache/drill/pull/744 DRILL-5040: Parquet writer unable to delete table folder on abort Folder directory clean up failed because couldn't delete the directory: `java.io.IOException: Directory /tmp/446062ea

[GitHub] drill issue #685: Drill 5043: Function that returns a unique id per session/...

2017-02-06 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/685 Changes have been merged into master. @nagarajanchinnasamy, please close pull request. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] drill pull request #736: DRILL-5238: CTTAS: unable to resolve temporary tabl...

2017-02-02 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/736#discussion_r99167324 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/SqlConverter.java --- @@ -527,5 +529,31 @@ public RelOptTableImpl getTable

[GitHub] drill pull request #736: DRILL-5238: CTTAS: unable to resolve temporary tabl...

2017-02-02 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/736#discussion_r99163906 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/SqlConverter.java --- @@ -527,5 +529,31 @@ public RelOptTableImpl getTable

[GitHub] drill pull request #736: DRILL-5238: CTTAS: unable to resolve temporary tabl...

2017-02-02 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/736#discussion_r99166435 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/SqlConverter.java --- @@ -527,5 +529,31 @@ public RelOptTableImpl getTable

[GitHub] drill issue #701: DRILL-4963: Fix issues with dynamically loaded overloaded ...

2017-01-23 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/701 @paul-rogers as we discussed to have tried to find the way to preserve lazy-init approach. I have renamed PR to reflect latest changes. Please find new solution and description

[GitHub] drill issue #685: Drill 5043: Function that returns a unique id per session/...

2017-01-24 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/685 @nagarajanchinnasamy after this weeks commits, there is one conflicting file. Could you please rebase on master and resolve conflict? --- If your project is set up for it, you can reply

[GitHub] drill pull request #685: Drill 5043: Function that returns a unique id per s...

2017-01-30 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/685#discussion_r98414144 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/ContextFunctions.java --- @@ -64,17 +65,45 @@ public void eval

[GitHub] drill pull request #685: Drill 5043: Function that returns a unique id per s...

2017-01-27 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/685#discussion_r98186438 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/ContextFunctions.java --- @@ -64,17 +65,45 @@ public void eval

[GitHub] drill pull request #731: DRILL-5224: CTTAS: fix errors connected with system...

2017-01-27 Thread arina-ielchiieva
GitHub user arina-ielchiieva opened a pull request: https://github.com/apache/drill/pull/731 DRILL-5224: CTTAS: fix errors connected with system path delimiters (… …Windows) Replaced `java.nio.file.Paths.get()` to `org.apache.hadoop.fs.Path` as the latest works

[GitHub] drill pull request #701: DRILL-4963: Fix issues with dynamically loaded over...

2017-02-24 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/701#discussion_r102921207 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/FunctionImplementationRegistry.java --- @@ -140,27 +142,39 @@ public void

[GitHub] drill pull request #701: DRILL-4963: Fix issues with dynamically loaded over...

2017-02-24 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/701#discussion_r102920945 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlWorker.java --- @@ -50,13 +47,56 @@ private DrillSqlWorker

[GitHub] drill pull request #701: DRILL-4963: Fix issues with dynamically loaded over...

2017-02-24 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/701#discussion_r102919942 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/FunctionImplementationRegistry.java --- @@ -260,76 +293,101 @@ public

[GitHub] drill pull request #701: DRILL-4963: Fix issues with dynamically loaded over...

2017-02-24 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/701#discussion_r102920190 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/FunctionImplementationRegistry.java --- @@ -260,76 +293,101 @@ public

[GitHub] drill pull request #701: DRILL-4963: Fix issues with dynamically loaded over...

2017-02-24 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/701#discussion_r102921712 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/FunctionImplementationRegistry.java --- @@ -260,76 +293,101 @@ public

[GitHub] drill issue #701: DRILL-4963: Fix issues with dynamically loaded overloaded ...

2017-02-24 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/701 @paul-rogers addressed review comments. As agreed concerns about concurrency and performance will be addressed once MVCC will be implemented. --- If your project is set up for it, you can

[GitHub] drill pull request #759: DRILL-5255: Remove default temporary workspace chec...

2017-02-24 Thread arina-ielchiieva
GitHub user arina-ielchiieva opened a pull request: https://github.com/apache/drill/pull/759 DRILL-5255: Remove default temporary workspace check at drillbit star… …t up Check if default temporary workspace is valid (exists, file-based and writable) will be performed

  1   2   3   4   5   6   7   8   9   10   >