Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/656#discussion_r98070065
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetReaderUtility.java
---
@@ -323,18 +323,28 @@ public static
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/578#discussion_r98512248
--- Diff: contrib/native/client/src/clientlib/saslAuthenticatorImpl.cpp ---
@@ -0,0 +1,207 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/578#discussion_r100938180
--- Diff: contrib/native/client/src/clientlib/drillClientImpl.hpp ---
@@ -362,6 +363,7 @@ class DrillClientImpl : public DrillClientImplBase
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/600#discussion_r82314071
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetReaderUtility.java
---
@@ -45,4 +53,34 @@ public static int
Github user bitblender commented on the issue:
https://github.com/apache/drill/pull/634
@amansinha100 Can you please review this change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/600#discussion_r83761501
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetReaderUtility.java
---
@@ -45,4 +53,34 @@ public static int
GitHub user bitblender opened a pull request:
https://github.com/apache/drill/pull/634
DRILL-4974: NPE in FindPartitionConditions.analyzeCall() for 'holistic'
expressions
Changes: Added a missing null check in
FindPartitionConditions.analyzeCall(), to ensure that opStack.peek
GitHub user bitblender opened a pull request:
https://github.com/apache/drill/pull/690
DRILL-5121 A memory leak is observed when exact case is not specified for a
column in a filter condition
Fix for https://issues.apache.org/jira/browse/DRILL-5121.
Changes fieldVectorMap
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/638#discussion_r90574793
--- Diff:
contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveAbstractReader.java
---
@@ -218,17 +229,18 @@ private void init
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/697#discussion_r94350780
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/NullableFixedByteAlignedReaders.java
---
@@ -110,9 +110,14
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/697#discussion_r94350967
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/NullableFixedByteAlignedReaders.java
---
@@ -132,6 +137,9
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/695#discussion_r93133495
--- Diff:
contrib/storage-hive/core/src/main/codegen/templates/ObjectInspectorHelper.java
---
@@ -172,48 +172,35 @@ public static JBlock getDrillObject
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/783#discussion_r111289506
--- Diff: exec/vector/src/main/codegen/templates/ColumnAccessors.java ---
@@ -0,0 +1,333 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
GitHub user bitblender opened a pull request:
https://github.com/apache/drill/pull/875
DRILL-5671 Set secure ACLs (Access Control List) for Drill ZK nodes in a
secure cluster
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/875#discussion_r127367344
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/coord/zk/ZKSecureACLProvider.java
---
@@ -0,0 +1,71 @@
+/**
+ * Licensed
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/875#discussion_r127367354
--- Diff: exec/java-exec/src/main/resources/drill-module.conf ---
@@ -112,7 +112,8 @@ drill.exec: {
retry: {
count: 7200
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/875#discussion_r127540793
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/coord/zk/ZKACLProviderFactory.java
---
@@ -0,0 +1,44 @@
+/**
+ * Licensed
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/875#discussion_r127540711
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java ---
@@ -39,6 +39,7 @@
String ZK_TIMEOUT = "drill.exec.zk.ti
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/866#discussion_r131459203
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/rowSet/impl/ResultSetLoaderImpl.java
---
@@ -0,0 +1,412 @@
+/*
+ * Licensed
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/866#discussion_r131684173
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/rowSet/impl/TupleSetImpl.java
---
@@ -0,0 +1,551 @@
+/*
+ * Licensed
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/866#discussion_r131685349
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/rowSet/impl/TupleSetImpl.java
---
@@ -0,0 +1,551 @@
+/*
+ * Licensed
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/866#discussion_r131554894
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/rowSet/impl/ResultSetLoaderImpl.java
---
@@ -0,0 +1,412 @@
+/*
+ * Licensed
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/866#discussion_r131216670
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/rowSet/impl/ColumnLoaderImpl.java
---
@@ -0,0 +1,31 @@
+/*
+ * Licensed
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/866#discussion_r130429208
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/rowSet/TupleSchema.java
---
@@ -0,0 +1,91 @@
+/*
+ * Licensed to the Apache
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/866#discussion_r131564509
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/rowSet/impl/ResultVectorCache.java
---
@@ -0,0 +1,181 @@
+/*
+ * Licensed
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/866#discussion_r131284158
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/rowSet/impl/LogicalTupleLoader.java
---
@@ -0,0 +1,204 @@
+/*
+ * Licensed
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/866#discussion_r130250994
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/rowSet/ResultSetLoader.java
---
@@ -0,0 +1,170 @@
+/*
+ * Licensed
Github user bitblender commented on the issue:
https://github.com/apache/drill/pull/875
Yes. There will be a commit addressing the issues raised here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/894#discussion_r134553446
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/rpc/user/security/TestUserBitKerberos.java
---
@@ -137,6 +142,41 @@ public Void run() throws
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/840#discussion_r122526465
--- Diff: exec/vector/src/main/codegen/templates/FixedValueVectors.java ---
@@ -806,10 +998,32 @@ public void generateTestDataAlt(int size
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/840#discussion_r118806486
--- Diff:
exec/memory/base/src/main/java/io/netty/buffer/UnsafeDirectLittleEndian.java ---
@@ -174,6 +175,40 @@ public ByteBuf setDouble(int index, double
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/840#discussion_r122533121
--- Diff: exec/vector/src/main/codegen/templates/VariableLengthVectors.java
---
@@ -548,6 +567,23 @@ public void setSafe(int index, ByteBuffer bytes, int
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/840#discussion_r122541355
--- Diff:
exec/memory/base/src/main/java/io/netty/buffer/UnsafeDirectLittleEndian.java ---
@@ -174,6 +175,40 @@ public ByteBuf setDouble(int index, double
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/809#discussion_r117412175
--- Diff: contrib/native/client/src/clientlib/drillClientImpl.cpp ---
@@ -234,6 +233,37 @@ void DrillClientImpl::Close
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/809#discussion_r117412544
--- Diff: contrib/native/client/src/clientlib/drillClientImpl.cpp ---
@@ -364,7 +395,41 @@ connectionStatus_t DrillClientImpl::recvHandshake
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/837#discussion_r122287096
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/record/TestVectorContainer.java
---
@@ -110,13 +110,16 @@ public void testContainerMerge
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/837#discussion_r122287615
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/record/BatchSchema.java ---
@@ -162,20 +162,22 @@ private boolean majorTypeEqual(MajorType t1
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/809#discussion_r114442641
--- Diff: contrib/native/client/src/clientlib/drillClientImpl.cpp ---
@@ -245,6 +264,64 @@ connectionStatus_t
DrillClientImpl::sendSync(rpc
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/809#discussion_r115369295
--- Diff: contrib/native/client/src/clientlib/drillClientImpl.cpp ---
@@ -854,75 +990,328 @@ void DrillClientImpl::waitForResults
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/809#discussion_r114442866
--- Diff: contrib/native/client/src/clientlib/drillClientImpl.cpp ---
@@ -245,6 +264,64 @@ connectionStatus_t
DrillClientImpl::sendSync(rpc
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/809#discussion_r114442367
--- Diff: contrib/native/client/src/clientlib/drillClientImpl.cpp ---
@@ -245,6 +264,64 @@ connectionStatus_t
DrillClientImpl::sendSync(rpc
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/809#discussion_r115370795
--- Diff: contrib/native/client/src/clientlib/drillClientImpl.cpp ---
@@ -854,75 +990,328 @@ void DrillClientImpl::waitForResults
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/809#discussion_r114623038
--- Diff: contrib/native/client/src/clientlib/drillClientImpl.cpp ---
@@ -854,75 +990,328 @@ void DrillClientImpl::waitForResults
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/809#discussion_r114629588
--- Diff: contrib/native/client/src/clientlib/utils.cpp ---
@@ -111,4 +111,52 @@ AllocatedBuffer::~AllocatedBuffer(){
m_bufSize = 0
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/809#discussion_r115371638
--- Diff: contrib/native/client/src/clientlib/drillClientImpl.cpp ---
@@ -854,75 +990,328 @@ void DrillClientImpl::waitForResults
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/809#discussion_r114828848
--- Diff: contrib/native/client/src/clientlib/drillClientImpl.cpp ---
@@ -854,75 +990,328 @@ void DrillClientImpl::waitForResults
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/809#discussion_r115372156
--- Diff: contrib/native/client/src/clientlib/drillClientImpl.cpp ---
@@ -854,75 +990,328 @@ void DrillClientImpl::waitForResults
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/809#discussion_r11272
--- Diff: contrib/native/client/src/clientlib/drillClientImpl.cpp ---
@@ -245,6 +264,64 @@ connectionStatus_t
DrillClientImpl::sendSync(rpc
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/809#discussion_r114775522
--- Diff: contrib/native/client/src/clientlib/drillClientImpl.cpp ---
@@ -370,6 +453,33 @@ void DrillClientImpl::handleHShakeReadTimeout(const
boost
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/809#discussion_r115369469
--- Diff: contrib/native/client/src/clientlib/drillClientImpl.cpp ---
@@ -854,75 +990,328 @@ void DrillClientImpl::waitForResults
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/809#discussion_r114828323
--- Diff: contrib/native/client/src/clientlib/drillClientImpl.cpp ---
@@ -854,75 +990,328 @@ void DrillClientImpl::waitForResults
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/809#discussion_r114818140
--- Diff: contrib/native/client/src/clientlib/drillClientImpl.cpp ---
@@ -854,75 +990,328 @@ void DrillClientImpl::waitForResults
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/837#discussion_r120198724
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/record/BatchSchema.java ---
@@ -157,4 +158,26 @@ private boolean majorTypeEqual(MajorType t1
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/837#discussion_r118797793
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/record/BatchSchema.java ---
@@ -157,4 +158,26 @@ private boolean majorTypeEqual(MajorType t1
GitHub user bitblender opened a pull request:
https://github.com/apache/drill/pull/983
MD-2769: DRILL-5819: Default value of security.admin.user_groups and
security.admin.users is true
The values for admin user/groups in the config file was incorrectly set to
"
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/914#discussion_r137851895
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/rowSet/impl/package-info.java
---
@@ -0,0 +1,295 @@
+/*
+ * Licensed
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/914#discussion_r137852118
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/rowSet/impl/package-info.java
---
@@ -0,0 +1,295 @@
+/*
+ * Licensed
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/983#discussion_r144143097
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/server/TestOptionsAuthEnabled.java
---
@@ -115,4 +124,59 @@ private void setOptHelper
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/983#discussion_r144143072
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/DrillRoot.java
---
@@ -75,6 +80,29 @@ public ClusterInfo getClusterInfoJSON
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/983#discussion_r144143087
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/server/TestOptionsAuthEnabled.java
---
@@ -115,4 +124,59 @@ private void setOptHelper
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/983#discussion_r144143103
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/server/TestOptionsAuthEnabled.java
---
@@ -115,4 +124,59 @@ private void setOptHelper
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/983#discussion_r144143113
--- Diff:
common/src/main/java/org/apache/drill/common/util/DrillStringUtils.java ---
@@ -1,203 +1,258 @@
-/**
- * Licensed to the Apache Software
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/983#discussion_r144143076
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/server/TestOptionsAuthEnabled.java
---
@@ -115,4 +124,59 @@ private void setOptHelper
GitHub user bitblender opened a pull request:
https://github.com/apache/drill/pull/997
DRILL-5582: C++ Client: [Threat Modeling] Drillbit may be spoofed by â¦
â¦an attacker and this may lead to data being written to the attacker's
target instead of Drillbit
You can merge
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/997#discussion_r145567205
--- Diff: contrib/native/client/src/clientlib/drillClientImpl.cpp ---
@@ -595,6 +611,12 @@ connectionStatus_t
DrillClientImpl::validateHandshake
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/997#discussion_r145568130
--- Diff: contrib/native/client/src/clientlib/drillClientImpl.cpp ---
@@ -595,6 +611,12 @@ connectionStatus_t
DrillClientImpl::validateHandshake
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r151003788
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/DrillbitContext.java
---
@@ -157,10 +157,29 @@ public DrillConfig getConfig
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/914#discussion_r140644571
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/rowSet/impl/TupleState.java
---
@@ -0,0 +1,353 @@
+/*
+ * Licensed
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/914#discussion_r151762286
--- Diff: exec/memory/base/src/main/java/io/netty/buffer/DrillBuf.java ---
@@ -882,4 +882,71 @@ public void print(StringBuilder sb, int indent,
Verbosity
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/914#discussion_r151762298
--- Diff: exec/vector/src/main/codegen/templates/ColumnAccessors.java ---
@@ -275,17 +273,17 @@ public boolean isNull() {
final int offset
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r148868884
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/work/WorkManager.java ---
@@ -165,32 +176,60 @@ public DrillbitContext getContext
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r148871345
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java ---
@@ -251,6 +252,11 @@ public void run() {
final String
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r148674083
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/coord/ClusterCoordinator.java
---
@@ -60,7 +61,26 @@
*/
public abstract
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r148874640
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/TestGracefulShutdown.java ---
@@ -0,0 +1,323 @@
+/*
+ * Licensed to the Apache
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r148668138
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/coord/zk/ZKClusterCoordinator.java
---
@@ -229,27 +272,52 @@ public DrillbitEndpoint
apply
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r148682167
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/coord/zk/ZKClusterCoordinator.java
---
@@ -229,27 +272,52 @@ public DrillbitEndpoint
apply
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r148872633
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/ClusterFixture.java ---
@@ -471,6 +471,22 @@ public void close() throws Exception
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r148861255
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/DrillbitStateManager.java
---
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r148171637
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/coord/local/LocalClusterCoordinator.java
---
@@ -85,13 +88,62 @@ public void unregister
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r148676672
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/coord/zk/ZKClusterCoordinator.java
---
@@ -200,11 +206,47 @@ public void unregister
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r148173100
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/coord/zk/ZKClusterCoordinator.java
---
@@ -70,7 +72,10 @@
private final
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r148682043
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/coord/zk/ZKClusterCoordinator.java
---
@@ -229,27 +272,52 @@ public DrillbitEndpoint
apply
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r148686859
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/Drillbit.java ---
@@ -69,14 +73,30 @@
public final static String
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r148685835
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/coord/zk/ZKClusterCoordinator.java
---
@@ -229,27 +272,52 @@ public DrillbitEndpoint
apply
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r148669660
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/coord/zk/ZKClusterCoordinator.java
---
@@ -229,27 +272,52 @@ public DrillbitEndpoint
apply
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r148872536
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/ClusterFixture.java ---
@@ -471,6 +471,22 @@ public void close() throws Exception
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r148684246
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/coord/zk/ZKClusterCoordinator.java
---
@@ -70,7 +72,10 @@
private final
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r148872381
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java ---
@@ -348,6 +354,21 @@ public void run
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r149544267
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/TestGracefulShutdown.java ---
@@ -0,0 +1,323 @@
+/*
+ * Licensed to the Apache
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r149542196
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java ---
@@ -348,6 +354,21 @@ public void run
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r149541807
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/DrillbitStateManager.java
---
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r150047464
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java ---
@@ -348,6 +354,21 @@ public void run
GitHub user bitblender opened a pull request:
https://github.com/apache/drill/pull/1064
Fix for SHUTDOWN button being visible for non Admin users
This fix repurposes an earlier change I had made to show admin user info,
to selectively enable the SHUTDOWN button.
You can merge
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/1064#discussion_r155606076
--- Diff: exec/java-exec/src/main/resources/rest/index.ftl ---
@@ -112,7 +114,7 @@
- <#if model.shouldShowUserI
94 matches
Mail list logo
