[GitHub] drill pull request: Bumps FMPP version to 0.9.15

2016-01-18 Thread laurentgo
GitHub user laurentgo opened a pull request: https://github.com/apache/drill/pull/330 Bumps FMPP version to 0.9.15 FMPP 0.9.14 pom.xml specifies a version range for FreeMarker dependency, which should be okay except that latest SNAPSHOT version doesn't resolve anymore

[GitHub] drill pull request: DRILL-4359: Adds equals/hashCode methods to En...

2016-02-05 Thread laurentgo
GitHub user laurentgo opened a pull request: https://github.com/apache/drill/pull/363 DRILL-4359: Adds equals/hashCode methods to EndpointAffinity Adds equals/hashCode methods to EndpointAffinity to allow for comparison in tests. You can merge this pull request into a Git

[GitHub] drill pull request: DRILL-4327: Fix rawtypes warnings emitted by c...

2016-02-05 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/347#discussion_r52051852 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/mergereceiver/MergingRecordBatch.java --- @@ -84,6 +64,26 @@ import

[GitHub] drill pull request: DRILL-4327: Fix rawtypes warnings emitted by c...

2016-02-05 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/347#discussion_r52051723 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/partitionsender/PartitionerDecorator.java --- @@ -26,13 +26,13 @@ import

[GitHub] drill pull request: DRILL-4361: Let FileSystemPlugin FormatCreator...

2016-02-05 Thread laurentgo
GitHub user laurentgo opened a pull request: https://github.com/apache/drill/pull/365 DRILL-4361: Let FileSystemPlugin FormatCreator class be overridable Allow for FileSystemPlugin subclasses to customize FormatPlugin by injecting their own version of FormatCreator. You can merge

[GitHub] drill pull request: DRILL-4359: Adds equals/hashCode methods to En...

2016-02-05 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/363#discussion_r52083113 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/EndpointAffinity.java --- @@ -96,6 +96,42 @@ public boolean isAssignmentRequired

[GitHub] drill pull request: Fix rawtypes warnings emitted by compiler

2016-01-29 Thread laurentgo
Github user laurentgo closed the pull request at: https://github.com/apache/drill/pull/347 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] drill pull request: Fix rawtypes warnings emitted by compiler

2016-01-29 Thread laurentgo
GitHub user laurentgo opened a pull request: https://github.com/apache/drill/pull/347 Fix rawtypes warnings emitted by compiler Drill code base references lots of rawtypes, which generates lots of warning from the compiler. As Drill is now compiled with Java 1.7, most

[GitHub] drill pull request: DRILL-4327: Fix rawtypes warnings emitted by c...

2016-01-29 Thread laurentgo
GitHub user laurentgo reopened a pull request: https://github.com/apache/drill/pull/347 DRILL-4327: Fix rawtypes warnings emitted by compiler Drill code base references lots of rawtypes, which generates lots of warning from the compiler. As Drill is now compiled with Java

[GitHub] drill pull request: Fix TestFlattenPlanning.testFlattenPlanningAvo...

2016-02-01 Thread laurentgo
GitHub user laurentgo opened a pull request: https://github.com/apache/drill/pull/351 Fix TestFlattenPlanning.testFlattenPlanningAvoidUnnecessaryProject for Java8 Test TestFlattenPlanning.testFlattenPlanningAvoidUnnecessaryProject fails with Java8 because of Map order

[GitHub] drill pull request: DRILL-4332: Makes vector comparison order stab...

2016-02-23 Thread laurentgo
GitHub user laurentgo opened a pull request: https://github.com/apache/drill/pull/389 DRILL-4332: Makes vector comparison order stable in test framework In the test framework, a vector is a map of <String, Object>. When comparing actual values with baseline, the comp

[GitHub] drill pull request: DRILL-4452: Uses Apache Calcite Avatica driver...

2016-02-26 Thread laurentgo
GitHub user laurentgo opened a pull request: https://github.com/apache/drill/pull/395 DRILL-4452: Uses Apache Calcite Avatica driver vs Optiq driver for Drill JDBC Drill JDBC driver uses Optiq Avatica as its basis, but this dependency has been moved over to Calcite, for quite

[GitHub] drill pull request: DRILL-4295: Removes obsolete protobuf-generate...

2016-01-21 Thread laurentgo
GitHub user laurentgo opened a pull request: https://github.com/apache/drill/pull/333 DRILL-4295: Removes obsolete protobuf-generated files These files are obsolete protobuf-generated files, whose definition has been removed. You can merge this pull request into a Git repository

[GitHub] drill pull request: DRILL-4295: Removes obsolete protobuf-generate...

2016-01-21 Thread laurentgo
Github user laurentgo commented on the pull request: https://github.com/apache/drill/pull/333#issuecomment-173681422 I can check on how to delete first, but maybe you can share why these files are persisted in the first place under git, versus being generated everytime: is it because

[GitHub] drill pull request: DRILL-4295: Removes obsolete protobuf-generate...

2016-01-21 Thread laurentgo
Github user laurentgo commented on the pull request: https://github.com/apache/drill/pull/333#issuecomment-173687545 If changing protobuf version to 2.6.1 is an option, maven central now has protoc version for each architecture, that the protobuf maven plugin can take advantage

[GitHub] drill pull request: DRILL-4295: Removes obsolete protobuf-generate...

2016-01-21 Thread laurentgo
Github user laurentgo commented on the pull request: https://github.com/apache/drill/pull/333#issuecomment-173742695 I was expecting this, so I added the clean before generate source code --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] drill pull request: DRILL-4390: Uses Resource where Drill favicon ...

2016-02-16 Thread laurentgo
GitHub user laurentgo opened a pull request: https://github.com/apache/drill/pull/378 DRILL-4390: Uses Resource where Drill favicon is located for static assets Drill Webserver uses the first jar containing a rest/static directory to find its static assets. In case of another

[GitHub] drill pull request: DRILL-4467: Fix ProjectPushInfo#desiredFields ...

2016-03-28 Thread laurentgo
Github user laurentgo closed the pull request at: https://github.com/apache/drill/pull/404 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] drill pull request: DRILL-4546: Only generate one zip archive when...

2016-03-28 Thread laurentgo
GitHub user laurentgo opened a pull request: https://github.com/apache/drill/pull/449 DRILL-4546: Only generate one zip archive when using apache-release profile Drill root pom doesn't override completely Apache parent pom configuration regarding assemblies, which caused a zip

[GitHub] drill pull request: DRILL-4576: Add PlannerCallback interface for ...

2016-04-06 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/466#discussion_r58751431 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/PlannerCallback.java --- @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache

[GitHub] drill pull request: DRILL-4576: Add PlannerCallback interface for ...

2016-04-06 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/466#discussion_r58754467 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/PlannerCallback.java --- @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache

[GitHub] drill pull request: DRILL-4576: Add PlannerCallback interface for ...

2016-04-06 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/466#discussion_r58749026 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/PlannerCallback.java --- @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache

[GitHub] drill pull request: DRILL-4576: Add PlannerCallback interface for ...

2016-04-06 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/466#discussion_r58749059 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/PlannerCallback.java --- @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache

[GitHub] drill pull request: DRILL-4576: Add PlannerCallback interface for ...

2016-04-06 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/466#discussion_r58753568 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/PlannerCallback.java --- @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache

[GitHub] drill pull request: DRILL-4576: Add PlannerCallback interface for ...

2016-04-06 Thread laurentgo
Github user laurentgo commented on the pull request: https://github.com/apache/drill/pull/466#issuecomment-206487918 Patch overall looks good to me (except maybe the abstract class vs interface stuff) --- If your project is set up for it, you can reply to this email and have your

[GitHub] drill pull request: DRILL-4237 DRILL-4478 fully implement hash to ...

2016-04-07 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/430#discussion_r58967081 --- Diff: common/src/main/java/org/apache/drill/common/util/DrillStringUtils.java --- @@ -163,10 +163,10 @@ private static void appendByte(StringBuilder

[GitHub] drill pull request: DRILL-4237 DRILL-4478 fully implement hash to ...

2016-04-07 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/430#discussion_r58967457 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/DrillHash.java --- @@ -0,0 +1,50 @@ +/** + * Licensed to the Apache

[GitHub] drill pull request: DRILL-4237 DRILL-4478 fully implement hash to ...

2016-04-07 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/430#discussion_r58968289 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/XXHash.java --- @@ -24,14 +24,15 @@ import

[GitHub] drill pull request: DRILL-4237 DRILL-4478 fully implement hash to ...

2016-04-07 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/430#discussion_r58968083 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestHashBase.java --- @@ -0,0 +1,72 @@ +/** + * Licensed to the Apache Software

[GitHub] drill pull request: DRILL-4237 DRILL-4478 fully implement hash to ...

2016-04-07 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/430#discussion_r58969685 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/MurmurHash3.java --- @@ -0,0 +1,280 @@ +/** + * Licensed to the Apache

[GitHub] drill pull request: DRILL-4546: Only generate one zip archive when...

2016-04-11 Thread laurentgo
Github user laurentgo commented on the pull request: https://github.com/apache/drill/pull/449#issuecomment-208578452 The only changes to the resulting src bundles are the changes to pom.xml file, the missing assembly file which has been removed by the patch and changes

[GitHub] drill pull request: DRILL-4334: Fix ProjectPushInfo#desiredFields ...

2016-03-02 Thread laurentgo
Github user laurentgo commented on the pull request: https://github.com/apache/drill/pull/404#issuecomment-191535895 travis build is expecting to fail because this patch uncovers another issue: [DRILL-4468](https://issues.apache.org/jira/browse/DRILL-4468) --- If your project is set

[GitHub] drill pull request: DRILL-4446: Support mandatory work assignment ...

2016-03-02 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/403#discussion_r54829311 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/fragment/HardAffinityFragmentParallelizer.java --- @@ -0,0 +1,119

[GitHub] drill pull request: DRILL-4334: Fix ProjectPushInfo#desiredFields ...

2016-03-02 Thread laurentgo
GitHub user laurentgo opened a pull request: https://github.com/apache/drill/pull/404 DRILL-4334: Fix ProjectPushInfo#desiredFields order when using PrelUtil#getColumns Order of ProjectPushInfo#desiredFields elements is not the same as the list of RexNode elements

[GitHub] drill pull request: DRILL-4446: Support mandatory work assignment ...

2016-03-02 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/403#discussion_r54828997 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/fragment/DistributionAffinity.java --- @@ -0,0 +1,61 @@ +/** + * Licensed

[GitHub] drill pull request: DRILL-4446: Support mandatory work assignment ...

2016-03-02 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/403#discussion_r54829180 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/fragment/HardAffinityFragmentParallelizer.java --- @@ -0,0 +1,119

[GitHub] drill pull request: DRILL-4446: Support mandatory work assignment ...

2016-03-02 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/403#discussion_r54829096 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/fragment/DistributionAffinity.java --- @@ -0,0 +1,61 @@ +/** + * Licensed

[GitHub] drill pull request: DRILL-4446: Support mandatory work assignment ...

2016-03-02 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/403#discussion_r54829083 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/fragment/DistributionAffinity.java --- @@ -0,0 +1,61 @@ +/** + * Licensed

[GitHub] drill pull request: DRILL-4446: Support mandatory work assignment ...

2016-03-02 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/403#discussion_r54829518 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/fragment/Stats.java --- @@ -43,6 +43,12 @@ public void addMinWidth(int minWidth

[GitHub] drill pull request: DRILL-4576: Add PlannerCallback interface for ...

2016-04-13 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/466#discussion_r59572951 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/PlannerCallback.java --- @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache

[GitHub] drill pull request: DRILL-4576: Add PlannerCallback interface for ...

2016-04-18 Thread laurentgo
GitHub user laurentgo opened a pull request: https://github.com/apache/drill/pull/484 DRILL-4576: Add PlannerCallback interface for additional planner initialization. - Allow a storage plugin to be able to provide additional planner initialization. - Fix issue

[GitHub] drill pull request: DRILL-4576: Add PlannerCallback interface for ...

2016-04-18 Thread laurentgo
Github user laurentgo commented on the pull request: https://github.com/apache/drill/pull/484#issuecomment-211524860 Reworked version of @jacques-n PR #466 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] drill pull request: DRILL-4690: CORS in REST API

2016-05-24 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/507#discussion_r64472615 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/CrossOriginFilter.java --- @@ -0,0 +1,56 @@ +/** + * Licensed

[GitHub] drill pull request: DRILL-4690: CORS in REST API

2016-05-24 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/507#discussion_r64475479 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/CrossOriginFilter.java --- @@ -0,0 +1,56 @@ +/** + * Licensed

[GitHub] drill pull request: DRILL-4690: CORS in REST API

2016-05-25 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/507#discussion_r64602614 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/WebServer.java --- @@ -159,6 +163,14 @@ public void start() throws Exception

[GitHub] drill pull request #520: DRILL-3510: Add ANSI_QUOTES option so that Drill's ...

2017-02-06 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/520#discussion_r99749138 --- Diff: exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillDatabaseMetaDataImpl.java --- @@ -231,11 +274,16 @@ public boolean

[GitHub] drill pull request #520: DRILL-3510: Add ANSI_QUOTES option so that Drill's ...

2017-02-06 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/520#discussion_r99747009 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java --- @@ -695,6 +698,33 @@ public void runQuery(QueryType type, List

[GitHub] drill pull request #520: DRILL-3510: Add ANSI_QUOTES option so that Drill's ...

2017-02-06 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/520#discussion_r99749402 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserSession.java --- @@ -59,9 +62,11 @@ public static final String USER = "

[GitHub] drill pull request #520: DRILL-3510: Add ANSI_QUOTES option so that Drill's ...

2017-02-06 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/520#discussion_r99747062 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/options/TypeValidators.java --- @@ -204,10 +204,11 @@ public void validate(final

[GitHub] drill issue #613: DRILL-4730: Update JDBC DatabaseMetaData implementation to...

2017-02-06 Thread laurentgo
Github user laurentgo commented on the issue: https://github.com/apache/drill/pull/613 @sudheeshkatkam can you please give it another review? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

2017-02-07 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r99874906 --- Diff: contrib/native/client/src/clientlib/drillClientImpl.cpp --- @@ -407,37 +422,155 @@ connectionStatus_t DrillClientImpl::validateHandshake

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

2017-02-07 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r99873776 --- Diff: contrib/native/client/src/clientlib/drillClientImpl.cpp --- @@ -407,37 +422,155 @@ connectionStatus_t DrillClientImpl::validateHandshake

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

2017-02-07 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r99884385 --- Diff: contrib/native/client/src/clientlib/saslAuthenticatorImpl.cpp --- @@ -0,0 +1,210 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

2017-02-07 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r99887378 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/control/ControlClient.java --- @@ -89,14 +90,48 @@ public MessageLite

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

2017-02-07 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r99890259 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/data/BitConnectionConfigImpl.java --- @@ -0,0 +1,118 @@ +/** + * Licensed

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

2017-02-07 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r99881850 --- Diff: contrib/native/client/src/clientlib/saslAuthenticatorImpl.cpp --- @@ -0,0 +1,210 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

2017-02-07 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r99879420 --- Diff: contrib/native/client/src/clientlib/saslAuthenticatorImpl.cpp --- @@ -0,0 +1,210 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

2017-02-07 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r99871911 --- Diff: protocol/src/main/protobuf/User.proto --- @@ -72,6 +79,7 @@ message UserToBitHandshake { optional bool support_complex_types = 6 [default

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

2017-02-07 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r99886887 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/control/ConnectionManagerRegistry.java --- @@ -32,24 +29,19 @@ private final

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

2017-02-07 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r99888092 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/control/ControlClient.java --- @@ -89,14 +90,48 @@ public MessageLite

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

2017-02-07 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r99871395 --- Diff: protocol/src/main/protobuf/User.proto --- @@ -111,6 +115,21 @@ message BitToUserHandshake { optional string errorId = 4; optional

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

2017-02-07 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r99885146 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java --- @@ -568,19 +565,13 @@ public void runQuery(QueryType type, List

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

2017-02-07 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r99880759 --- Diff: contrib/native/client/src/clientlib/saslAuthenticatorImpl.cpp --- @@ -0,0 +1,210 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

2017-02-07 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r99875648 --- Diff: contrib/native/client/src/clientlib/drillClientImpl.cpp --- @@ -407,37 +422,155 @@ connectionStatus_t DrillClientImpl::validateHandshake

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

2017-02-07 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r99869783 --- Diff: common/src/main/java/org/apache/drill/common/map/CaseInsensitiveMap.java --- @@ -55,6 +55,18 @@ } /** + * Returns a new

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

2017-02-07 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r99871673 --- Diff: protocol/src/main/protobuf/User.proto --- @@ -63,6 +65,11 @@ message RpcEndpointInfos { optional string application = 6;// example

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

2017-02-07 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r99874669 --- Diff: contrib/native/client/src/clientlib/drillClientImpl.cpp --- @@ -407,37 +422,155 @@ connectionStatus_t DrillClientImpl::validateHandshake

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

2017-02-07 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r99889252 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/control/ControlServer.java --- @@ -84,23 +87,33 @@ public ControlConnection

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

2017-02-07 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r99890434 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/data/DataClient.java --- @@ -75,27 +85,106 @@ public MessageLite getResponseDefaultInstance

[GitHub] drill pull request #733: DRILL-5221: Send cancel message as soon as possible...

2017-01-30 Thread laurentgo
GitHub user laurentgo opened a pull request: https://github.com/apache/drill/pull/733 DRILL-5221: Send cancel message as soon as possible in C++ connector In C++ connector, try to send cancel request to the server as soon as possible, which means when receiving the queryId

[GitHub] drill pull request #726: DRILL-5218: Support disabling hearbeats from C++ cl...

2017-01-24 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/726#discussion_r97665284 --- Diff: contrib/native/client/src/clientlib/drillClientImpl.cpp --- @@ -179,9 +179,11 @@ connectionStatus_t DrillClientImpl::sendHeartbeat

[GitHub] drill pull request #726: DRILL-5218: Support disabling hearbeats from C++ cl...

2017-01-24 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/726#discussion_r97663988 --- Diff: contrib/native/client/src/clientlib/drillClientImpl.cpp --- @@ -1400,22 +1404,6 @@ void DrillClientImpl::handleRead(ByteBuf_t _buf

[GitHub] drill pull request #727: DRILL-5119: Relax user properties validation in C++...

2017-01-25 Thread laurentgo
GitHub user laurentgo opened a pull request: https://github.com/apache/drill/pull/727 DRILL-5119: Relax user properties validation in C++ client Unlike Java client, C++ client only allows user properties present in a whitelist. Relax this restriction so that user can add extra

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

2017-02-21 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r102346707 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserClient.java --- @@ -88,22 +129,183 @@ public void submitQuery(UserResultsListener

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

2017-02-21 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r101121400 --- Diff: contrib/native/client/src/clientlib/drillClientImpl.cpp --- @@ -412,37 +427,155 @@ connectionStatus_t DrillClientImpl::validateHandshake

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

2017-02-21 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r101599452 --- Diff: contrib/native/client/src/clientlib/saslAuthenticatorImpl.cpp --- @@ -0,0 +1,211 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

2017-02-21 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r102344639 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/security/ServerAuthenticationHandler.java --- @@ -0,0 +1,269 @@ +/** + * Licensed

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

2017-02-21 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r102307826 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserServer.java --- @@ -358,25 +291,59 @@ public BitToUserHandshake

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

2017-02-21 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r101600048 --- Diff: contrib/native/client/src/clientlib/saslAuthenticatorImpl.hpp --- @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

2017-02-21 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r101602793 --- Diff: contrib/native/client/src/clientlib/saslAuthenticatorImpl.cpp --- @@ -0,0 +1,211 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

2017-02-21 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r102278730 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/AbstractClientConnection.java --- @@ -0,0 +1,61 @@ +/** + * Licensed

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

2017-02-21 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r102279444 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/AbstractServerConnection.java --- @@ -0,0 +1,121 @@ +/** + * Licensed

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

2017-02-21 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r101631177 --- Diff: common/src/main/java/org/apache/drill/common/KerberosUtil.java --- @@ -0,0 +1,76 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

2017-02-21 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r101598438 --- Diff: contrib/native/client/src/clientlib/saslAuthenticatorImpl.cpp --- @@ -0,0 +1,211 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

2017-02-21 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r101123168 --- Diff: contrib/native/client/src/clientlib/saslAuthenticatorImpl.cpp --- @@ -0,0 +1,207 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

2017-02-21 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r101600545 --- Diff: contrib/native/client/src/clientlib/saslAuthenticatorImpl.cpp --- @@ -0,0 +1,211 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

2017-02-21 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r102303605 --- Diff: exec/rpc/src/main/java/org/apache/drill/exec/rpc/ServerConnection.java --- @@ -0,0 +1,37 @@ +/** + * Licensed to the Apache Software

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

2017-02-21 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r102336062 --- Diff: common/src/main/java/org/apache/drill/common/KerberosUtil.java --- @@ -0,0 +1,76 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

2017-02-21 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r102348994 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserServer.java --- @@ -358,25 +291,59 @@ public BitToUserHandshake

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

2017-02-21 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r102344797 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/security/ClientAuthenticatorProvider.java --- @@ -0,0 +1,109 @@ +/** + * Licensed

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

2017-02-21 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r102342473 --- Diff: contrib/native/client/src/clientlib/saslAuthenticatorImpl.cpp --- @@ -0,0 +1,211 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

2017-02-21 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r102294263 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/control/ControlConnectionConfig.java --- @@ -0,0 +1,59 @@ +/** + * Licensed

[GitHub] drill pull request #613: DRILL-4730: Update JDBC DatabaseMetaData implementa...

2017-02-21 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/613#discussion_r102364337 --- Diff: exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillMetaImpl.java --- @@ -78,19 +111,237 @@ private MetaResultSet s(String s

[GitHub] drill pull request #613: DRILL-4730: Update JDBC DatabaseMetaData implementa...

2017-02-21 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/613#discussion_r102363803 --- Diff: exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillCursor.java --- @@ -24,33 +24,260 @@ import java.util.ArrayList; import

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

2017-02-21 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r102304062 --- Diff: exec/rpc/src/main/java/org/apache/drill/exec/rpc/ClientConnection.java --- @@ -0,0 +1,30 @@ +/** + * Licensed to the Apache Software

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

2017-02-21 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r102295865 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/data/DataClient.java --- @@ -75,27 +87,118 @@ public MessageLite

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

2017-02-21 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r101598598 --- Diff: contrib/native/client/src/clientlib/saslAuthenticatorImpl.cpp --- @@ -0,0 +1,211 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

2017-02-21 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r101116414 --- Diff: common/src/main/java/org/apache/drill/common/map/CaseInsensitiveMap.java --- @@ -55,6 +55,18 @@ } /** + * Returns a new

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

2017-02-21 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r102347409 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserClient.java --- @@ -88,22 +124,178 @@ public void submitQuery(UserResultsListener

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

2017-02-21 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r101601121 --- Diff: contrib/native/client/src/clientlib/saslAuthenticatorImpl.cpp --- @@ -0,0 +1,211 @@ +/* + * Licensed to the Apache Software Foundation

  1   2   3   4   >