GitHub user xhochy opened a pull request:
https://github.com/apache/drill/pull/649
DRILL-4979: Make port of the DataConnection configurable
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xhochy/drill DRILL-4979
Alternatively
Github user xhochy commented on the issue:
https://github.com/apache/drill/pull/649
No, this patch is actually functioning as the data port is already included
in the probuf:
https://github.com/apache/drill/blob/master/protocol/src/main/protobuf/Coordination.proto#L11
The `+1 logic
Github user xhochy commented on a diff in the pull request:
https://github.com/apache/drill/pull/647#discussion_r86720949
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/service/ServiceEngine.java
---
@@ -142,7 +142,13 @@ private static BufferAllocator newAllocator
Github user xhochy commented on the issue:
https://github.com/apache/drill/pull/947
Seeing that this is already covered by
https://github.com/apache/drill/pull/904, will close.
---
Github user xhochy closed the pull request at:
https://github.com/apache/drill/pull/947
---
Github user xhochy commented on the issue:
https://github.com/apache/drill/pull/946
Build failed with unrelated reasons to this PR:
```
[WARNING] Rule 0: org.apache.maven.plugins.enforcer.RequireFilesSize failed
with message:
The file drill-jdbc-all-1.12.0
Github user xhochy commented on the issue:
https://github.com/apache/drill/pull/946
@paul-rogers Thanks, rebase fixed the build.
---
GitHub user xhochy opened a pull request:
https://github.com/apache/drill/pull/952
DRILL-5438: Amazon S3 bucket can't be queried directly at root
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xhochy/drill DRILL-5438
Github user xhochy commented on the issue:
https://github.com/apache/drill/pull/952
It would be nice if someone could point me to the location where I should
add a unit test for this.
---
GitHub user xhochy opened a pull request:
https://github.com/apache/drill/pull/946
DRILL-5799: native-client: Support alternative build directories
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xhochy/drill DRILL-5799
GitHub user xhochy opened a pull request:
https://github.com/apache/drill/pull/947
DRILL-5800: Explicitly set locale to en_US on locale-dependent tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xhochy/drill DRILL-5800
GitHub user xhochy opened a pull request:
https://github.com/apache/drill/pull/1042
DRILL-5261: Expose REST endpoint in zookeeper
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xhochy/drill DRILL-5261
Alternatively you can
Github user xhochy commented on the issue:
https://github.com/apache/drill/pull/1042
This still needs the protobufs to be re-compiled for C++, I would do this
once someone signals me that I have taken the correct approach.
---
GitHub user xhochy opened a pull request:
https://github.com/apache/drill/pull/1022
DRILL-5924: native-client: Support user-specified CXX_FLAGS
Also remove the redundant sets of `CMAKE_CXX_FLAGS`. They are set on a
global scope so that there is no need to reset them more locally
Github user xhochy commented on the issue:
https://github.com/apache/drill/pull/1042
@kkhatua Thanks, I'll have a look at that PR.
---
Github user xhochy closed the pull request at:
https://github.com/apache/drill/pull/1042
---
16 matches
Mail list logo
