[GitHub] [drill] arina-ielchiieva commented on issue #1836: DRILL-7156: Support empty Parquet files creation

2019-08-15 Thread GitBox
arina-ielchiieva commented on issue #1836: DRILL-7156: Support empty Parquet files creation URL: https://github.com/apache/drill/pull/1836#issuecomment-521618404 Ran all tests on the test cluster, all passed. LGTM, +1 @oleg-zinovev thanks for making the changes.

[GitHub] [drill] arina-ielchiieva commented on issue #1836: DRILL-7156: Support empty Parquet files creation

2019-08-14 Thread GitBox
arina-ielchiieva commented on issue #1836: DRILL-7156: Support empty Parquet files creation URL: https://github.com/apache/drill/pull/1836#issuecomment-521263751 @oleg-zinovev thanks for making the changes, a couple of minor comments are left...

[GitHub] [drill] arina-ielchiieva commented on issue #1836: DRILL-7156: Support empty Parquet files creation

2019-08-14 Thread GitBox
arina-ielchiieva commented on issue #1836: DRILL-7156: Support empty Parquet files creation URL: https://github.com/apache/drill/pull/1836#issuecomment-521191646 > @arina-ielchiieva > Some time spent debugging the test showed that the last schema contains all fields. The field is added