[GitHub] [drill] arina-ielchiieva commented on issue #1836: DRILL-7156: Support empty Parquet files creation

2019-08-15 Thread GitBox
arina-ielchiieva commented on issue #1836: DRILL-7156: Support empty Parquet 
files creation
URL: https://github.com/apache/drill/pull/1836#issuecomment-521618404
 
 
   Ran all tests on the test cluster, all passed. LGTM, +1
   @oleg-zinovev thanks for making the changes.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [drill] arina-ielchiieva commented on issue #1836: DRILL-7156: Support empty Parquet files creation

2019-08-14 Thread GitBox
arina-ielchiieva commented on issue #1836: DRILL-7156: Support empty Parquet 
files creation
URL: https://github.com/apache/drill/pull/1836#issuecomment-521263751
 
 
   @oleg-zinovev thanks for making the changes, a couple of minor comments are 
left...


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [drill] arina-ielchiieva commented on issue #1836: DRILL-7156: Support empty Parquet files creation

2019-08-14 Thread GitBox
arina-ielchiieva commented on issue #1836: DRILL-7156: Support empty Parquet 
files creation
URL: https://github.com/apache/drill/pull/1836#issuecomment-521191646
 
 
   > @arina-ielchiieva
   > Some time spent debugging the test showed that the last schema contains 
all fields. The field is added in ProjectRecordBatch#setupNewSchemaFromInput.
   > In the original version of the test, field A was not added due to plan 
optimization - condition `1=0` was replaced by` limit 0`
   > 
   > I can still provide a solution with combining schema if required.
   
   This case we don't need schema merge,


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services