cgivre commented on issue #1978: DRILL-7578: HDF5 Metadata Queries Fail with
Large Files
URL: https://github.com/apache/drill/pull/1978#issuecomment-591972210
@arina-ielchiieva @paul-rogers
Thanks for the review!
Rebased and squashed.
cgivre commented on issue #1978: DRILL-7578: HDF5 Metadata Queries Fail with
Large Files
URL: https://github.com/apache/drill/pull/1978#issuecomment-591427930
@paul-rogers Do you approve of this PR?
This is an automated
cgivre commented on issue #1978: DRILL-7578: HDF5 Metadata Queries Fail with
Large Files
URL: https://github.com/apache/drill/pull/1978#issuecomment-591408854
@arina-ielchiieva Can we merge this PR now? Thx
This is an
cgivre commented on issue #1978: DRILL-7578: HDF5 Metadata Queries Fail with
Large Files
URL: https://github.com/apache/drill/pull/1978#issuecomment-590913914
> Nit: `toString`method will be called anyway, so no need to indicate it.
@arina-ielchiieva
Which line are you referring to?
cgivre commented on issue #1978: DRILL-7578: HDF5 Metadata Queries Fail with
Large Files
URL: https://github.com/apache/drill/pull/1978#issuecomment-589833387
@paul-rogers
I think this is ready for the second pass at review. Thx
cgivre commented on issue #1978: DRILL-7578: HDF5 Metadata Queries Fail with
Large Files
URL: https://github.com/apache/drill/pull/1978#issuecomment-587259759
@paul-rogers @vvysotskyi
See above comment. I removed the config option and added logger warnings if
the data is truncated.
cgivre commented on issue #1978: DRILL-7578: HDF5 Metadata Queries Fail with
Large Files
URL: https://github.com/apache/drill/pull/1978#issuecomment-585729825
@paul-rogers , @vvysotskyi
I was looking at the HDF5 library and it turns out that there is metadata
available for the
cgivre commented on issue #1978: DRILL-7578: HDF5 Metadata Queries Fail with
Large Files
URL: https://github.com/apache/drill/pull/1978#issuecomment-585540955
@paul-rogers
I don't really think it's useful to return that much data and that was why I
added the config option to disable
cgivre commented on issue #1978: DRILL-7578: HDF5 Metadata Queries Fail with
Large Files
URL: https://github.com/apache/drill/pull/1978#issuecomment-585353181
Here are the stack traces:
```
apache drill> select *
2..semicolon> from dfs.test.`eFitOut.h5`;
Error: RESOURCE ERROR:
cgivre commented on issue #1978: DRILL-7578: HDF5 Metadata Queries Fail with
Large Files
URL: https://github.com/apache/drill/pull/1978#issuecomment-585347032
@paul-rogers
Here's what's happening:
```
apache drill> select *
2..semicolon> from dfs.test.`eFitOut.h5`;
Error:
cgivre commented on issue #1978: DRILL-7578: HDF5 Metadata Queries Fail with
Large Files
URL: https://github.com/apache/drill/pull/1978#issuecomment-585272602
@vvysotskyi
Thanks for your responses and feedback. Maybe it would help if you saw how
this worked:
```
apache
cgivre commented on issue #1978: DRILL-7578: HDF5 Metadata Queries Fail with
Large Files
URL: https://github.com/apache/drill/pull/1978#issuecomment-585250445
@vvysotskyi
I was under the impression that the EVF handled pushdown project
automatically. @paul-rogers can you comment?
cgivre commented on issue #1978: DRILL-7578: HDF5 Metadata Queries Fail with
Large Files
URL: https://github.com/apache/drill/pull/1978#issuecomment-585184636
@vvysotskyi Let me give you some context..
This plugin has two ways of interacting with HDF5 files: metadata queries
and
13 matches
Mail list logo
