dobesv commented on issue #1972: DRILL-7562: Support HTTP Basic authentication
for REST API calls
URL: https://github.com/apache/drill/pull/1972#issuecomment-585454169
I created a docs PR here, if it's useful:
https://github.com/apache/drill/pull/1980
dobesv commented on issue #1972: DRILL-7562: Support HTTP Basic authentication
for REST API calls
URL: https://github.com/apache/drill/pull/1972#issuecomment-585449201
@ihuzenko I have rebased and squashed, please let me know if there's
anything more I can do to help!
Thank you for
dobesv commented on issue #1972: DRILL-7562: Support HTTP Basic authentication
for REST API calls
URL: https://github.com/apache/drill/pull/1972#issuecomment-585362214
I put the documentation into the PR description - I guess there is some
process that copies the documentation to the site
dobesv commented on issue #1972: DRILL-7562: Support HTTP Basic authentication
for REST API calls
URL: https://github.com/apache/drill/pull/1972#issuecomment-585361718
@ihuzenko Actually I hadn't noticed these classes shared a base class, I had
thought they only implemented an interface
dobesv commented on issue #1972: DRILL-7562: Support HTTP Basic authentication
for REST API calls
URL: https://github.com/apache/drill/pull/1972#issuecomment-585347586
I updated the PR description to include documentation for both the
Form-based and Basic authentication mechanisms.
dobesv commented on issue #1972: DRILL-7562: Support HTTP Basic authentication
for REST API calls
URL: https://github.com/apache/drill/pull/1972#issuecomment-585338367
@ihuzenko I think writing tests is going to be too much for me to do on
this, I've already spent more time on this PR
dobesv commented on issue #1972: DRILL-7562: Support HTTP Basic authentication
for REST API calls
URL: https://github.com/apache/drill/pull/1972#issuecomment-584238503
I just updated the commit message to include the JIRA issue.