[GitHub] [drill] dobesv commented on issue #1972: DRILL-7562: Support HTTP Basic authentication for REST API calls
dobesv commented on issue #1972: DRILL-7562: Support HTTP Basic authentication for REST API calls URL: https://github.com/apache/drill/pull/1972#issuecomment-585454169 I created a docs PR here, if it's useful: https://github.com/apache/drill/pull/1980 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [drill] dobesv commented on issue #1972: DRILL-7562: Support HTTP Basic authentication for REST API calls
dobesv commented on issue #1972: DRILL-7562: Support HTTP Basic authentication for REST API calls URL: https://github.com/apache/drill/pull/1972#issuecomment-585449201 @ihuzenko I have rebased and squashed, please let me know if there's anything more I can do to help! Thank you for your quick turnaround on the PRs! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [drill] dobesv commented on issue #1972: DRILL-7562: Support HTTP Basic authentication for REST API calls
dobesv commented on issue #1972: DRILL-7562: Support HTTP Basic authentication for REST API calls URL: https://github.com/apache/drill/pull/1972#issuecomment-585362214 I put the documentation into the PR description - I guess there is some process that copies the documentation to the site after a release? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [drill] dobesv commented on issue #1972: DRILL-7562: Support HTTP Basic authentication for REST API calls
dobesv commented on issue #1972: DRILL-7562: Support HTTP Basic authentication for REST API calls URL: https://github.com/apache/drill/pull/1972#issuecomment-585361718 @ihuzenko Actually I hadn't noticed these classes shared a base class, I had thought they only implemented an interface for some reason. I refactored that check up into the base class. However, I haven't figured out a way to confirm that the message is logged correctly. When I mess around with the configuration I can never actually see that message anywhere. Not that it is likely to be super important for the message to be correct, if it's not the stack trace will give all the information anyone needs. But if you know a way to test that message, let me know. I also fixed a bug I noticed while I was working on that, and resolved conflicts. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [drill] dobesv commented on issue #1972: DRILL-7562: Support HTTP Basic authentication for REST API calls
dobesv commented on issue #1972: DRILL-7562: Support HTTP Basic authentication for REST API calls URL: https://github.com/apache/drill/pull/1972#issuecomment-585347586 I updated the PR description to include documentation for both the Form-based and Basic authentication mechanisms. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [drill] dobesv commented on issue #1972: DRILL-7562: Support HTTP Basic authentication for REST API calls
dobesv commented on issue #1972: DRILL-7562: Support HTTP Basic authentication for REST API calls URL: https://github.com/apache/drill/pull/1972#issuecomment-585338367 @ihuzenko I think writing tests is going to be too much for me to do on this, I've already spent more time on this PR than I should have. Not only would I need to spin up a REST server fixture, but I would need it to have some kind of username & password authentication system setup with pre-defined usernames and password. If you would like to help me by adding some tests to this PR that would be great! Otherwise I think I lack the project-specific skill needed to do that in a reasonable amount of time. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [drill] dobesv commented on issue #1972: DRILL-7562: Support HTTP Basic authentication for REST API calls
dobesv commented on issue #1972: DRILL-7562: Support HTTP Basic authentication for REST API calls URL: https://github.com/apache/drill/pull/1972#issuecomment-584238503 I just updated the commit message to include the JIRA issue. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
