[GitHub] arina-ielchiieva commented on issue #1348: DRILL-6346: Create an Official Drill Docker Container
arina-ielchiieva commented on issue #1348: DRILL-6346: Create an Official Drill Docker Container URL: https://github.com/apache/drill/pull/1348#issuecomment-404604656 +1, LGTM. Please don't forget to create a follow up Jira for the enhancements. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] arina-ielchiieva commented on issue #1348: DRILL-6346: Create an Official Drill Docker Container
arina-ielchiieva commented on issue #1348: DRILL-6346: Create an Official Drill Docker Container URL: https://github.com/apache/drill/pull/1348#issuecomment-404499562 To summarize in this Jira we are aiming to add docker support only for Drill in embedded mode. @Agirish 1. Please create follow up Jira with future docker enhancements (support for distributed mode, making docker official and ability to build on docker env etc). 2. Please add clarifications I have mentioned in PR comment about detach, port forwarding, naming, docker machine and querying custom files. Once all that is done, I believe we can approve the PR and merge it. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] arina-ielchiieva commented on issue #1348: DRILL-6346: Create an Official Drill Docker Container
arina-ielchiieva commented on issue #1348: DRILL-6346: Create an Official Drill Docker Container URL: https://github.com/apache/drill/pull/1348#issuecomment-403779653 Another point we should consider is that there are two ways that author can publish images on Docker Hub: build locally and push or make Dockerfile publicly available and use Docker Hub's continuous build system. The second way is more preferred and marked as trusted. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] arina-ielchiieva commented on issue #1348: DRILL-6346: Create an Official Drill Docker Container
arina-ielchiieva commented on issue #1348: DRILL-6346: Create an Official Drill Docker Container URL: https://github.com/apache/drill/pull/1348#issuecomment-402434002 @Agirish doc looks good and sure please include it in this PR. One minor suggestion in `Push Docker Image` section, please add example how to define custom repo. I suppose it should be something like this: `mvn dockerfile:push -Pdocker -Pdocker.repository=`. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] arina-ielchiieva commented on issue #1348: DRILL-6346: Create an Official Drill Docker Container
arina-ielchiieva commented on issue #1348: DRILL-6346: Create an Official Drill Docker Container URL: https://github.com/apache/drill/pull/1348#issuecomment-402113696 +1 but @Agirish please follow up on the following items: 1. document `drill-localhost` usage; 2. document docker build in docs/dev/DevDocs.md; 3. apply to make drill docker repository official (https://docs.docker.com/docker-hub/official_repos/#how-do-i-create-a-new-official-repository). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] arina-ielchiieva commented on issue #1348: DRILL-6346: Create an Official Drill Docker Container
arina-ielchiieva commented on issue #1348: DRILL-6346: Create an Official Drill Docker Container URL: https://github.com/apache/drill/pull/1348#issuecomment-401541979 @Agirish I think having separate docker profile is good idea. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
