[GitHub] drill issue #1012: DRILL-5911: Upgrade esri-geometry-api version to 2.0.0 to...

2017-10-28 Thread vrozov
Github user vrozov commented on the issue: https://github.com/apache/drill/pull/1012 OK. LGTM. ---

[GitHub] drill issue #1012: DRILL-5911: Upgrade esri-geometry-api version to 2.0.0 to...

2017-10-28 Thread vvysotskyi
Github user vvysotskyi commented on the issue: https://github.com/apache/drill/pull/1012 @vrozov, sorry for the misunderstanding. Currently, it is also not supported. ---

[GitHub] drill issue #1012: DRILL-5911: Upgrade esri-geometry-api version to 2.0.0 to...

2017-10-28 Thread vrozov
Github user vrozov commented on the issue: https://github.com/apache/drill/pull/1012 @vvysotskyi I refer to JSON format that ESRI supports by itself. ---

[GitHub] drill issue #1012: DRILL-5911: Upgrade esri-geometry-api version to 2.0.0 to...

2017-10-28 Thread vvysotskyi
Github user vvysotskyi commented on the issue: https://github.com/apache/drill/pull/1012 @vrozov, If you meant [geojson](http://geojson.org) when saying about JSON format support, then my answer - not, it is not supported yet. ---

[GitHub] drill issue #1012: DRILL-5911: Upgrade esri-geometry-api version to 2.0.0 to...

2017-10-27 Thread julianhyde
Github user julianhyde commented on the issue: https://github.com/apache/drill/pull/1012 If I recall correctly -- we went through this because Calcite uses ESRI -- the only change was to remove org.json. It's a pretty important change because org.json is not compatible with Apache

[GitHub] drill issue #1012: DRILL-5911: Upgrade esri-geometry-api version to 2.0.0 to...

2017-10-27 Thread vrozov
Github user vrozov commented on the issue: https://github.com/apache/drill/pull/1012 @vvysotskyi OK, thanks. Currently, gis unit tests only work with CSV geo-spacial data. It sounds that JSON format is also supported and is not covered by the gis unit tests. Can you confirm if JSON

[GitHub] drill issue #1012: DRILL-5911: Upgrade esri-geometry-api version to 2.0.0 to...

2017-10-27 Thread vvysotskyi
Github user vvysotskyi commented on the issue: https://github.com/apache/drill/pull/1012 @vrozov As I understand from the [release notes](https://github.com/Esri/geometry-api-java/releases/tag/v2.0.0), the main reason for the major version change was changing the interface due to the

[GitHub] drill issue #1012: DRILL-5911: Upgrade esri-geometry-api version to 2.0.0 to...

2017-10-27 Thread vrozov
Github user vrozov commented on the issue: https://github.com/apache/drill/pull/1012 @vvysotskyi It is a major version change of the dependency, but except for the pom file changes, there are no other changes. It will be good to understand what triggered a major version change (do

[GitHub] drill issue #1012: DRILL-5911: Upgrade esri-geometry-api version to 2.0.0 to...

2017-10-27 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/1012 +1, LGTM. ---