[GitHub] drill issue #1105: DRILL-6125: Fix possible memory leak when query is finish...

2018-03-29 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/1105 +1 ---

[GitHub] drill issue #1105: DRILL-6125: Fix possible memory leak when query is finish...

2018-03-27 Thread vrozov
Github user vrozov commented on the issue: https://github.com/apache/drill/pull/1105 @arina-ielchiieva Please review. ---

[GitHub] drill issue #1105: DRILL-6125: Fix possible memory leak when query is finish...

2018-03-12 Thread ilooner
Github user ilooner commented on the issue: https://github.com/apache/drill/pull/1105 Squashed commits. @arina-ielchiieva please let me know if you have any comments. ---

[GitHub] drill issue #1105: DRILL-6125: Fix possible memory leak when query is finish...

2018-03-08 Thread ilooner
Github user ilooner commented on the issue: https://github.com/apache/drill/pull/1105 @vrozov @arina-ielchiieva Applied review comments, please let me know if there are anymore comments. ---

[GitHub] drill issue #1105: DRILL-6125: Fix possible memory leak when query is finish...

2018-03-07 Thread ilooner
Github user ilooner commented on the issue: https://github.com/apache/drill/pull/1105 @vrozov @arina-ielchiieva Handled multiple receiver finished messages correctly. This PR is ready for another round of review. ---

[GitHub] drill issue #1105: DRILL-6125: Fix possible memory leak when query is finish...

2018-03-07 Thread ilooner
Github user ilooner commented on the issue: https://github.com/apache/drill/pull/1105 Nope never mind I think I spoke too soon. I just realized we may get multiple receivingFragmentFinished requests, one for each downstream receiver. Back to the drawing board. ---

[GitHub] drill issue #1105: DRILL-6125: Fix possible memory leak when query is finish...

2018-03-07 Thread ilooner
Github user ilooner commented on the issue: https://github.com/apache/drill/pull/1105 @arina-ielchiieva @vrozov In light of Vlad's comments I have reworked the synchronization model yet again. This change now removes all synchronization from PartitionSenderRootExec and enforces the gu