[GitHub] drill issue #1160: DRILL-6224: Publish current memory usage for Drillbits in...

2018-03-23 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the issue:

https://github.com/apache/drill/pull/1160
  
+1, thanks for making the changes.


---


[GitHub] drill issue #1160: DRILL-6224: Publish current memory usage for Drillbits in...

2018-03-23 Thread kkhatua
Github user kkhatua commented on the issue:

https://github.com/apache/drill/pull/1160
  
During a freshly setup Drillbit:

![image](https://user-images.githubusercontent.com/4335237/37847547-644fa67c-2e8e-11e8-9aa7-2b4adf499cd0.png)

While running 2 large (600M rows) join query on a 4 node setup, and one 
completes:

![image](https://user-images.githubusercontent.com/4335237/37847633-b4dd5a76-2e8e-11e8-9c1d-87c3a0f9f3e7.png)

The Heap Usage percentage is based on {{heapUsed/heapMax}}
The Actively Used Direct percentage is based on 
{{currentDirectInUse/PeakDirectUsed}} 
This is because the actual total direct memory used by Netty is not 
exposed. However, this does tell how much the Drillbit is using at the moment.


---


[GitHub] drill issue #1160: DRILL-6224: Publish current memory usage for Drillbits in...

2018-03-23 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the issue:

https://github.com/apache/drill/pull/1160
  
+1


---


[GitHub] drill issue #1160: DRILL-6224: Publish current memory usage for Drillbits in...

2018-03-22 Thread kkhatua
Github user kkhatua commented on the issue:

https://github.com/apache/drill/pull/1160
  
@arina-ielchiieva 
Restricting this PR to address the bug in `metrics.ftl`
Will create a new PR for 
[DRILL-6289](https://issues.apache.org/jira/browse/DRILL-6289)


---


[GitHub] drill issue #1160: DRILL-6224: Publish current memory usage for Drillbits in...

2018-03-12 Thread kkhatua
Github user kkhatua commented on the issue:

https://github.com/apache/drill/pull/1160
  
I think I need to put up some tooltips.

We're getting the metrics from the `drill.allocator.root.[peak|used]` 
values. I haven't seen a metric that shows the actual Direct allocation from 
the system. What Drill seems to report is the current **actively** used Direct 
memory. So, when running queries on the cluster, these numbers move up. The 
percentage for Direct is the current usage as a percent of the peak memory that 
was reported by the root allocator.

Check out any active Drillbit's `#metrics` page. The `drill.allocator.*` 
entries are what I was referring to. JVM itself doesn't appear to expose the 
Direct memory information readily.


---


[GitHub] drill issue #1160: DRILL-6224: Publish current memory usage for Drillbits in...

2018-03-12 Thread parthchandra
Github user parthchandra commented on the issue:

https://github.com/apache/drill/pull/1160
  
Looks wrong dunnit? Direct memory is (still?) showing as zero?


---


[GitHub] drill issue #1160: DRILL-6224: Publish current memory usage for Drillbits in...

2018-03-12 Thread kkhatua
Github user kkhatua commented on the issue:

https://github.com/apache/drill/pull/1160
  
@parthchandra / @arina-ielchiieva  would you guys want to review this? 
Here is a preview of how the details appear on the default page:

![image](https://user-images.githubusercontent.com/4335237/37267989-c42b7a42-2580-11e8-9581-2023895503eb.png)




---