[GitHub] drill issue #1168: DRILL-6246: Reduced the size of the jdbc-all jar file

[sachouche]

Github user sachouche commented on the issue:

https://github.com/apache/drill/pull/1168
  
No I didn't.

Regards,
Salim

Regards,
Salim

-Original Message-
From: Kunal Khatua [notificati...@github.com]
Received: Tuesday, 10 Apr 2018, 14:01
To: apache/drill [dr...@noreply.github.com]
CC: Salim Achouche [sachou...@mapr.com]; Mention 
[ment...@noreply.github.com]
Subject: Re: [apache/drill] DRILL-6246: Reduced the size of the jdbc-all 
jar file (#1168)



@sachouche
 have you had a chance to test the generated JDBC driver with Spotfire/SQuirreL 
?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on 
GitHub,
 or mute the 
thread.



---

[GitHub] drill issue #1168: DRILL-6246: Reduced the size of the jdbc-all jar file

[kkhatua]

Github user kkhatua commented on the issue:

https://github.com/apache/drill/pull/1168
  
@sachouche have you had a chance to test the generated JDBC driver with 
Spotfire/SQuirreL ?


---

[GitHub] drill issue #1168: DRILL-6246: Reduced the size of the jdbc-all jar file

[parthchandra]

Github user parthchandra commented on the issue:

https://github.com/apache/drill/pull/1168
  
I would recommend trying to setup a connection using Spotfire or Squirrel 
and running a couple of metadata queries and a couple of queries on complex 
data. (These have traditionally been areas that were affected when the jar was 
incomplete). 
Also try on a secure cluster. You might need help from other folks on some 
of this. 


---

[GitHub] drill issue #1168: DRILL-6246: Reduced the size of the jdbc-all jar file

[sachouche]

Github user sachouche commented on the issue:

https://github.com/apache/drill/pull/1168
  
I successfully ran the test-suite and some advanced tests which loaded the 
jdbc artifacts. Is this enough to validate the fix (and future exclusions to 
keep the jar size in-check)? if not, what other tests(s) do we need to run?

Thanks!  


---

[GitHub] drill issue #1168: DRILL-6246: Reduced the size of the jdbc-all jar file

[vvysotskyi]

Github user vvysotskyi commented on the issue:

https://github.com/apache/drill/pull/1168
  
Classes from `avatica.metrics` are used in `JsonHandler`, `ProtobufHandler` 
and `LocalService`. If Drill does not use these classes than I agree that we 
can exclude it from `jdbc-all` jar. 
Regarding excluding `avatica/org/**`, looks like the problem is in the 
Avatica pom files since there are no dependencies to `org.apache.commons` and 
`org.apache.http`, but they are shaded to the jar. Created Jira CALCITE-2215 to 
fix this issue, but for now, I think it's ok to exclude them.


---

[GitHub] drill issue #1168: DRILL-6246: Reduced the size of the jdbc-all jar file

[sohami]

Github user sohami commented on the issue:

https://github.com/apache/drill/pull/1168
  
+1 LGTM. Thanks for making the changes.


---

[GitHub] drill issue #1168: DRILL-6246: Reduced the size of the jdbc-all jar file

[sachouche]

Github user sachouche commented on the issue:

https://github.com/apache/drill/pull/1168
  
@sohami can you please review this pull request?

Thanks!


---