Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1238
There is not enough info available to debug and/or troubleshoot DRILL-5908
and I prefer instead of trying to find bugs in homegrown solution replace it
with Java out of the box functionality and at
Github user parthchandra commented on the issue:
https://github.com/apache/drill/pull/1238
Fair enough. But that *still* does not give me a clue about the problem(s)
you were trying to fix, or how the refactoring helps. Is the cause of the
problem in TimedRunnable?
Not an
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1238
I did not change how tasks (`Runnable` or `Callable`) behave and did not
look into converting `Callable/Runnable` to a `ForkJoinTask`. Whether existing
tasks can be scheduled recursively or not
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1238
The step is necessary to do RCA for DRILL-5908. There are way too many
issues with the current implementation to list them in JIRA or PR and the major
issue is the usage of homegrown solutions where
Github user parthchandra commented on the issue:
https://github.com/apache/drill/pull/1238
I had the same question as Arina about the need for this change and I got
info from DRILL-5908 about the problem cause and how this change will help fix
it. Can you elucidate?
---
Github user HanumathRao commented on the issue:
https://github.com/apache/drill/pull/1238
@vrozov Thanks for making the changes. Code changes looks good to me.
---
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1238
@parthchandra Please review.
Note to a committer: please do *not* squash commits.
---
