[GitHub] drill pull request #1057: DRILL-5993 Append Row Method For VectorContainer (...

2017-11-29 Thread ilooner
Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/1057#discussion_r153958856 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/record/TestVectorContainer.java --- @@ -124,4 +132,52 @@ public void testContainerMerge() {

[GitHub] drill pull request #1057: DRILL-5993 Append Row Method For VectorContainer (...

2017-11-29 Thread Ben-Zvi
Github user Ben-Zvi commented on a diff in the pull request: https://github.com/apache/drill/pull/1057#discussion_r153934729 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/record/VectorContainer.java --- @@ -353,6 +353,23 @@ public int getRecordCount() {

[GitHub] drill pull request #1057: DRILL-5993 Append Row Method For VectorContainer (...

2017-11-29 Thread Ben-Zvi
Github user Ben-Zvi commented on a diff in the pull request: https://github.com/apache/drill/pull/1057#discussion_r153935071 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/record/TestVectorContainer.java --- @@ -124,4 +132,52 @@ public void testContainerMerge() {

[GitHub] drill pull request #1057: DRILL-5993 Append Row Method For VectorContainer (...

2017-11-29 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1057#discussion_r153926390 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/record/VectorContainer.java --- @@ -353,6 +353,23 @@ public int getRecordCount() {

[GitHub] drill pull request #1057: DRILL-5993 Append Row Method For VectorContainer (...

2017-11-29 Thread ilooner
GitHub user ilooner opened a pull request: https://github.com/apache/drill/pull/1057 DRILL-5993 Append Row Method For VectorContainer (WIP) ## Motivation HashJoin requires a method that can take a row from a VectorContainer and append it to a destination VectorContainer.