[GitHub] drill pull request #594: DRILL-4842: SELECT * on JSON data results in Number...

2017-02-28 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/594#discussion_r103547010 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/fn/JsonReader.java --- @@ -170,6 +184,21 @@ public void

[GitHub] drill pull request #594: DRILL-4842: SELECT * on JSON data results in Number...

2017-02-16 Thread amansinha100
Github user amansinha100 commented on a diff in the pull request: https://github.com/apache/drill/pull/594#discussion_r101624385 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/fn/JsonReader.java --- @@ -492,7 +538,19 @@ private void

[GitHub] drill pull request #594: DRILL-4842: SELECT * on JSON data results in Number...

2017-02-14 Thread Serhii-Harnyk
Github user Serhii-Harnyk commented on a diff in the pull request: https://github.com/apache/drill/pull/594#discussion_r101024133 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/fn/JsonReader.java --- @@ -492,10 +537,18 @@ private void

[GitHub] drill pull request #594: DRILL-4842: SELECT * on JSON data results in Number...

2017-02-10 Thread amansinha100
Github user amansinha100 commented on a diff in the pull request: https://github.com/apache/drill/pull/594#discussion_r100653436 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/fn/JsonReader.java --- @@ -492,10 +537,18 @@ private void

[GitHub] drill pull request #594: DRILL-4842: SELECT * on JSON data results in Number...

2016-12-14 Thread Serhii-Harnyk
Github user Serhii-Harnyk commented on a diff in the pull request: https://github.com/apache/drill/pull/594#discussion_r92478836 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/fn/JsonReader.java --- @@ -510,10 +517,13 @@ private void

[GitHub] drill pull request #594: DRILL-4842: SELECT * on JSON data results in Number...

2016-12-14 Thread chunhui-shi
Github user chunhui-shi commented on a diff in the pull request: https://github.com/apache/drill/pull/594#discussion_r92452185 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/fn/JsonReader.java --- @@ -510,10 +517,13 @@ private void

[GitHub] drill pull request #594: DRILL-4842: SELECT * on JSON data results in Number...

2016-12-01 Thread chunhui-shi
Github user chunhui-shi commented on a diff in the pull request: https://github.com/apache/drill/pull/594#discussion_r90494185 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/fn/JsonReader.java --- @@ -59,12 +59,13 @@ private final

[GitHub] drill pull request #594: DRILL-4842: SELECT * on JSON data results in Number...

2016-11-01 Thread chunhui-shi
Github user chunhui-shi commented on a diff in the pull request: https://github.com/apache/drill/pull/594#discussion_r85984205 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/fn/JsonReader.java --- @@ -59,12 +59,13 @@ private final

[GitHub] drill pull request #594: DRILL-4842: SELECT * on JSON data results in Number...

2016-10-21 Thread Serhii-Harnyk
Github user Serhii-Harnyk commented on a diff in the pull request: https://github.com/apache/drill/pull/594#discussion_r84509937 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/fn/JsonReader.java --- @@ -337,6 +364,7 @@ private void writeData(MapWriter

[GitHub] drill pull request #594: DRILL-4842: SELECT * on JSON data results in Number...

2016-10-21 Thread Serhii-Harnyk
Github user Serhii-Harnyk commented on a diff in the pull request: https://github.com/apache/drill/pull/594#discussion_r84509944 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/fn/JsonReader.java --- @@ -418,6 +447,7 @@ private void

[GitHub] drill pull request #594: DRILL-4842: SELECT * on JSON data results in Number...

2016-10-21 Thread Serhii-Harnyk
Github user Serhii-Harnyk commented on a diff in the pull request: https://github.com/apache/drill/pull/594#discussion_r84507055 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/fn/JsonReader.java --- @@ -56,6 +58,12 @@ private final boolean

[GitHub] drill pull request #594: DRILL-4842: SELECT * on JSON data results in Number...

2016-10-21 Thread Serhii-Harnyk
Github user Serhii-Harnyk commented on a diff in the pull request: https://github.com/apache/drill/pull/594#discussion_r84507516 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/fn/JsonReader.java --- @@ -131,14 +139,33 @@ public void

[GitHub] drill pull request #594: DRILL-4842: SELECT * on JSON data results in Number...

2016-10-21 Thread Serhii-Harnyk
Github user Serhii-Harnyk commented on a diff in the pull request: https://github.com/apache/drill/pull/594#discussion_r84508112 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/fn/JsonReader.java --- @@ -131,14 +139,33 @@ public void

[GitHub] drill pull request #594: DRILL-4842: SELECT * on JSON data results in Number...

2016-10-03 Thread chunhui-shi
Github user chunhui-shi commented on a diff in the pull request: https://github.com/apache/drill/pull/594#discussion_r81627752 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/fn/JsonReader.java --- @@ -56,6 +58,12 @@ private final boolean

[GitHub] drill pull request #594: DRILL-4842: SELECT * on JSON data results in Number...

2016-10-03 Thread chunhui-shi
Github user chunhui-shi commented on a diff in the pull request: https://github.com/apache/drill/pull/594#discussion_r81622069 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/fn/JsonReader.java --- @@ -131,14 +139,33 @@ public void

[GitHub] drill pull request #594: DRILL-4842: SELECT * on JSON data results in Number...

2016-10-03 Thread chunhui-shi
Github user chunhui-shi commented on a diff in the pull request: https://github.com/apache/drill/pull/594#discussion_r81619869 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/fn/JsonReader.java --- @@ -418,6 +447,7 @@ private void

[GitHub] drill pull request #594: DRILL-4842: SELECT * on JSON data results in Number...

2016-10-03 Thread chunhui-shi
Github user chunhui-shi commented on a diff in the pull request: https://github.com/apache/drill/pull/594#discussion_r81617585 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/fn/JsonReader.java --- @@ -131,14 +139,33 @@ public void

[GitHub] drill pull request #594: DRILL-4842: SELECT * on JSON data results in Number...

2016-10-03 Thread chunhui-shi
Github user chunhui-shi commented on a diff in the pull request: https://github.com/apache/drill/pull/594#discussion_r81619047 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/fn/JsonReader.java --- @@ -337,6 +364,7 @@ private void writeData(MapWriter

[GitHub] drill pull request #594: DRILL-4842: SELECT * on JSON data results in Number...

2016-09-21 Thread Serhii-Harnyk
GitHub user Serhii-Harnyk opened a pull request: https://github.com/apache/drill/pull/594 DRILL-4842: SELECT * on JSON data results in NumberFormatException You can merge this pull request into a Git repository by running: $ git pull https://github.com/Serhii-Harnyk/drill