[GitHub] drill pull request #595: DRILL-4203: Parquet File. Date is stored wrongly

2016-10-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/595 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] drill pull request #595: DRILL-4203: Parquet File. Date is stored wrongly

2016-10-10 Thread parthchandra
Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/595#discussion_r82690304 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/FixedByteAlignedReader.java --- @@ -161,7 +160,7 @@ void

[GitHub] drill pull request #595: DRILL-4203: Parquet File. Date is stored wrongly

2016-10-06 Thread jaltekruse
Github user jaltekruse commented on a diff in the pull request: https://github.com/apache/drill/pull/595#discussion_r82291973 --- Diff: contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveDrillNativeScanBatchCreator.java --- @@ -123,6 +123,7 @@ public

[GitHub] drill pull request #595: DRILL-4203: Parquet File. Date is stored wrongly

2016-10-06 Thread jaltekruse
Github user jaltekruse commented on a diff in the pull request: https://github.com/apache/drill/pull/595#discussion_r82292165 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetReaderUtility.java --- @@ -184,17 +201,15 @@ public static

[GitHub] drill pull request #595: DRILL-4203: Parquet File. Date is stored wrongly

2016-10-06 Thread jaltekruse
Github user jaltekruse commented on a diff in the pull request: https://github.com/apache/drill/pull/595#discussion_r82292241 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetScanBatchCreator.java --- @@ -107,6 +107,7 @@ public ScanBatch

[GitHub] drill pull request #595: DRILL-4203: Parquet File. Date is stored wrongly

2016-10-06 Thread vdiravka
Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/595#discussion_r82287507 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetReaderUtility.java --- @@ -184,17 +201,15 @@ public static

[GitHub] drill pull request #595: DRILL-4203: Parquet File. Date is stored wrongly

2016-10-06 Thread vdiravka
Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/595#discussion_r82290736 --- Diff: contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveDrillNativeScanBatchCreator.java --- @@ -123,6 +123,7 @@ public

[GitHub] drill pull request #595: DRILL-4203: Parquet File. Date is stored wrongly

2016-10-06 Thread jaltekruse
Github user jaltekruse commented on a diff in the pull request: https://github.com/apache/drill/pull/595#discussion_r82274813 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetReaderUtility.java --- @@ -184,17 +201,15 @@ public static

[GitHub] drill pull request #595: DRILL-4203: Parquet File. Date is stored wrongly

2016-10-06 Thread jaltekruse
Github user jaltekruse commented on a diff in the pull request: https://github.com/apache/drill/pull/595#discussion_r82273282 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/Metadata.java --- @@ -918,18 +916,22 @@ public void setMax(Object max) {

[GitHub] drill pull request #595: DRILL-4203: Parquet File. Date is stored wrongly

2016-10-06 Thread jaltekruse
Github user jaltekruse commented on a diff in the pull request: https://github.com/apache/drill/pull/595#discussion_r82272848 --- Diff: contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveDrillNativeScanBatchCreator.java --- @@ -123,6 +123,7 @@ public

[GitHub] drill pull request #595: DRILL-4203: Parquet File. Date is stored wrongly

2016-10-04 Thread vdiravka
Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/595#discussion_r81736781 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/Metadata.java --- @@ -918,18 +916,22 @@ public void setMax(Object max) {

[GitHub] drill pull request #595: DRILL-4203: Parquet File. Date is stored wrongly

2016-10-04 Thread vdiravka
Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/595#discussion_r81722838 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetScanBatchCreator.java --- @@ -104,6 +104,9 @@ public ScanBatch

[GitHub] drill pull request #595: DRILL-4203: Parquet File. Date is stored wrongly

2016-10-03 Thread vdiravka
Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/595#discussion_r81636854 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ParquetRecordReader.java --- @@ -207,6 +229,31 @@ public

[GitHub] drill pull request #595: DRILL-4203: Parquet File. Date is stored wrongly

2016-10-03 Thread vdiravka
Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/595#discussion_r81625584 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java --- @@ -664,27 +667,37 @@ private void init(MetadataContext

[GitHub] drill pull request #595: DRILL-4203: Parquet File. Date is stored wrongly

2016-10-03 Thread vdiravka
Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/595#discussion_r81625440 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/Metadata.java --- @@ -935,6 +972,11 @@ public ColumnTypeMetadata_v2

[GitHub] drill pull request #595: DRILL-4203: Parquet File. Date is stored wrongly

2016-09-30 Thread jaltekruse
Github user jaltekruse commented on a diff in the pull request: https://github.com/apache/drill/pull/595#discussion_r81396800 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/Metadata.java --- @@ -918,18 +916,22 @@ public void setMax(Object max) {

[GitHub] drill pull request #595: DRILL-4203: Parquet File. Date is stored wrongly

2016-09-29 Thread parthchandra
Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/595#discussion_r81240983 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetScanBatchCreator.java --- @@ -104,6 +104,9 @@ public ScanBatch

[GitHub] drill pull request #595: DRILL-4203: Parquet File. Date is stored wrongly

2016-09-29 Thread parthchandra
Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/595#discussion_r81238209 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java --- @@ -664,27 +667,37 @@ private void

[GitHub] drill pull request #595: DRILL-4203: Parquet File. Date is stored wrongly

2016-09-29 Thread parthchandra
Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/595#discussion_r81244832 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ParquetRecordReader.java --- @@ -207,6 +229,31 @@ public

[GitHub] drill pull request #595: DRILL-4203: Parquet File. Date is stored wrongly

2016-09-29 Thread parthchandra
Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/595#discussion_r81240013 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetReaderUtility.java --- @@ -18,16 +18,62 @@ package

[GitHub] drill pull request #595: DRILL-4203: Parquet File. Date is stored wrongly

2016-09-22 Thread vdiravka
GitHub user vdiravka opened a pull request: https://github.com/apache/drill/pull/595 DRILL-4203: Parquet File. Date is stored wrongly Drill was writing non-standard dates into parquet files for all releases before this commit. The values have been read correctly by Drill, but