[GitHub] drill pull request #612: DRILL-4925: Add tableType filter to GetTables metad...

2016-10-13 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/drill/pull/612


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] drill pull request #612: DRILL-4925: Add tableType filter to GetTables metad...

2016-10-12 Thread vkorukanti
Github user vkorukanti commented on a diff in the pull request:

https://github.com/apache/drill/pull/612#discussion_r83124391
  
--- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/work/metadata/MetadataProvider.java
 ---
@@ -347,9 +351,9 @@ protected Response runInternal(final UserSession 
session, final SchemaTreeProvid
   } catch (Exception e) {
--- End diff --

We should change this to Throwable or keep the response sending code in 
finally block to avoid client waiting indefinitely.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] drill pull request #612: DRILL-4925: Add tableType filter to GetTables metad...

2016-10-12 Thread laurentgo
GitHub user laurentgo opened a pull request:

https://github.com/apache/drill/pull/612

DRILL-4925: Add tableType filter to GetTables metadata query

- Adding tableType filter to GetTablesReq query (needed for JDBC and ODBC
drivers).
- Fix table type returned by sys and INFORMATION_SCHEMA tables
- Also fixes some protobuf typos to related classes.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/laurentgo/drill laurent/DRILL-4925

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/drill/pull/612.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #612






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---