Re: [1.13 - Release Blocker] - DRILL-6216: Metadata mismatch when connecting to a Drill 1.12.0 with a Drill-1.13.0-SNAPSHOT driver

2018-03-07 Thread Parth Chandra
Paul , thanks for confirming that it is safe to revert. On Wed, Mar 7, 2018 at 11:52 AM, Paul Rogers wrote: > Hi Sorabh, > Thanks for tracking this one down. Our unit tests did not uncover this > issue when I did the original PR, unfortunately. The name change was

Re: [1.13 - Release Blocker] - DRILL-6216: Metadata mismatch when connecting to a Drill 1.12.0 with a Drill-1.13.0-SNAPSHOT driver

2018-03-06 Thread Paul Rogers
Hi Sorabh, Thanks for tracking this one down. Our unit tests did not uncover this issue when I did the original PR, unfortunately. The name change was done to be consistent with other places where we use special names and, as I recall, help with certain tasks. Clearly, however, if the client

Re: [1.13 - Release Blocker] - DRILL-6216: Metadata mismatch when connecting to a Drill 1.12.0 with a Drill-1.13.0-SNAPSHOT driver

2018-03-06 Thread Parth Chandra
+1 on reverting this if it doesn't break things. On Wed, Mar 7, 2018 at 11:11 AM, Aman Sinha wrote: > Thanks Sorabh, for the analysis and the pointers to the relevant code. > Doing the version check check for client and server would be the right > thing to do but probably

Re: [1.13 - Release Blocker] - DRILL-6216: Metadata mismatch when connecting to a Drill 1.12.0 with a Drill-1.13.0-SNAPSHOT driver

2018-03-06 Thread Aman Sinha
Thanks Sorabh, for the analysis and the pointers to the relevant code. Doing the version check check for client and server would be the right thing to do but probably too disruptive at this stage of the release. We should do it for the next release. For 1.13, could the change of the $values$ be