I will review. But, you still need to get a committer to do the final review and approve it.
Thanks Padma > On Feb 12, 2018, at 8:37 AM, Paul Rogers <par0...@yahoo.com.INVALID> wrote: > > Hi All, > Anyone available to review PR #1112? It is another step in committing the > final result set loader revisions. > Recall that we more-or-less decided to commit the remaining work as a series > of small PRs rather than a single huge one. [1] This does require quite a bit > of work to constantly rebase on master, and to redevelop each partial PR so > it works by itself. This is done to ease reviews. But, the cost is that there > are more PRs, and the schedule is more sensitive to the "aging" delays before > someone starts reviewing a PR. > We've also discussed Salim's intent to re-implement some of this work for > Parquet (at least the part that limits batch size). That intent may come, in > part, because it appears easier to just do new code rather than wait for the > existing code to be committed. Would be great if we could redirect some of > that new-code effort into reviews of the existing stuff so it can be used. > Thanks, > - Paul > [1] > https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_paul-2Drogers_drill_wiki_BH-2DCode-2DIntro-23pull-2Drequest-2Dplan&d=DwIFaQ&c=cskdkSMqhcnjZxdQVpwTXg&r=XVqW14B9eGK9QR_fKKCb5H5LxKnqNMmq1U7RdNlhq1c&m=tdX_VJLpPDX8hmtQlncHPudDN9QANn5g_DIM9QSVChc&s=rU3uOmbYX3e-zztMTViuLl0-d6y2tIkCdE9qz6J7qdw&e= >
