[GitHub] codecov-io commented on issue #1612: [Dubbo-Config] replace by Constants.

2018-04-15 Thread GitBox
codecov-io commented on issue #1612: [Dubbo-Config] replace by Constants. URL: https://github.com/apache/incubator-dubbo/pull/1612#issuecomment-381392175 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1612?src=pr=h1) Report > Merging

[GitHub] mercyblitz opened a new pull request #1610: Spring Framework / Spring Boot Enhancements

2018-04-15 Thread GitBox
mercyblitz opened a new pull request #1610: Spring Framework / Spring Boot Enhancements URL: https://github.com/apache/incubator-dubbo/pull/1610 ## What is the purpose of the change * Bugfix : Legacy Spring annotation-driven issues on placeholder. * Refactor: The binder for

[GitHub] codecov-io commented on issue #1612: [Dubbo-Config] replace by Constants.

2018-04-15 Thread GitBox
codecov-io commented on issue #1612: [Dubbo-Config] replace by Constants. URL: https://github.com/apache/incubator-dubbo/pull/1612#issuecomment-381392175 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1612?src=pr=h1) Report > Merging

[GitHub] mercyblitz closed pull request #1610: Spring Framework / Spring Boot Enhancements

2018-04-15 Thread GitBox
mercyblitz closed pull request #1610: Spring Framework / Spring Boot Enhancements URL: https://github.com/apache/incubator-dubbo/pull/1610 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] mercyblitz opened a new pull request #1611: Spring Framework / Spring Boot Enhancements

2018-04-15 Thread GitBox
mercyblitz opened a new pull request #1611: Spring Framework / Spring Boot Enhancements URL: https://github.com/apache/incubator-dubbo/pull/1611 ## What is the purpose of the change * Bugfix : Legacy Spring annotation-driven issues on placeholder. * Refactor: The binder for

[GitHub] levin950825 opened a new issue #109: ApplicationConfig.application == null

2018-04-15 Thread GitBox
levin950825 opened a new issue #109: ApplicationConfig.application == null URL: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/109 `Using version 2.0.0 error` but `0.1.0 normal` ``` xml ``` ``` F:\Java\jdk1.8.0_65\bin\java

[GitHub] takeseem commented on issue #1599: 两个建议

2018-04-15 Thread GitBox
takeseem commented on issue #1599: 两个建议 URL: https://github.com/apache/incubator-dubbo/issues/1599#issuecomment-381407501 dubbo让我们基本感觉不到rpc的存在:) 如果是一个工程中开发,引入各种XO实际完全没必要,同样通常情况下dubbo也无需定义各种XO,增加开发和运维复杂度。 建议:无非必要不要引入各种XO,通常我们只关注业务模型即可。

[GitHub] zsw12013 commented on issue #109: ApplicationConfig.application == null

2018-04-15 Thread GitBox
zsw12013 commented on issue #109: ApplicationConfig.application == null URL: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/109#issuecomment-381423415 _.._,. ,' `.( We want you! )

Re: [incubator-dubbo.wiki] branch master updated: Do not expose private mail list

2018-04-15 Thread Mark Thomas
On 14/04/18 13:15, hux...@apache.org wrote: > This is an automated email from the ASF dual-hosted git repository. > > huxing pushed a commit to branch master > in repository https://gitbox.apache.org/repos/asf/incubator-dubbo.wiki.git > > > The following commit(s) were added to

[GitHub] mercyblitz closed issue #108: spring-boot 2.x cannot invoke this

2018-04-15 Thread GitBox
mercyblitz closed issue #108: spring-boot 2.x cannot invoke this URL: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/108 This is an automated message from the Apache Git Service. To respond to the

[GitHub] mercyblitz commented on issue #108: spring-boot 2.x cannot invoke this

2018-04-15 Thread GitBox
mercyblitz commented on issue #108: spring-boot 2.x cannot invoke this URL: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/108#issuecomment-381411678 Please take a look at https://github.com/apache/incubator-dubbo-spring-boot-project/tree/0.2.0 , it will be release

[GitHub] zonghaishang opened a new issue #14: Should remove author and change package name

2018-04-15 Thread GitBox
zonghaishang opened a new issue #14: Should remove author and change package name URL: https://github.com/apache/incubator-dubbo-rpc-jsonrpc/issues/14 Should remove author and change package name. This is an automated

Re: [incubator-dubbo.wiki] branch master updated: Do not expose private mail list

2018-04-15 Thread John D. Ament
On Sun, Apr 15, 2018 at 12:13 PM Mark Thomas wrote: > On 14/04/18 13:15, hux...@apache.org wrote: > > This is an automated email from the ASF dual-hosted git repository. > > > > huxing pushed a commit to branch master > > in repository >

[GitHub] jaychang9 commented on issue #195: @Reference check=false不生效

2018-04-15 Thread GitBox
jaychang9 commented on issue #195: @Reference check=false不生效 URL: https://github.com/apache/incubator-dubbo/issues/195#issuecomment-381452137 我是直接搞个spring-dubbo-consumer.xml 用一个DubboConfig Java Config方式引入这个xml `@Configuration @ImportResource(locations =

[GitHub] nmyphp commented on issue #1001: merge dubbox core features from dangdang:

2018-04-15 Thread GitBox
nmyphp commented on issue #1001: merge dubbox core features from dangdang: URL: https://github.com/apache/incubator-dubbo/pull/1001#issuecomment-381447436 @luzhzhsoft可以参考一下这篇CSDN博客:https://blog.csdn.net/nmyphp/article/details/79174225

[GitHub] jaychang9 commented on issue #195: @Reference check=false不生效

2018-04-15 Thread GitBox
jaychang9 commented on issue #195: @Reference check=false不生效 URL: https://github.com/apache/incubator-dubbo/issues/195#issuecomment-381452137 我是直接搞个spring-dubbo-consumer.xml 用一个DubboConfig Java Config方式引入这个xml `@Configuration @ImportResource(locations =

[GitHub] jaychang9 commented on issue #195: @Reference check=false不生效

2018-04-15 Thread GitBox
jaychang9 commented on issue #195: @Reference check=false不生效 URL: https://github.com/apache/incubator-dubbo/issues/195#issuecomment-381452137 我是直接搞个spring-dubbo-consumer.xml 用一个DubboConfig Java Config方式引入这个xml `@Configuration @ImportResource(locations =

Re: How to get Session info using dubbo Filter?

2018-04-15 Thread Huxing Zhang
Hi, Welcome! Could you provide some more details? e.g. Provide a simple test that can help us reproduce your problem, or you can paste your exception stack trace if you have any. 2018-04-11 19:45 GMT+08:00 张卓群 : > 我正在做dubbo的权限认证,现在发现我没有办法在dubbo >

[GitHub] jaychang9 commented on issue #195: @Reference check=false不生效

2018-04-15 Thread GitBox
jaychang9 commented on issue #195: @Reference check=false不生效 URL: https://github.com/apache/incubator-dubbo/issues/195#issuecomment-381452137 我是直接搞个spring-dubbo-consumer.xml 用一个DubboConfig Java Config方式引入这个xml `@Configuration @ImportResource(locations =

[GitHub] zonghaishang commented on issue #1609: incomplete: Fix hessian2 serialized short, byte is converted to int bug (#1232)

2018-04-15 Thread GitBox
zonghaishang commented on issue #1609: incomplete: Fix hessian2 serialized short, byte is converted to int bug (#1232) URL: https://github.com/apache/incubator-dubbo/issues/1609#issuecomment-381457048 The hessian2 protocol has been used by default. Which scenario needs to use hessian1?

Re: [incubator-dubbo.wiki] branch master updated: Do not expose private mail list

2018-04-15 Thread Huxing Zhang
I thought if the private mailing list address goes publicly, it might be abused. Is cc-ing dev@ better than private@? On Mon, Apr 16, 2018 at 12:19 AM, John D. Ament wrote: > On Sun, Apr 15, 2018 at 12:13 PM Mark Thomas wrote: > >> On 14/04/18 13:15,

Re: [Suggestion] PR failing if test coverage went down

2018-04-15 Thread Huxing Zhang
Hi, On Thu, Apr 12, 2018 at 11:07 AM, hty...@gmail.com wrote: > yeah. I understand your concern. > > This is a common requirement for coverage calc service. Codecov support this > feature. > In codecov.yml, we can config threshold value which allow the coverage to > drop by

[GitHub] ralf0131 closed issue #1600: 示例提供者安装链接无法访问404

2018-04-15 Thread GitBox
ralf0131 closed issue #1600: 示例提供者安装链接无法访问404 URL: https://github.com/apache/incubator-dubbo/issues/1600 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the

Re: Unstable test for HessianProtocolTest

2018-04-15 Thread Huxing Zhang
Hi, I can reproduce this issue occasionally on my MacOS 10.13.4 with Java 10. But when I run com.alibaba.dubbo.rpc.protocol.hessian.HessianProtocolTest individually, it is hardly to be reproduced. Not familiar with hessian protocol, no idea what is going on there. On Thu, Apr 12, 2018 at 8:57

[GitHub] nzomkxia commented on issue #1600: 示例提供者安装链接无法访问404

2018-04-15 Thread GitBox
nzomkxia commented on issue #1600: 示例提供者安装链接无法访问404 URL: https://github.com/apache/incubator-dubbo/issues/1600#issuecomment-381463092 the address has been updated This is an automated message from the Apache Git Service. To

[GitHub] zonghaishang commented on issue #1608: fix #210 JavaDeserializer._constructor.newInstance([null, null]) NPE

2018-04-15 Thread GitBox
zonghaishang commented on issue #1608: fix #210 JavaDeserializer._constructor.newInstance([null, null]) NPE URL: https://github.com/apache/incubator-dubbo/pull/1608#issuecomment-381473361 @takeseem 1. constructor(null...) , This is the validation rule of the instance object itself.

[GitHub] kingyoungfan opened a new pull request #1615: Merge pull request #1 from alibaba/master

2018-04-15 Thread GitBox
kingyoungfan opened a new pull request #1615: Merge pull request #1 from alibaba/master URL: https://github.com/apache/incubator-dubbo/pull/1615 update for origin ## What is the purpose of the change X ## Brief changelog XX ## Verifying this change

[GitHub] longXboy opened a new issue #1613: Dubbo有多集群感知、集群容灾切换能力吗?

2018-04-15 Thread GitBox
longXboy opened a new issue #1613: Dubbo有多集群感知、集群容灾切换能力吗? URL: https://github.com/apache/incubator-dubbo/issues/1613 可以像spring cloud里的ribbon或者istio里的envoyproxy那样设置多个集群,然后单个集群不可用了之后自动切换吗? This is an automated message from the

Re: How to get Session info using dubbo Filter?

2018-04-15 Thread 苦逼少侠
You can put user info from HttpServletRequest into Invocation‘s attachment in Consumer Filter. And take out in the Provider filter. 2018-04-16 9:47 GMT+08:00 Huxing Zhang : > Hi, > > Welcome! > > Could you provide some more details? > > e.g. Provide a simple test that can

[GitHub] longXboy commented on issue #1613: Dubbo有多机房集群感知、集群容灾切换能力吗?

2018-04-15 Thread GitBox
longXboy commented on issue #1613: Dubbo有多机房集群感知、集群容灾切换能力吗? URL: https://github.com/apache/incubator-dubbo/issues/1613#issuecomment-381468528 @htynkn thanks a lot! This is an automated message from the Apache Git Service. To

Re: [Suggestion] PR failing if test coverage went down

2018-04-15 Thread shang zonghai
+1 for considering small changes. We need resources to improve existing unit tests and increase unit coverage. Best Regards! yiji

[GitHub] kingyoungfan commented on issue #1615: Merge pull request #1 from alibaba/master

2018-04-15 Thread GitBox
kingyoungfan commented on issue #1615: Merge pull request #1 from alibaba/master URL: https://github.com/apache/incubator-dubbo/pull/1615#issuecomment-381484526 /// This is an automated message from the Apache Git Service. To

Re: [Suggestion] PR failing if test coverage went down

2018-04-15 Thread htynkn
If we just want to make sure we don't reject any document fix or tiny fix. X should be 0.05 If we want to accept some small change, we can consider 0.1 to 0.3 Regards, Yunkun Huang On 2018/04/16 01:36:17, Huxing Zhang wrote: > Hi, > > On Thu, Apr 12, 2018 at 11:07 AM,

[GitHub] htynkn commented on issue #1613: Dubbo有多机房集群感知、集群容灾切换能力吗?

2018-04-15 Thread GitBox
htynkn commented on issue #1613: Dubbo有多机房集群感知、集群容灾切换能力吗? URL: https://github.com/apache/incubator-dubbo/issues/1613#issuecomment-381466657 hey @longXboy Dubbo supports Multiple registries and Service Group which can provide similar feature. Refer to this link

Re: [Suggestion] PR failing if test coverage went down

2018-04-15 Thread Huxing Zhang
+1 for considering small changes. Pull request is welcome! On Mon, Apr 16, 2018 at 10:56 AM, hty...@gmail.com wrote: > If we just want to make sure we don't reject any document fix or tiny fix. X > should be 0.05 > If we want to accept some small change, we can consider 0.1

[GitHub] kingyoungfan opened a new pull request #1614: Merge pull request #1 from alibaba/master

2018-04-15 Thread GitBox
kingyoungfan opened a new pull request #1614: Merge pull request #1 from alibaba/master URL: https://github.com/apache/incubator-dubbo/pull/1614 update for origin ## What is the purpose of the change X ## Brief changelog XX ## Verifying this change

[GitHub] zonghaishang commented on issue #210: dubbo调用报错HessianFieldException

2018-04-15 Thread GitBox
zonghaishang commented on issue #210: dubbo调用报错HessianFieldException URL: https://github.com/apache/incubator-dubbo/issues/210#issuecomment-381475757 @defshine Please provides your org.springframework.jdbc version.

[GitHub] lovepoem commented on issue #1614: Merge pull request #1 from alibaba/master

2018-04-15 Thread GitBox
lovepoem commented on issue #1614: Merge pull request #1 from alibaba/master URL: https://github.com/apache/incubator-dubbo/pull/1614#issuecomment-381478402 No file changed This is an automated message from the Apache Git

[GitHub] lovepoem closed pull request #1614: Merge pull request #1 from alibaba/master

2018-04-15 Thread GitBox
lovepoem closed pull request #1614: Merge pull request #1 from alibaba/master URL: https://github.com/apache/incubator-dubbo/pull/1614 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a