[GitHub] beiwei30 commented on a change in pull request #1575: [dubbo-1521]add java 9 in travis yml
beiwei30 commented on a change in pull request #1575: [dubbo-1521]add java 9 in
travis yml
URL: https://github.com/apache/incubator-dubbo/pull/1575#discussion_r180301153
##
File path:
dubbo-common/src/main/java/com/alibaba/dubbo/common/utils/ReflectUtils.java
##
@@ -910,6 +910,9 @@ private static Object getEmptyObject(Class returnType,
Map, Object>
while (cls != null && cls != Object.class) {
Field[] fields = cls.getDeclaredFields();
for (Field field : fields) {
+if (field.isSynthetic()) {
Review comment:
sounds reasonable
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] beiwei30 commented on a change in pull request #1575: [dubbo-1521]add java 9 in travis yml
beiwei30 commented on a change in pull request #1575: [dubbo-1521]add java 9 in
travis yml
URL: https://github.com/apache/incubator-dubbo/pull/1575#discussion_r180290615
##
File path:
dubbo-common/src/main/java/com/alibaba/dubbo/common/utils/ReflectUtils.java
##
@@ -910,6 +910,9 @@ private static Object getEmptyObject(Class returnType,
Map, Object>
while (cls != null && cls != Object.class) {
Field[] fields = cls.getDeclaredFields();
for (Field field : fields) {
+if (field.isSynthetic()) {
Review comment:
is it necessary to include this change?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
