[GitHub] codecov-io commented on issue #1550: [Dubbo-Fix EnableDubbo annotation bug]

2018-04-05 Thread GitBox
codecov-io commented on issue #1550: [Dubbo-Fix EnableDubbo annotation bug]
URL: https://github.com/apache/incubator-dubbo/pull/1550#issuecomment-378873985
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1550?src=pr&el=h1) 
Report
   > Merging 
[#1550](https://codecov.io/gh/apache/incubator-dubbo/pull/1550?src=pr&el=desc) 
into 
[master](https://codecov.io/gh/apache/incubator-dubbo/commit/c7b0c695e7b5abb6534cecb89c0caf762f0f06b0?src=pr&el=desc)
 will **increase** coverage by `0.64%`.
   > The diff coverage is `81.81%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-dubbo/pull/1550/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0)](https://codecov.io/gh/apache/incubator-dubbo/pull/1550?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#1550  +/-   ##
   ==
   + Coverage   31.59%   32.24%   +0.64% 
   ==
 Files 682  682  
 Lines   3304833134  +86 
 Branches 6597 6617  +20 
   ==
   + Hits1044210683 +241 
   + Misses  2074720549 -198 
   - Partials 1859 1902  +43
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1550?src=pr&el=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[.../dubbo/examples/annotation/AnnotationConsumer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1550/diff?src=pr&el=tree#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWV4YW1wbGVzL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vZXhhbXBsZXMvYW5ub3RhdGlvbi9Bbm5vdGF0aW9uQ29uc3VtZXIuamF2YQ==)
 | `0% <ø> (ø)` | :arrow_up: |
   | 
[.../java/com/alibaba/dubbo/config/AbstractConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1550/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvQWJzdHJhY3RDb25maWcuamF2YQ==)
 | `38.02% <ø> (ø)` | :arrow_up: |
   | 
[.../dubbo/examples/annotation/AnnotationProvider.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1550/diff?src=pr&el=tree#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWV4YW1wbGVzL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vZXhhbXBsZXMvYW5ub3RhdGlvbi9Bbm5vdGF0aW9uUHJvdmlkZXIuamF2YQ==)
 | `0% <0%> (ø)` | :arrow_up: |
   | 
[...nnotation/DubboClassPathBeanDefinitionScanner.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1550/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvc3ByaW5nL2NvbnRleHQvYW5ub3RhdGlvbi9EdWJib0NsYXNzUGF0aEJlYW5EZWZpbml0aW9uU2Nhbm5lci5qYXZh)
 | `100% <100%> (ø)` | :arrow_up: |
   | 
[...java/com/alibaba/dubbo/config/ReferenceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1550/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvUmVmZXJlbmNlQ29uZmlnLmphdmE=)
 | `47.08% <100%> (ø)` | :arrow_up: |
   | 
[...n/java/com/alibaba/dubbo/config/ServiceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1550/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvU2VydmljZUNvbmZpZy5qYXZh)
 | `39.43% <100%> (ø)` | :arrow_up: |
   | 
[...a/com/alibaba/dubbo/config/spring/ServiceBean.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1550/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvc3ByaW5nL1NlcnZpY2VCZWFuLmphdmE=)
 | `29.71% <100%> (+0.51%)` | :arrow_up: |
   | 
[...com/alibaba/dubbo/config/spring/ReferenceBean.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1550/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvc3ByaW5nL1JlZmVyZW5jZUJlYW4uamF2YQ==)
 | `36.93% <70%> (+11.01%)` | :arrow_up: |
   | 
[...notation/ReferenceAnnotationBeanPostProcessor.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1550/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvc3ByaW5nL2JlYW5zL2ZhY3RvcnkvYW5ub3RhdGlvbi9SZWZlcmVuY2VBbm5vdGF0aW9uQmVhblBvc3RQcm9jZXNzb3IuamF2YQ==)
 | `75.36% <79.16%> (+1.59%)` | :arrow_up: |
   | 
[...annotation/ServiceAnnotationBeanPostProcessor.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1550/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvc3ByaW5nL2JlYW5zL2ZhY3RvcnkvYW5ub3RhdGlvbi9TZXJ2aWNlQW5ub3RhdGlvbkJlYW5Qb3N0UHJvY2Vzc29yLmphdmE=)
 | `86.54% <92.3%> (+1.7%)` | :arrow_up: |
   | ... and [18 
more](https://codecov.io/gh/apache/incubator-dubbo/pull/1550/diff?src=pr&el=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-dubbo

[GitHub] codecov-io commented on issue #1550: [Dubbo-Fix EnableDubbo annotation bug]

2018-04-05 Thread GitBox
codecov-io commented on issue #1550: [Dubbo-Fix EnableDubbo annotation bug]
URL: https://github.com/apache/incubator-dubbo/pull/1550#issuecomment-378873985
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1550?src=pr&el=h1) 
Report
   > Merging 
[#1550](https://codecov.io/gh/apache/incubator-dubbo/pull/1550?src=pr&el=desc) 
into 
[master](https://codecov.io/gh/apache/incubator-dubbo/commit/c7b0c695e7b5abb6534cecb89c0caf762f0f06b0?src=pr&el=desc)
 will **increase** coverage by `0.65%`.
   > The diff coverage is `79.31%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-dubbo/pull/1550/graphs/tree.svg?height=150&width=650&token=VnEIkiFQT0&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/1550?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#1550  +/-   ##
   ==
   + Coverage   31.59%   32.25%   +0.65% 
   ==
 Files 682  682  
 Lines   3304833122  +74 
 Branches 6597 6616  +19 
   ==
   + Hits1044210682 +240 
   + Misses  2074720539 -208 
   - Partials 1859 1901  +42
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1550?src=pr&el=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[.../dubbo/examples/annotation/AnnotationConsumer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1550/diff?src=pr&el=tree#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWV4YW1wbGVzL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vZXhhbXBsZXMvYW5ub3RhdGlvbi9Bbm5vdGF0aW9uQ29uc3VtZXIuamF2YQ==)
 | `0% <ø> (ø)` | :arrow_up: |
   | 
[.../java/com/alibaba/dubbo/config/AbstractConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1550/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvQWJzdHJhY3RDb25maWcuamF2YQ==)
 | `38.02% <ø> (ø)` | :arrow_up: |
   | 
[.../dubbo/examples/annotation/AnnotationProvider.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1550/diff?src=pr&el=tree#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWV4YW1wbGVzL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vZXhhbXBsZXMvYW5ub3RhdGlvbi9Bbm5vdGF0aW9uUHJvdmlkZXIuamF2YQ==)
 | `0% <0%> (ø)` | :arrow_up: |
   | 
[...n/java/com/alibaba/dubbo/config/ServiceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1550/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvU2VydmljZUNvbmZpZy5qYXZh)
 | `39.43% <100%> (ø)` | :arrow_up: |
   | 
[...java/com/alibaba/dubbo/config/ReferenceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1550/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvUmVmZXJlbmNlQ29uZmlnLmphdmE=)
 | `47.08% <100%> (ø)` | :arrow_up: |
   | 
[...nnotation/DubboClassPathBeanDefinitionScanner.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1550/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvc3ByaW5nL2NvbnRleHQvYW5ub3RhdGlvbi9EdWJib0NsYXNzUGF0aEJlYW5EZWZpbml0aW9uU2Nhbm5lci5qYXZh)
 | `100% <100%> (ø)` | :arrow_up: |
   | 
[...a/com/alibaba/dubbo/config/spring/ServiceBean.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1550/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvc3ByaW5nL1NlcnZpY2VCZWFuLmphdmE=)
 | `29.71% <100%> (+0.51%)` | :arrow_up: |
   | 
[...com/alibaba/dubbo/config/spring/ReferenceBean.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1550/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvc3ByaW5nL1JlZmVyZW5jZUJlYW4uamF2YQ==)
 | `36.93% <70%> (+11.01%)` | :arrow_up: |
   | 
[...notation/ReferenceAnnotationBeanPostProcessor.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1550/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvc3ByaW5nL2JlYW5zL2ZhY3RvcnkvYW5ub3RhdGlvbi9SZWZlcmVuY2VBbm5vdGF0aW9uQmVhblBvc3RQcm9jZXNzb3IuamF2YQ==)
 | `75.36% <79.16%> (+1.59%)` | :arrow_up: |
   | 
[...annotation/ServiceAnnotationBeanPostProcessor.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1550/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvc3ByaW5nL2JlYW5zL2ZhY3RvcnkvYW5ub3RhdGlvbi9TZXJ2aWNlQW5ub3RhdGlvbkJlYW5Qb3N0UHJvY2Vzc29yLmphdmE=)
 | `85.53% <88.88%> (+0.68%)` | :arrow_up: |
   | ... and [16 
more](https://codecov.io/gh/apache/incubator-dubbo/pull/1550/diff?src=pr&el=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-dub

[GitHub] codecov-io commented on issue #1550: [Dubbo-Fix EnableDubbo annotation bug]

2018-04-05 Thread GitBox
codecov-io commented on issue #1550: [Dubbo-Fix EnableDubbo annotation bug]
URL: https://github.com/apache/incubator-dubbo/pull/1550#issuecomment-378873985
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1550?src=pr&el=h1) 
Report
   > Merging 
[#1550](https://codecov.io/gh/apache/incubator-dubbo/pull/1550?src=pr&el=desc) 
into 
[master](https://codecov.io/gh/apache/incubator-dubbo/commit/c7b0c695e7b5abb6534cecb89c0caf762f0f06b0?src=pr&el=desc)
 will **increase** coverage by `0.65%`.
   > The diff coverage is `79.31%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-dubbo/pull/1550/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0)](https://codecov.io/gh/apache/incubator-dubbo/pull/1550?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#1550  +/-   ##
   ==
   + Coverage   31.59%   32.25%   +0.65% 
   ==
 Files 682  682  
 Lines   3304833122  +74 
 Branches 6597 6616  +19 
   ==
   + Hits1044210682 +240 
   + Misses  2074720539 -208 
   - Partials 1859 1901  +42
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1550?src=pr&el=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[.../dubbo/examples/annotation/AnnotationConsumer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1550/diff?src=pr&el=tree#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWV4YW1wbGVzL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vZXhhbXBsZXMvYW5ub3RhdGlvbi9Bbm5vdGF0aW9uQ29uc3VtZXIuamF2YQ==)
 | `0% <ø> (ø)` | :arrow_up: |
   | 
[.../java/com/alibaba/dubbo/config/AbstractConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1550/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvQWJzdHJhY3RDb25maWcuamF2YQ==)
 | `38.02% <ø> (ø)` | :arrow_up: |
   | 
[.../dubbo/examples/annotation/AnnotationProvider.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1550/diff?src=pr&el=tree#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWV4YW1wbGVzL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vZXhhbXBsZXMvYW5ub3RhdGlvbi9Bbm5vdGF0aW9uUHJvdmlkZXIuamF2YQ==)
 | `0% <0%> (ø)` | :arrow_up: |
   | 
[...nnotation/DubboClassPathBeanDefinitionScanner.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1550/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvc3ByaW5nL2NvbnRleHQvYW5ub3RhdGlvbi9EdWJib0NsYXNzUGF0aEJlYW5EZWZpbml0aW9uU2Nhbm5lci5qYXZh)
 | `100% <100%> (ø)` | :arrow_up: |
   | 
[...java/com/alibaba/dubbo/config/ReferenceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1550/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvUmVmZXJlbmNlQ29uZmlnLmphdmE=)
 | `47.08% <100%> (ø)` | :arrow_up: |
   | 
[...n/java/com/alibaba/dubbo/config/ServiceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1550/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvU2VydmljZUNvbmZpZy5qYXZh)
 | `39.43% <100%> (ø)` | :arrow_up: |
   | 
[...a/com/alibaba/dubbo/config/spring/ServiceBean.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1550/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvc3ByaW5nL1NlcnZpY2VCZWFuLmphdmE=)
 | `29.71% <100%> (+0.51%)` | :arrow_up: |
   | 
[...com/alibaba/dubbo/config/spring/ReferenceBean.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1550/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvc3ByaW5nL1JlZmVyZW5jZUJlYW4uamF2YQ==)
 | `36.93% <70%> (+11.01%)` | :arrow_up: |
   | 
[...notation/ReferenceAnnotationBeanPostProcessor.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1550/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvc3ByaW5nL2JlYW5zL2ZhY3RvcnkvYW5ub3RhdGlvbi9SZWZlcmVuY2VBbm5vdGF0aW9uQmVhblBvc3RQcm9jZXNzb3IuamF2YQ==)
 | `75.36% <79.16%> (+1.59%)` | :arrow_up: |
   | 
[...annotation/ServiceAnnotationBeanPostProcessor.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1550/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvc3ByaW5nL2JlYW5zL2ZhY3RvcnkvYW5ub3RhdGlvbi9TZXJ2aWNlQW5ub3RhdGlvbkJlYW5Qb3N0UHJvY2Vzc29yLmphdmE=)
 | `85.53% <88.88%> (+0.68%)` | :arrow_up: |
   | ... and [16 
more](https://codecov.io/gh/apache/incubator-dubbo/pull/1550/diff?src=pr&el=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-dub