[GitHub] cvictory commented on issue #1444: [Dubbo-RpcContext] Simplify check consumer side in RpcContext

2018-04-10 Thread GitBox 
cvictory commented on issue #1444: [Dubbo-RpcContext] Simplify check consumer 
side in RpcContext
URL: https://github.com/apache/incubator-dubbo/pull/1444#issuecomment-380060334
 
 
   Usually the commit is right. 
   
   Is there some special situation happened？


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] cvictory commented on issue #1444: [Dubbo-RpcContext] Simplify check consumer side in RpcContext

2018-04-07 Thread GitBox 
cvictory commented on issue #1444: [Dubbo-RpcContext] Simplify check consumer 
side in RpcContext
URL: https://github.com/apache/incubator-dubbo/pull/1444#issuecomment-379515681
 
 
   where is the usage of isProviderSide and isConsumerSide?
   I cannot judge whether it is right.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services