[GitHub] ma-xiao-guang-64 commented on issue #1426: fix isShutdown always return true

2018-04-23 Thread GitBox 
ma-xiao-guang-64 commented on issue #1426: fix isShutdown always return true
URL: https://github.com/apache/incubator-dubbo/pull/1426#issuecomment-383573814
 
 
   @ralf0131 
   我用中文表述一下
   当调用-ExecutorService的shutdown方法之后无论ExecutorService是否关闭再次调用shutdown都会返回true。
   有段代码`if (!isShutdown(es)) {
   newThreadToCloseExecutor(es);
   }`其条件永远都返回false，也就是说下面的关闭线程并不会启动
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ma-xiao-guang-64 commented on issue #1426: fix isShutdown always return true

2018-04-08 Thread GitBox 
ma-xiao-guang-64 commented on issue #1426: fix isShutdown always return true
URL: https://github.com/apache/incubator-dubbo/pull/1426#issuecomment-379527985
 
 
   @cvictory 
   if (!isShutdown(es)) {
   newThreadToCloseExecutor(es);
   }
   please confirm this, !isShutdown(es) is always false, 
newThreadToCloseExecutor can't run.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ma-xiao-guang-64 commented on issue #1426: fix isShutdown always return true

2018-04-08 Thread GitBox 
ma-xiao-guang-64 commented on issue #1426: fix isShutdown always return true
URL: https://github.com/apache/incubator-dubbo/pull/1426#issuecomment-379527985
 
 
   @cvictory 
   No, isShutdown() will always return true when you invoke shutdown() or 
shutdownNow().
   please confirm this, newThreadToCloseExecutor always can't invoke thank you
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ma-xiao-guang-64 commented on issue #1426: fix isShutdown always return true

2018-04-08 Thread GitBox 
ma-xiao-guang-64 commented on issue #1426: fix isShutdown always return true
URL: https://github.com/apache/incubator-dubbo/pull/1426#issuecomment-379527985
 
 
   @cvictory 
   No, isShutdown() will always return true when you invoke shutdown() or 
shutdownNow().
   please confirm this, thank you
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services