[GitHub] takeseem commented on issue #1608: fix #210 JavaDeserializer._constructor.newInstance([null, null]) NPE
takeseem commented on issue #1608: fix #210 JavaDeserializer._constructor.newInstance([null, null]) NPE URL: https://github.com/apache/incubator-dubbo/pull/1608#issuecomment-381570303 既然AbstracthessianInput增加了方法，为什么heassian2能兼容和heassian1就不支持？ 1. The new abstract method I added did not implement in Hessian1 by default, you should not reuse my hessian2 unit test to verify hessian1. 虽然是开源项目，假设客户已经在生产中使用hessian1，这对客户来说升级版本将是灾难。 所以我说不严谨 2. Does it need to support hessian1, maybe I will support later today. 点赞 3. #210 is inconsistent with the given line number, perhaps due to the version used by the spring-jdbc framework 我会根据git的show revision information找到有用的信息，但#210 案例最新代码依然能定位并重现问题。 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] takeseem commented on issue #1608: fix #210 JavaDeserializer._constructor.newInstance([null, null]) NPE
takeseem commented on issue #1608: fix #210 JavaDeserializer._constructor.newInstance([null, null]) NPE URL: https://github.com/apache/incubator-dubbo/pull/1608#issuecomment-381494126 @zonghaishang 但是用 #1232 提交之前的代码，是工作很好的。既然AbstracthessianInput增加了方法，为什么heassian2能兼容和heassian1就不支持？这本身会导致所有的hessian1协议在#1232之后不再得到支持。 当然我也可以如你所说，去掉hessian1的junit以保证测试用例ok。 HessianInput.inistant()方法本意是构造一个对象而已。但是类创建者不知道会传入一个null。 “Please provide the full jar package that has this exception： dubbo org.springframework.jdbc.UncategorizedSQLException” 你需要的信息如下： - 我提交的代码就明确了依赖哪个dubbo - 1楼UncategorizedSQLException本身链接spring的源码 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] takeseem commented on issue #1608: fix #210 JavaDeserializer._constructor.newInstance([null, null]) NPE
takeseem commented on issue #1608: fix #210 JavaDeserializer._constructor.newInstance([null, null]) NPE URL: https://github.com/apache/incubator-dubbo/pull/1608#issuecomment-381494126 @zonghaishang 但是用 #1232 提交之前的代码，是工作很好的。既然AbstracthessianInput增加了方法，为什么heassian2能兼容和heassian1就不支持？这本身会导致所有的hessian1协议在#1232之后不再得到支持。 当然我也可以如你所说，去掉hessian1的junit以保证测试用例ok。 HessianInput.inistant()方法本意是构造一个对象而已。但是类创建者不知道会传入一个null。 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] takeseem commented on issue #1608: fix #210 JavaDeserializer._constructor.newInstance([null, null]) NPE
takeseem commented on issue #1608: fix #210 JavaDeserializer._constructor.newInstance([null, null]) NPE URL: https://github.com/apache/incubator-dubbo/pull/1608#issuecomment-381494126 @zonghaishang 但是用 #1232 提交之前的代码，是工作很好的。既然AbstracthessianInput增加了方法，为什么heassian2能兼容和heassian1就不支持？这本身会导致所有的hessian1协议在#1232之后不再得到支持 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] takeseem commented on issue #1608: fix #210 JavaDeserializer._constructor.newInstance([null, null]) NPE
takeseem commented on issue #1608: fix #210 JavaDeserializer._constructor.newInstance([null, null]) NPE URL: https://github.com/apache/incubator-dubbo/pull/1608#issuecomment-381375860 @lovepoem @zonghaishang #1232 HessianInput.readObject(Class, Class[]) nosupported 因为我对Hessian不熟，#1232 需要覆盖测试Hessian1的，看代码#1232 只支持Hessian2 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] takeseem commented on issue #1608: fix #210 JavaDeserializer._constructor.newInstance([null, null]) NPE
takeseem commented on issue #1608: fix #210 JavaDeserializer._constructor.newInstance([null, null]) NPE URL: https://github.com/apache/incubator-dubbo/pull/1608#issuecomment-381375860 @lovepoem @zonghaishang #1232 HessianInput.readObject(Class, Class[]) nosupported 因为我对Hessian不熟，#1232 需要覆盖测试Hessian1的，看代码#1232 只支持Hessian2 I will comment the hessian1 junit to pass the test. If you fix the bug then to uncomment. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] takeseem commented on issue #1608: fix #210 JavaDeserializer._constructor.newInstance([null, null]) NPE
takeseem commented on issue #1608: fix #210 JavaDeserializer._constructor.newInstance([null, null]) NPE URL: https://github.com/apache/incubator-dubbo/pull/1608#issuecomment-381375860 @lovepoem @zonghaishang #1232 HessianInput.readObject(Class, Class[]) nosupported 因为我对Hessian不熟，#1232 需要覆盖测试Hessian1的，看代码#1232 只支持Hessian2 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] takeseem commented on issue #1608: fix #210 JavaDeserializer._constructor.newInstance([null, null]) NPE
takeseem commented on issue #1608: fix #210 JavaDeserializer._constructor.newInstance([null, null]) NPE URL: https://github.com/apache/incubator-dubbo/pull/1608#issuecomment-381375860 #1232 HessianInput.readObject(Class, Class[]) nosupported 因为我对Hessian不熟，#1232 需要覆盖测试Hessian1的，看代码#1232 只支持Hessian2 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
