Re: Consumer side Validation SPI is wrongly activated while setting validation=true for provider

2018-03-08 Thread kext gmail
Yes, disable default, set by user for requirement. > 在 2018年3月8日,16:23,jun liu 写道: > > I prefer to change the current behavior, consumer side should not be affected > in this case, if someone care about performance, they can add validation on > consumer side explicitly. > > Other opinions? >

Re: Consumer side Validation SPI is wrongly activated while setting validation=true for provider

2018-03-08 Thread Jun Liu
No more suggestions til now, let me track this with a github issue. Further questions is welcomed in here and github issue. https://github.com/alibaba/dubbo/issues/1386 > On 8 Mar 2018, at 4:23 PM, jun liu wrote: > > I prefer to change the current behavior, consumer side should not be affecte

Re: Consumer side Validation SPI is wrongly activated while setting validation=true for provider

2018-03-08 Thread jun liu
I prefer to change the current behavior, consumer side should not be affected in this case, if someone care about performance, they can add validation on consumer side explicitly. Other opinions? > On 7 Mar 2018, at 3:47 PM, Sunshow wrote: > > Yes, that's my problem. > > from the document,

Re: Consumer side Validation SPI is wrongly activated while setting validation=true for provider

2018-03-06 Thread Sunshow
Yes, that's my problem. from the document, consumer can enable or disable validation itself. On Wed, Mar 7, 2018 at 3:41 PM jun liu wrote: > Hi Sunshow, Ian > > I think i have reproduced this problem, the key point is: When we switch > param validation on on provider side, all consumer projects

Re: Consumer side Validation SPI is wrongly activated while setting validation=true for provider

2018-03-06 Thread jun liu
Hi Sunshow, Ian I think i have reproduced this problem, the key point is: When we switch param validation on on provider side, all consumer projects need to add necessary dependencies explicitly (param validation was force opened on consumer side). This means provider and consumer are bind toge

Re: Consumer side Validation SPI is wrongly activated while setting validation=true for provider

2018-03-06 Thread Ian Luo
Hi Sunshow, Could you pls. attach a test case to reproduce the issue you described here? I'd like to further investigate once I receive the reproducer. Thanks, -Ian. On Wed, Mar 7, 2018 at 2:14 PM, Sunshow wrote: > ATT. > > this case consumer leads to throw > > Caused by: java.lang.NoClassDef

Consumer side Validation SPI is wrongly activated while setting validation=true for provider

2018-03-06 Thread Sunshow
ATT. this case consumer leads to throw Caused by: java.lang.NoClassDefFoundError: javax/validation/Validation even while calling no validation method, unless add all validation dependencies to consumer, that's not awesome, consumer side check should be activated by consumer self. one more ques