Re: Wanted to assist dubbo community on issue #2884

Thanks a lot, appreciate it. On Tue, Dec 11, 2018 at 7:03 AM Huxing Zhang wrote: > Hi, > > On Tue, Dec 11, 2018 at 3:04 AM Imteyaz Khan > wrote: > > > > Created an documentation an #2935 > > issue (Creating > > dubbo dubbo-rpc-api java

Re: Wanted to assist dubbo community on issue #2884

Hi, On Tue, Dec 11, 2018 at 3:04 AM Imteyaz Khan wrote: > > Created an documentation an #2935 > issue (Creating > dubbo dubbo-rpc-api java documentation) and will be on it, could someone > tag or assigned it to me. I've assigned it to you

Re: Wanted to assist dubbo community on issue #2884

Created an documentation an #2935 issue (Creating dubbo dubbo-rpc-api java documentation) and will be on it, could someone tag or assigned it to me. Regards Imteyaz On Sat, Dec 8, 2018 at 7:19 PM Huxing Zhang wrote: > Hi Imteyaz, > > On

Re: Wanted to assist dubbo community on issue #2884

Hi Imteyaz, On Fri, Dec 7, 2018 at 9:30 PM Imteyaz Khan wrote: > > Hi All, > I have created the pull > request for github > issue 2884 (which is getting used in the email thread). This PR is for > dubbo-filter modules (dubbo-filter-cache and

Re: Wanted to assist dubbo community on issue #2884

Hi All, I have created the pull request for github issue 2884 (which is getting used in the email thread). This PR is for dubbo-filter modules (dubbo-filter-cache and dubbo-filter-validation). While this is in PR is in review state I will take

Re: Wanted to assist dubbo community on issue #2884

Ian, Thanks for guiding me. I am on it. Regards Imteyaz On 6 Dec 2018 11:49 a.m., "Ian Luo" wrote: Hi Khan, Feel free to start from any module to enhance the existing JavaDoc and comments, and submit the pull request when you feel it's ready. I am so glad that there's native speaker willing

Re: Wanted to assist dubbo community on issue #2884

Hi Khan, Feel free to start from any module to enhance the existing JavaDoc and comments, and submit the pull request when you feel it's ready. I am so glad that there's native speaker willing to join this effort :) Thanks, -Ian. On Thu, Dec 6, 2018 at 4:14 AM Imteyaz Khan wrote: > I have

Re: Wanted to assist dubbo community on issue #2884

Hi, I think you can start submitting pr. Some formats in the mail are not displayed neatly. A better way is to look at the specific effects in the code after submitting the PR. Great start. :) Huxing Zhang 于2018年12月6日周四 上午10:07写道： > Hi, > > On Thu, Dec 6, 2018 at 4:14 AM Imteyaz Khan >

Re: Wanted to assist dubbo community on issue #2884

Hi, On Thu, Dec 6, 2018 at 4:14 AM Imteyaz Khan wrote: > > I have just started documenting module 'dubbo-filter', below are example > of mine, this is just to make sure I am in align with the documentation > style Looks good! Please go head and send the pull request! > > /** > * CacheFilter

Re: Wanted to assist dubbo community on issue #2884

I mean all of the impl of Filter. Some of are not in dubbo-filter module. U can directly find all of the Filter impl Imteyaz Khan 于2018年12月5日周三 下午10:51写道： > Just to make sure I have not misunderstood what mentioned earlier by > 'Filter' is 'dubbo-filter' correct? > > On Wed, Dec 5, 2018 at 7:00

Re: Wanted to assist dubbo community on issue #2884

I have just started documenting module 'dubbo-filter', below are example of mine, this is just to make sure I am in align with the documentation style /** * CacheFilter is a core component of dubbo.Enabling cache key of service,method,consumer or provider dubbo will cache method return value.

Re: Wanted to assist dubbo community on issue #2884

Just to make sure I have not misunderstood what mentioned earlier by 'Filter' is 'dubbo-filter' correct? On Wed, Dec 5, 2018 at 7:00 PM Imteyaz Khan wrote: > Thanks a lot for the start, much appreciated. > > > > On Wed, Dec 5, 2018 at 6:31 PM yuhang xiu wrote: > >> In addition, we strongly

Re: Wanted to assist dubbo community on issue #2884

Thanks a lot for the start, much appreciated. On Wed, Dec 5, 2018 at 6:31 PM yuhang xiu wrote: > In addition, we strongly encourage open discussion. > You can post your comments on a Filter directly here. There will be some > people who know more about dubbo to review and discuss. > > Of

Re: Wanted to assist dubbo community on issue #2884

In addition, we strongly encourage open discussion. You can post your comments on a Filter directly here. There will be some people who know more about dubbo to review and discuss. Of course, any problem can be raised here. We will answer as soon as possible. yuhang xiu 于2018年12月5日周三 下午8:58写道：

Re: Wanted to assist dubbo community on issue #2884

very sorry. I have some work now, so I didn't respond to your email in time. I am very willing to help you with the completion of the comments. If you are a newbie, I suggest you start with a simple logic. Which parts of the logic are relatively simple? At present, I think that our filter-related