Github user asfgit closed the pull request at:
https://github.com/apache/incubator-eagle/pull/436
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
Github user haoch commented on a diff in the pull request:
https://github.com/apache/incubator-eagle/pull/436#discussion_r79298913
--- Diff: eagle-core/eagle-metadata/eagle-metadata-jdbc/pom.xml ---
@@ -39,10 +39,6 @@
commons-dbcp
-
Github user haoch commented on a diff in the pull request:
https://github.com/apache/incubator-eagle/pull/436#discussion_r79298934
--- Diff: eagle-server-assembly/src/main/conf/server.yml ---
@@ -13,13 +13,25 @@
# See the License for the specific language governing permissions
Github user haoch commented on a diff in the pull request:
https://github.com/apache/incubator-eagle/pull/436#discussion_r79298902
--- Diff:
eagle-core/eagle-app/eagle-app-base/src/main/java/org/apache/eagle/app/service/impl/ApplicationProviderServiceImpl.java
---
@@ -103,8 +103,8
Github user haoch commented on a diff in the pull request:
https://github.com/apache/incubator-eagle/pull/436#discussion_r79298908
--- Diff:
eagle-core/eagle-app/eagle-app-base/src/main/java/org/apache/eagle/app/spi/ApplicationXMLDescriptorLoader.java
---
@@ -48,7 +48,7 @@ private
Github user haoch commented on a diff in the pull request:
https://github.com/apache/incubator-eagle/pull/436#discussion_r79298890
--- Diff:
eagle-core/eagle-app/eagle-app-base/src/main/java/org/apache/eagle/app/service/impl/ApplicationProviderSPILoader.java
---
@@ -82,9 +82,15 @@
GitHub user haoch opened a pull request:
https://github.com/apache/incubator-eagle/pull/436
EAGLE-543 Fix eagle server default config, fix eagle server deve dependency
https://issues.apache.org/jira/browse/EAGLE-543
You can merge this pull request into a Git repository by running: