[GitHub] incubator-eagle pull request #498: EAGLE-614: NPE in DynamicPolicyLoader

2016-10-13 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/incubator-eagle/pull/498


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-eagle pull request #498: EAGLE-614: NPE in DynamicPolicyLoader

2016-10-12 Thread mizeng
GitHub user mizeng opened a pull request:

https://github.com/apache/incubator-eagle/pull/498

EAGLE-614: NPE in DynamicPolicyLoader

Find exception as below:
INFO [2016-10-13 01:15:02,965] 
org.apache.eagle.alert.coordinator.trigger.DynamicPolicyLoader: policies loader 
start.
INFO [2016-10-13 01:15:02,966] 
org.apache.eagle.alert.service.MetadataServiceClientImpl: query URL 
http://localhost:8080/rest/metadata/policies
ERROR [2016-10-13 01:15:02,972] 
org.apache.eagle.alert.coordinator.trigger.DynamicPolicyLoader: error loading 
policy, but continue to run
! java.lang.NullPointerException: null
! at 
org.apache.eagle.alert.engine.coordinator.PolicyDefinition.equals(PolicyDefinition.java:150)
 ~[alert-service-0.5.0-incubating-SNAPSHOT-shaded.jar
:0.5.0-incubating-SNAPSHOT]
! at 
org.apache.eagle.alert.coordinator.trigger.DynamicPolicyLoader.run(DynamicPolicyLoader.java:69)
 ~[alert-service-0.5.0-incubating-SNAPSHOT-shaded.
jar:0.5.0-incubating-SNAPSHOT]
! at 
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) 
[na:1.8.0_102]
! at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308) 
[na:1.8.0_102]
! at 
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
 [na:1.8.0_102]
! at 
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
 [na:1.8.0_102]
! at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) 
[na:1.8.0_102]
! at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) 
[na:1.8.0_102]
! at java.lang.Thread.run(Thread.java:745) [na:1.8.0_102]
we have compare null with other object which should be avoided.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mizeng/incubator-eagle EAGLE-614

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-eagle/pull/498.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #498


commit abe54782c2dbd840864f02bc57ea1659ec6672bc
Author: mizeng 
Date:   2016-10-13T01:41:15Z

EAGLE-614: NPE in DynamicPolicyLoader




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---