[jira] [Commented] (EAGLE-510) Refactor HDFS audit log parser
[ https://issues.apache.org/jira/browse/EAGLE-510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15508601#comment-15508601 ] ASF GitHub Bot commented on EAGLE-510: -- Github user asfgit closed the pull request at: https://github.com/apache/incubator-eagle/pull/403 > Refactor HDFS audit log parser > -- > > Key: EAGLE-510 > URL: https://issues.apache.org/jira/browse/EAGLE-510 > Project: Eagle > Issue Type: Improvement >Reporter: Peter Kim >Priority: Minor > > The current HDFS audit log parser can be refactored by leveraging regex > instead of the substring methods it uses. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (EAGLE-510) Refactor HDFS audit log parser
[ https://issues.apache.org/jira/browse/EAGLE-510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15449634#comment-15449634 ] ASF GitHub Bot commented on EAGLE-510: -- Github user yonzhang commented on the issue: https://github.com/apache/incubator-eagle/pull/403 sure, we can remove that method > Refactor HDFS audit log parser > -- > > Key: EAGLE-510 > URL: https://issues.apache.org/jira/browse/EAGLE-510 > Project: Eagle > Issue Type: Improvement >Reporter: Peter Kim >Priority: Minor > > The current HDFS audit log parser can be refactored by leveraging regex > instead of the substring methods it uses. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (EAGLE-510) Refactor HDFS audit log parser
[ https://issues.apache.org/jira/browse/EAGLE-510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15449628#comment-15449628 ] ASF GitHub Bot commented on EAGLE-510: -- Github user peterkim95 commented on the issue: https://github.com/apache/incubator-eagle/pull/403 I see, can we can still refactor by removing the unused method parseUser > Refactor HDFS audit log parser > -- > > Key: EAGLE-510 > URL: https://issues.apache.org/jira/browse/EAGLE-510 > Project: Eagle > Issue Type: Improvement >Reporter: Peter Kim >Priority: Minor > > The current HDFS audit log parser can be refactored by leveraging regex > instead of the substring methods it uses. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (EAGLE-510) Refactor HDFS audit log parser
[ https://issues.apache.org/jira/browse/EAGLE-510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15449597#comment-15449597 ] ASF GitHub Bot commented on EAGLE-510: -- Github user yonzhang commented on the issue: https://github.com/apache/incubator-eagle/pull/403 We may not change the code to use regex matching as it is too slow. We have achieved more than 10 times performance gain by using string operations than using regex. This is critical important as in production we have the issue with large amount of audit log and regex significantly make performance worse > Refactor HDFS audit log parser > -- > > Key: EAGLE-510 > URL: https://issues.apache.org/jira/browse/EAGLE-510 > Project: Eagle > Issue Type: Improvement >Reporter: Peter Kim >Priority: Minor > > The current HDFS audit log parser can be refactored by leveraging regex > instead of the substring methods it uses. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (EAGLE-510) Refactor HDFS audit log parser
[ https://issues.apache.org/jira/browse/EAGLE-510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15447243#comment-15447243 ] ASF GitHub Bot commented on EAGLE-510: -- GitHub user peterkim95 opened a pull request: https://github.com/apache/incubator-eagle/pull/403 EAGLE-510: Refactor HDFS audit log parser https://issues.apache.org/jira/browse/EAGLE-510 You can merge this pull request into a Git repository by running: $ git pull https://github.com/peterkim95/incubator-eagle hdfslogparse Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-eagle/pull/403.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #403 commit b73307585bf1089e5090c30ae1ed623ce98727f7 Author: Peter Kim Date: 2016-08-29T22:17:37Z rewrite hdfs log parsing logic with regex > Refactor HDFS audit log parser > -- > > Key: EAGLE-510 > URL: https://issues.apache.org/jira/browse/EAGLE-510 > Project: Eagle > Issue Type: Improvement >Reporter: Peter Kim >Priority: Minor > > The current HDFS audit log parser can be refactored by leveraging regex > instead of the substring methods it uses. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
