[jira] [Commented] (EAGLE-543) Fix eagle default configuration and invalid dependencies
[ https://issues.apache.org/jira/browse/EAGLE-543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15500434#comment-15500434 ] ASF GitHub Bot commented on EAGLE-543: -- Github user asfgit closed the pull request at: https://github.com/apache/incubator-eagle/pull/436 > Fix eagle default configuration and invalid dependencies > > > Key: EAGLE-543 > URL: https://issues.apache.org/jira/browse/EAGLE-543 > Project: Eagle > Issue Type: Bug >Affects Versions: v0.5.0 >Reporter: Hao Chen >Assignee: Hao Chen > Fix For: v0.5.0 > > > h2. Fix > * Add loaded application providers brief info log. > * Fix ApplicationProviderClass bug > * Remove duplicated dependency > * Add eagle server request log config -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (EAGLE-543) Fix eagle default configuration and invalid dependencies
[ https://issues.apache.org/jira/browse/EAGLE-543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15500426#comment-15500426 ] ASF GitHub Bot commented on EAGLE-543: -- Github user haoch commented on the issue: https://github.com/apache/incubator-eagle/pull/436 @hsaputra thanks for reviewing, and added more description about the changes. > Fix eagle default configuration and invalid dependencies > > > Key: EAGLE-543 > URL: https://issues.apache.org/jira/browse/EAGLE-543 > Project: Eagle > Issue Type: Bug >Affects Versions: v0.5.0 >Reporter: Hao Chen >Assignee: Hao Chen > Fix For: v0.5.0 > > > h2. Fix > * Add loaded application providers brief info log. > * Fix ApplicationProviderClass bug > * Remove duplicated dependency > * Add eagle server request log config -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (EAGLE-543) Fix eagle default configuration and invalid dependencies
[ https://issues.apache.org/jira/browse/EAGLE-543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15500419#comment-15500419 ] ASF GitHub Bot commented on EAGLE-543: -- Github user haoch commented on a diff in the pull request: https://github.com/apache/incubator-eagle/pull/436#discussion_r79298913 --- Diff: eagle-core/eagle-metadata/eagle-metadata-jdbc/pom.xml --- @@ -39,10 +39,6 @@ commons-dbcp -com.h2database --- End diff -- Remove duplicated dependency > Fix eagle default configuration and invalid dependencies > > > Key: EAGLE-543 > URL: https://issues.apache.org/jira/browse/EAGLE-543 > Project: Eagle > Issue Type: Bug >Affects Versions: v0.5.0 >Reporter: Hao Chen >Assignee: Hao Chen > Fix For: v0.5.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (EAGLE-543) Fix eagle default configuration and invalid dependencies
[ https://issues.apache.org/jira/browse/EAGLE-543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15500421#comment-15500421 ] ASF GitHub Bot commented on EAGLE-543: -- Github user haoch commented on a diff in the pull request: https://github.com/apache/incubator-eagle/pull/436#discussion_r79298934 --- Diff: eagle-server-assembly/src/main/conf/server.yml --- @@ -13,13 +13,25 @@ # See the License for the specific language governing permissions and # limitations under the License. +# Dropwizard Configuration: +# http://www.dropwizard.io/0.7.1/docs/manual/configuration.html + server: applicationConnectors: - type: http port: 9090 adminConnectors: - type: http port: 9091 + requestLog: --- End diff -- Add eagle server request log config > Fix eagle default configuration and invalid dependencies > > > Key: EAGLE-543 > URL: https://issues.apache.org/jira/browse/EAGLE-543 > Project: Eagle > Issue Type: Bug >Affects Versions: v0.5.0 >Reporter: Hao Chen >Assignee: Hao Chen > Fix For: v0.5.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (EAGLE-543) Fix eagle default configuration and invalid dependencies
[
https://issues.apache.org/jira/browse/EAGLE-543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15500417#comment-15500417
]
ASF GitHub Bot commented on EAGLE-543:
--
Github user haoch commented on a diff in the pull request:
https://github.com/apache/incubator-eagle/pull/436#discussion_r79298902
--- Diff:
eagle-core/eagle-app/eagle-app-base/src/main/java/org/apache/eagle/app/service/impl/ApplicationProviderServiceImpl.java
---
@@ -103,8 +103,8 @@ private void validate() {
if (!dependency.isRequired()) {
LOG.warn("Unable to load dependency {} -> {}",
applicationDesc.getType(), dependency, ex);
} else {
-LOG.error("Failed to load dependency {} ->
{}", applicationDesc.getType(), dependency,ex);
-throw new IllegalStateException("Failed to
load application providers due to dependency missing",ex);
+LOG.error("Failed to load dependency {} ->
{}", applicationDesc.getType(), dependency, ex);
--- End diff --
Add dependency details for Dependency Missing Exception
> Fix eagle default configuration and invalid dependencies
>
>
> Key: EAGLE-543
> URL: https://issues.apache.org/jira/browse/EAGLE-543
> Project: Eagle
> Issue Type: Bug
>Affects Versions: v0.5.0
>Reporter: Hao Chen
>Assignee: Hao Chen
> Fix For: v0.5.0
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (EAGLE-543) Fix eagle default configuration and invalid dependencies
[
https://issues.apache.org/jira/browse/EAGLE-543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15500415#comment-15500415
]
ASF GitHub Bot commented on EAGLE-543:
--
Github user haoch commented on a diff in the pull request:
https://github.com/apache/incubator-eagle/pull/436#discussion_r79298890
--- Diff:
eagle-core/eagle-app/eagle-app-base/src/main/java/org/apache/eagle/app/service/impl/ApplicationProviderSPILoader.java
---
@@ -82,9 +82,15 @@ private void loadProviderFromClassLoader(ClassLoader
jarFileClassLoader, Functio
providerConfig.setJarPath(jarFileSupplier.apply(applicationProvider));
applicationProvider.prepare(providerConfig, getConfig());
registerProvider(applicationProvider);
+LOG.warn("Loaded {}:{} ({}) from {}",
--- End diff --
Add loaded application providers brief info log.
> Fix eagle default configuration and invalid dependencies
>
>
> Key: EAGLE-543
> URL: https://issues.apache.org/jira/browse/EAGLE-543
> Project: Eagle
> Issue Type: Bug
>Affects Versions: v0.5.0
>Reporter: Hao Chen
>Assignee: Hao Chen
> Fix For: v0.5.0
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (EAGLE-543) Fix eagle default configuration and invalid dependencies
[
https://issues.apache.org/jira/browse/EAGLE-543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15500418#comment-15500418
]
ASF GitHub Bot commented on EAGLE-543:
--
Github user haoch commented on a diff in the pull request:
https://github.com/apache/incubator-eagle/pull/436#discussion_r79298908
--- Diff:
eagle-core/eagle-app/eagle-app-base/src/main/java/org/apache/eagle/app/spi/ApplicationXMLDescriptorLoader.java
---
@@ -48,7 +48,7 @@ private String generateXMLDescriptorPath() {
public ApplicationDesc getApplicationDesc() {
String descriptorPath = generateXMLDescriptorPath();
ApplicationDesc applicationDesc = new ApplicationDesc();
-applicationDesc.setProviderClass(this.getClass());
+applicationDesc.setProviderClass(this.providerClass);
--- End diff --
Fix ApplicationProviderClass bug
> Fix eagle default configuration and invalid dependencies
>
>
> Key: EAGLE-543
> URL: https://issues.apache.org/jira/browse/EAGLE-543
> Project: Eagle
> Issue Type: Bug
>Affects Versions: v0.5.0
>Reporter: Hao Chen
>Assignee: Hao Chen
> Fix For: v0.5.0
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (EAGLE-543) Fix eagle default configuration and invalid dependencies
[ https://issues.apache.org/jira/browse/EAGLE-543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15497856#comment-15497856 ] ASF GitHub Bot commented on EAGLE-543: -- Github user hsaputra commented on the issue: https://github.com/apache/incubator-eagle/pull/436 Could you add more description about how you are fixing the issue? > Fix eagle default configuration and invalid dependencies > > > Key: EAGLE-543 > URL: https://issues.apache.org/jira/browse/EAGLE-543 > Project: Eagle > Issue Type: Bug >Affects Versions: v0.5.0 >Reporter: Hao Chen >Assignee: Hao Chen > Fix For: v0.5.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (EAGLE-543) Fix eagle default configuration and invalid dependencies
[ https://issues.apache.org/jira/browse/EAGLE-543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15490188#comment-15490188 ] ASF GitHub Bot commented on EAGLE-543: -- GitHub user haoch opened a pull request: https://github.com/apache/incubator-eagle/pull/436 EAGLE-543 Fix eagle server default config, fix eagle server deve dependency https://issues.apache.org/jira/browse/EAGLE-543 You can merge this pull request into a Git repository by running: $ git pull https://github.com/haoch/incubator-eagle FixServerLoggingConfig Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-eagle/pull/436.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #436 commit e254e81c1a4650e19133d9edec3e10b0383c7512 Author: Hao Chen Date: 2016-09-14T11:26:19Z Fix eagle server default config, fix eagle server deve dependency > Fix eagle default configuration and invalid dependencies > > > Key: EAGLE-543 > URL: https://issues.apache.org/jira/browse/EAGLE-543 > Project: Eagle > Issue Type: Bug >Affects Versions: v0.5.0 >Reporter: Hao Chen >Assignee: Hao Chen > Fix For: v0.5.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
