[jira] [Commented] (EAGLE-622) AlertEngine : unit test failed caused by datasource name and topic name change
[ https://issues.apache.org/jira/browse/EAGLE-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15575333#comment-15575333 ] ASF GitHub Bot commented on EAGLE-622: -- Github user asfgit closed the pull request at: https://github.com/apache/incubator-eagle/pull/512 > AlertEngine : unit test failed caused by datasource name and topic name change > -- > > Key: EAGLE-622 > URL: https://issues.apache.org/jira/browse/EAGLE-622 > Project: Eagle > Issue Type: Bug >Affects Versions: v0.5.0 >Reporter: Su Ralph >Assignee: Su Ralph >Priority: Blocker > Fix For: v0.5.0 > > > The commit > https://github.com/apache/incubator-eagle/commit/2e715e3e94a6b98e0f3073d5d384878a0a845b72 > change the datasource name to topic name in spout metadata. But the unit test > are not updated, thus cause failure. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (EAGLE-622) AlertEngine : unit test failed caused by datasource name and topic name change
[ https://issues.apache.org/jira/browse/EAGLE-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15575198#comment-15575198 ] ASF GitHub Bot commented on EAGLE-622: -- Github user RalphSu commented on the issue: https://github.com/apache/incubator-eagle/pull/512 Fix the unit test to assert topic name instead of datasource name. > AlertEngine : unit test failed caused by datasource name and topic name change > -- > > Key: EAGLE-622 > URL: https://issues.apache.org/jira/browse/EAGLE-622 > Project: Eagle > Issue Type: Bug >Affects Versions: v0.5.0 >Reporter: Su Ralph >Assignee: Su Ralph >Priority: Blocker > Fix For: v0.5.0 > > > The commit > https://github.com/apache/incubator-eagle/commit/2e715e3e94a6b98e0f3073d5d384878a0a845b72 > change the datasource name to topic name in spout metadata. But the unit test > are not updated, thus cause failure. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (EAGLE-622) AlertEngine : unit test failed caused by datasource name and topic name change
[ https://issues.apache.org/jira/browse/EAGLE-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15575196#comment-15575196 ] ASF GitHub Bot commented on EAGLE-622: -- GitHub user RalphSu opened a pull request: https://github.com/apache/incubator-eagle/pull/512 [EAGLE-622] : fix the datasource name to topic name caused unit test … Be sure to do all of the following to help us incorporate your contribution quickly and easily: - [ ] Make sure the PR title is formatted like: `[EAGLE-] Description of pull request` - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable Travis-CI on your fork and ensure the whole test matrix passes). - [ ] Replace `` in the title with the actual Jira issue number, if there is one. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt). --- …failure Author: ralphsu You can merge this pull request into a Git repository by running: $ git pull https://github.com/RalphSu/incubator-eagle master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-eagle/pull/512.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #512 > AlertEngine : unit test failed caused by datasource name and topic name change > -- > > Key: EAGLE-622 > URL: https://issues.apache.org/jira/browse/EAGLE-622 > Project: Eagle > Issue Type: Bug >Affects Versions: v0.5.0 >Reporter: Su Ralph >Assignee: Su Ralph >Priority: Blocker > Fix For: v0.5.0 > > > The commit > https://github.com/apache/incubator-eagle/commit/2e715e3e94a6b98e0f3073d5d384878a0a845b72 > change the datasource name to topic name in spout metadata. But the unit test > are not updated, thus cause failure. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
