Re: Releasing Apache Fineract 1.1 WAS [Fwd: Intergration test]

[Phil Steitz]

> On Mar 14, 2018, at 7:34 AM, Myrle Krantz <my...@apache.org> wrote:
> 
> Can someone who's done this before help Avik please?
> 
> (cc'ing the mentor and the two PMC members who are most likely to be
> able to provide concrete help.)


Have a look at the “normal publication” section here:
http://www.apache.org/dev/release-publishing.html

Someone with svn karma to the fineract dist directory in the svn repo 
referenced there needs to commit the artifacts.

Phil
> 
> Thanks,
> Myrle
> 
> 
> -- Forwarded message --
> From: Avik Ganguly <avikganguly...@gmail.com>
> Date: Wed, Mar 14, 2018 at 1:12 PM
> Subject: Re: Releasing Apache Fineract 1.1 WAS [Fwd: Intergration test]
> To: Ed Cable <edca...@mifos.org>
> Cc: Dev <dev@fineract.apache.org>, Nikhil Pawar <nickr...@gmail.com>,
> Kumaranath Fernando <kumaranathferna...@gmail.com>, Vishwas Babu A J
> <vish...@confluxtechnologies.com>, Nazeer Hussain Shaik
> <nazeerhussain.sh...@gmail.com>, Santosh Math
> <sant...@confluxtechnologies.com>
> 
> 
> Hey,
> 
> Bump. Looking for someone who did this step before regarding uploading the
> binary and src artifacts to  https://dist.apache.org/
> repos/dist/dev/fineract/.
> 
> This is a blocker for release.
> 
> Regards,
> Avik.
> 
> On Sat, Mar 10, 2018 at 2:12 AM, Avik Ganguly <avikganguly...@gmail.com>
> wrote:
> 
>> Hi guys,
>> 
>> As per release sign documentation, a directory needs to be created at
>> https://dist.apache.org/repos/dist/dev/incubator/fineract which I am
>> unable to access (even https://dist.apache.org/repos/dist/dev/fineract/).
>> 
>> @Nazeer / Ed,
>> 
>> I have uploaded the release files to this link
>> <https://drive.google.com/file/d/1F8V42aYiiqM7spoGxIkoOqWtGNdZ8s4c/view?usp=sharing>
>> instead as I can't find documentation to upload release to above links.
>> 
>> I have not included the MD5 files as per the new policy change.
>> 
>> 
>> Regards,
>> Avik.
>> 
>>> On Fri, Mar 2, 2018 at 10:26 PM, Ed Cable <edca...@mifos.org> wrote:
>>> 
>>> Avik,
>>> 
>>> I checked the JIRA native link itself and those seem to be up to date
>>> with all the recent issues that have been fixed. I don't think there was
>>> any JIRA ticket related to the notifications issue that Steve fixed but it
>>> was all part of the work that was in
>>> 
>>>   - [FINERACT-585 <https://issues.apache.org/jira/browse/FINERACT-585>]
>>>   - Allow predefined SMS messages and Emails to be sent via existing
>>>   SMS/Email implementations
>>> 
>>> 
>>> which is reflected in the release notes.
>>> 
>>> Are you able to do the needful to move forward with this release?
>>> 
>>> Thanks,
>>> 
>>> Ed
>>> 
>>> On Tue, Feb 27, 2018 at 1:36 PM, Avik Ganguly <avikganguly...@gmail.com>
>>> wrote:
>>> 
>>>> Hi guys,
>>>> 
>>>> Is Steve's changes getting reflected in the release notes
>>>> <https://cwiki.apache.org/confluence/display/FINERACT/1.1.0+-+Apache+Fineract>
>>>> ?
>>>> 
>>>> If the release notes is up to date, I can give the release this Thursday
>>>> after merging one pending item from my side.
>>>> 
>>>> Regards,
>>>> Avik.
>>>> 
>>>>> On Sun, Feb 25, 2018 at 9:13 PM, Ed Cable <edca...@mifos.org> wrote:
>>>>> 
>>>>> Fineract committers,
>>>>> 
>>>>> Now that the PRs have been submitted for all the outstanding critical
>>>>> bug fixes and integration test failures, can we please review, merge, and
>>>>> get the release prepped and call for the vote!
>>>>> 
>>>>> As you know the community has waiting on this for quite some time now
>>>>> and I"d like to get this shipped and shift focuses to Fineract 1.2
>>>>> 
>>>>> Thanks!
>>>>> 
>>>>> Ed
>>>>> -- Forwarded message --
>>>>> From: Ed Cable <edca...@mifos.org>
>>>>> Date: Sun, Feb 18, 2018 at 4:49 AM
>>>>> Subject: Re: Intergration test
>>>>> To: Dev <dev@fineract.apache.org>
>>>>> Cc: Vishwas Babu A J <vish...@confluxtechnologies.com>, Nazeer Hussain
>>>>> Shaik <nazeerhussain.sh...@gmail.com>, Kumaranath Fernando <
>>>>> kum

Re: Releasing Apache Fineract 1.1 WAS [Fwd: Intergration test]

[Avik Ganguly]

Hey,

Bump. Looking for someone who did this step before regarding uploading the
binary and src artifacts to  https://dist.apache.org/
repos/dist/dev/fineract/.

This is a blocker for release.

Regards,
Avik.

On Sat, Mar 10, 2018 at 2:12 AM, Avik Ganguly 
wrote:

> Hi guys,
>
> As per release sign documentation, a directory needs to be created at
> https://dist.apache.org/repos/dist/dev/incubator/fineract which I am
> unable to access (even https://dist.apache.org/repos/dist/dev/fineract/).
>
> @Nazeer / Ed,
>
> I have uploaded the release files to this link
> 
> instead as I can't find documentation to upload release to above links.
>
> I have not included the MD5 files as per the new policy change.
>
>
> Regards,
> Avik.
>
> On Fri, Mar 2, 2018 at 10:26 PM, Ed Cable  wrote:
>
>> Avik,
>>
>> I checked the JIRA native link itself and those seem to be up to date
>> with all the recent issues that have been fixed. I don't think there was
>> any JIRA ticket related to the notifications issue that Steve fixed but it
>> was all part of the work that was in
>>
>>- [FINERACT-585 ]
>>- Allow predefined SMS messages and Emails to be sent via existing
>>SMS/Email implementations
>>
>>
>> which is reflected in the release notes.
>>
>> Are you able to do the needful to move forward with this release?
>>
>> Thanks,
>>
>> Ed
>>
>> On Tue, Feb 27, 2018 at 1:36 PM, Avik Ganguly 
>> wrote:
>>
>>> Hi guys,
>>>
>>> Is Steve's changes getting reflected in the release notes
>>> 
>>> ?
>>>
>>> If the release notes is up to date, I can give the release this Thursday
>>> after merging one pending item from my side.
>>>
>>> Regards,
>>> Avik.
>>>
>>> On Sun, Feb 25, 2018 at 9:13 PM, Ed Cable  wrote:
>>>
 Fineract committers,

 Now that the PRs have been submitted for all the outstanding critical
 bug fixes and integration test failures, can we please review, merge, and
 get the release prepped and call for the vote!

 As you know the community has waiting on this for quite some time now
 and I"d like to get this shipped and shift focuses to Fineract 1.2

 Thanks!

 Ed
 -- Forwarded message --
 From: Ed Cable 
 Date: Sun, Feb 18, 2018 at 4:49 AM
 Subject: Re: Intergration test
 To: Dev 
 Cc: Vishwas Babu A J , Nazeer Hussain
 Shaik , Kumaranath Fernando <
 kumaranathferna...@gmail.com>, Avik Ganguly ,
 Nikhil Pawar , Santosh Math <
 sant...@confluxtechnologies.com>


 Great!

 Committers, can you please review?

 Nazeer, with this fix and Steve's for the notification, I think we're
 ready to move forward. Can you initiate the next steps in the release
 process?

 Thanks,

 Ed

 On Sat, Feb 17, 2018 at 11:20 AM, Kumaranath Fernando <
 kumaranathferna...@gmail.com> wrote:

> Hi Ed!
>
> I've just sent a PR 
> correcting the integration test failures.
>
> Regards,
> Kumaranath Fernando
>
> On Fri, Feb 16, 2018 at 6:14 PM, Ed Cable  wrote:
>
>> Thanks for the feedback Vishwas. Kumaranath, hopefully you have
>> enough to go by now and can make those changes. I believe Steve fixed our
>> other outstanding issue so once we can get these integration tests to 
>> pass
>> we'll be ready to call for a vote on the release.
>>
>> Ed
>>
>> On Wed, Feb 14, 2018 at 1:06 PM, 
>> wrote:
>>
>>> The approach of sleeping for a fixed time does not work well in
>>> general as Integration test cases must pass on any environment. 
>>> Depending
>>> on random sleep values would mean that there is always a probability 
>>> that
>>> the test can fail if the system is slow / has other CPU intensive 
>>> processes
>>> running etc.
>>>
>>> Ideally , you would handle such scenarios more gracefully . Have the
>>> test check if the file you are referring to is created , if not sleep 
>>> for
>>> an interval and check again etc.
>>>
>>> Please make this change and send out a pull request
>>>
>>> Regards,
>>> Vishwas
>>>
>>> On Feb 14, 2018, at 9:39 AM, Kumaranath Fernando <
>>> kumaranathferna...@gmail.com> wrote:
>>>
>>> I've tested the develop branch and it's most likely because the
>>> result excel file takes a bit of time to be created, after the file is

Re: Releasing Apache Fineract 1.1 WAS [Fwd: Intergration test]

[Avik Ganguly]

Hi guys,

As per release sign documentation, a directory needs to be created at
https://dist.apache.org/repos/dist/dev/incubator/fineract which I am unable
to access (even https://dist.apache.org/repos/dist/dev/fineract/).

@Nazeer / Ed,

I have uploaded the release files to this link

instead as I can't find documentation to upload release to above links.

I have not included the MD5 files as per the new policy change.


Regards,
Avik.

On Fri, Mar 2, 2018 at 10:26 PM, Ed Cable  wrote:

> Avik,
>
> I checked the JIRA native link itself and those seem to be up to date with
> all the recent issues that have been fixed. I don't think there was any
> JIRA ticket related to the notifications issue that Steve fixed but it was
> all part of the work that was in
>
>- [FINERACT-585 ]
>- Allow predefined SMS messages and Emails to be sent via existing
>SMS/Email implementations
>
>
> which is reflected in the release notes.
>
> Are you able to do the needful to move forward with this release?
>
> Thanks,
>
> Ed
>
> On Tue, Feb 27, 2018 at 1:36 PM, Avik Ganguly 
> wrote:
>
>> Hi guys,
>>
>> Is Steve's changes getting reflected in the release notes
>> 
>> ?
>>
>> If the release notes is up to date, I can give the release this Thursday
>> after merging one pending item from my side.
>>
>> Regards,
>> Avik.
>>
>> On Sun, Feb 25, 2018 at 9:13 PM, Ed Cable  wrote:
>>
>>> Fineract committers,
>>>
>>> Now that the PRs have been submitted for all the outstanding critical
>>> bug fixes and integration test failures, can we please review, merge, and
>>> get the release prepped and call for the vote!
>>>
>>> As you know the community has waiting on this for quite some time now
>>> and I"d like to get this shipped and shift focuses to Fineract 1.2
>>>
>>> Thanks!
>>>
>>> Ed
>>> -- Forwarded message --
>>> From: Ed Cable 
>>> Date: Sun, Feb 18, 2018 at 4:49 AM
>>> Subject: Re: Intergration test
>>> To: Dev 
>>> Cc: Vishwas Babu A J , Nazeer Hussain
>>> Shaik , Kumaranath Fernando <
>>> kumaranathferna...@gmail.com>, Avik Ganguly ,
>>> Nikhil Pawar , Santosh Math <
>>> sant...@confluxtechnologies.com>
>>>
>>>
>>> Great!
>>>
>>> Committers, can you please review?
>>>
>>> Nazeer, with this fix and Steve's for the notification, I think we're
>>> ready to move forward. Can you initiate the next steps in the release
>>> process?
>>>
>>> Thanks,
>>>
>>> Ed
>>>
>>> On Sat, Feb 17, 2018 at 11:20 AM, Kumaranath Fernando <
>>> kumaranathferna...@gmail.com> wrote:
>>>
 Hi Ed!

 I've just sent a PR 
 correcting the integration test failures.

 Regards,
 Kumaranath Fernando

 On Fri, Feb 16, 2018 at 6:14 PM, Ed Cable  wrote:

> Thanks for the feedback Vishwas. Kumaranath, hopefully you have enough
> to go by now and can make those changes. I believe Steve fixed our other
> outstanding issue so once we can get these integration tests to pass we'll
> be ready to call for a vote on the release.
>
> Ed
>
> On Wed, Feb 14, 2018 at 1:06 PM, 
> wrote:
>
>> The approach of sleeping for a fixed time does not work well in
>> general as Integration test cases must pass on any environment. Depending
>> on random sleep values would mean that there is always a probability that
>> the test can fail if the system is slow / has other CPU intensive 
>> processes
>> running etc.
>>
>> Ideally , you would handle such scenarios more gracefully . Have the
>> test check if the file you are referring to is created , if not sleep for
>> an interval and check again etc.
>>
>> Please make this change and send out a pull request
>>
>> Regards,
>> Vishwas
>>
>> On Feb 14, 2018, at 9:39 AM, Kumaranath Fernando <
>> kumaranathferna...@gmail.com> wrote:
>>
>> I've tested the develop branch and it's most likely because the
>> result excel file takes a bit of time to be created, after the file is
>> created I'm trying to read a value of a column.
>> Since the file is not created by the time FileInputStream reads the
>> file, you get a FileNotException.
>>
>> You could fix this issue by increasing the number of milliseconds
>> 1 on Thread.sleep() line in the respective tests.Ping me if this
>> resolves the issue and I'll send PR.
>>
>> Vishwas/Nazeer awaiting your confirmation!.
>>
>> Regards,
>> Kumaranath Fernando

Re: Releasing Apache Fineract 1.1 WAS [Fwd: Intergration test]

[Ed Cable]

Avik,

I checked the JIRA native link itself and those seem to be up to date with
all the recent issues that have been fixed. I don't think there was any
JIRA ticket related to the notifications issue that Steve fixed but it was
all part of the work that was in

   - [FINERACT-585 ] -
   Allow predefined SMS messages and Emails to be sent via existing SMS/Email
   implementations


which is reflected in the release notes.

Are you able to do the needful to move forward with this release?

Thanks,

Ed

On Tue, Feb 27, 2018 at 1:36 PM, Avik Ganguly 
wrote:

> Hi guys,
>
> Is Steve's changes getting reflected in the release notes
> 
> ?
>
> If the release notes is up to date, I can give the release this Thursday
> after merging one pending item from my side.
>
> Regards,
> Avik.
>
> On Sun, Feb 25, 2018 at 9:13 PM, Ed Cable  wrote:
>
>> Fineract committers,
>>
>> Now that the PRs have been submitted for all the outstanding critical bug
>> fixes and integration test failures, can we please review, merge, and get
>> the release prepped and call for the vote!
>>
>> As you know the community has waiting on this for quite some time now and
>> I"d like to get this shipped and shift focuses to Fineract 1.2
>>
>> Thanks!
>>
>> Ed
>> -- Forwarded message --
>> From: Ed Cable 
>> Date: Sun, Feb 18, 2018 at 4:49 AM
>> Subject: Re: Intergration test
>> To: Dev 
>> Cc: Vishwas Babu A J , Nazeer Hussain
>> Shaik , Kumaranath Fernando <
>> kumaranathferna...@gmail.com>, Avik Ganguly ,
>> Nikhil Pawar , Santosh Math <
>> sant...@confluxtechnologies.com>
>>
>>
>> Great!
>>
>> Committers, can you please review?
>>
>> Nazeer, with this fix and Steve's for the notification, I think we're
>> ready to move forward. Can you initiate the next steps in the release
>> process?
>>
>> Thanks,
>>
>> Ed
>>
>> On Sat, Feb 17, 2018 at 11:20 AM, Kumaranath Fernando <
>> kumaranathferna...@gmail.com> wrote:
>>
>>> Hi Ed!
>>>
>>> I've just sent a PR 
>>> correcting the integration test failures.
>>>
>>> Regards,
>>> Kumaranath Fernando
>>>
>>> On Fri, Feb 16, 2018 at 6:14 PM, Ed Cable  wrote:
>>>
 Thanks for the feedback Vishwas. Kumaranath, hopefully you have enough
 to go by now and can make those changes. I believe Steve fixed our other
 outstanding issue so once we can get these integration tests to pass we'll
 be ready to call for a vote on the release.

 Ed

 On Wed, Feb 14, 2018 at 1:06 PM, 
 wrote:

> The approach of sleeping for a fixed time does not work well in
> general as Integration test cases must pass on any environment. Depending
> on random sleep values would mean that there is always a probability that
> the test can fail if the system is slow / has other CPU intensive 
> processes
> running etc.
>
> Ideally , you would handle such scenarios more gracefully . Have the
> test check if the file you are referring to is created , if not sleep for
> an interval and check again etc.
>
> Please make this change and send out a pull request
>
> Regards,
> Vishwas
>
> On Feb 14, 2018, at 9:39 AM, Kumaranath Fernando <
> kumaranathferna...@gmail.com> wrote:
>
> I've tested the develop branch and it's most likely because the
> result excel file takes a bit of time to be created, after the file is
> created I'm trying to read a value of a column.
> Since the file is not created by the time FileInputStream reads the
> file, you get a FileNotException.
>
> You could fix this issue by increasing the number of milliseconds
> 1 on Thread.sleep() line in the respective tests.Ping me if this
> resolves the issue and I'll send PR.
>
> Vishwas/Nazeer awaiting your confirmation!.
>
> Regards,
> Kumaranath Fernando
>
>
> On Wed, Feb 14, 2018 at 10:59 AM, vishwas <
> vish...@confluxtechnologies.com> wrote:
>
>> Hi Kumaranath,
>>
>> You should be able to reproduce this issue if you fetch the latest
>> fineract code in a seperate workspace.
>>
>> If the remember correctly, the crux of the issue seemed be be that
>> files you were referring to in the test cases , i.e
>> fineract-provider/src/integrationtest/resources/bulkimport/importhandler/officer
>> are not present and all these tests cases throw a file not found 
>> exception.
>>
>> Regards,
>> Vishwas
>>
>>
>>
>> > On Feb 13, 2018, at 6:43 PM, Kumaranath Fernando <
>> kumaranathferna...@gmail.com> 

Re: Releasing Apache Fineract 1.1 WAS [Fwd: Intergration test]

[Avik Ganguly]

Hi guys,

Is Steve's changes getting reflected in the release notes

?

If the release notes is up to date, I can give the release this Thursday
after merging one pending item from my side.

Regards,
Avik.

On Sun, Feb 25, 2018 at 9:13 PM, Ed Cable  wrote:

> Fineract committers,
>
> Now that the PRs have been submitted for all the outstanding critical bug
> fixes and integration test failures, can we please review, merge, and get
> the release prepped and call for the vote!
>
> As you know the community has waiting on this for quite some time now and
> I"d like to get this shipped and shift focuses to Fineract 1.2
>
> Thanks!
>
> Ed
> -- Forwarded message --
> From: Ed Cable 
> Date: Sun, Feb 18, 2018 at 4:49 AM
> Subject: Re: Intergration test
> To: Dev 
> Cc: Vishwas Babu A J , Nazeer Hussain
> Shaik , Kumaranath Fernando <
> kumaranathferna...@gmail.com>, Avik Ganguly ,
> Nikhil Pawar , Santosh Math <
> sant...@confluxtechnologies.com>
>
>
> Great!
>
> Committers, can you please review?
>
> Nazeer, with this fix and Steve's for the notification, I think we're
> ready to move forward. Can you initiate the next steps in the release
> process?
>
> Thanks,
>
> Ed
>
> On Sat, Feb 17, 2018 at 11:20 AM, Kumaranath Fernando <
> kumaranathferna...@gmail.com> wrote:
>
>> Hi Ed!
>>
>> I've just sent a PR 
>> correcting the integration test failures.
>>
>> Regards,
>> Kumaranath Fernando
>>
>> On Fri, Feb 16, 2018 at 6:14 PM, Ed Cable  wrote:
>>
>>> Thanks for the feedback Vishwas. Kumaranath, hopefully you have enough
>>> to go by now and can make those changes. I believe Steve fixed our other
>>> outstanding issue so once we can get these integration tests to pass we'll
>>> be ready to call for a vote on the release.
>>>
>>> Ed
>>>
>>> On Wed, Feb 14, 2018 at 1:06 PM, 
>>> wrote:
>>>
 The approach of sleeping for a fixed time does not work well in general
 as Integration test cases must pass on any environment. Depending on random
 sleep values would mean that there is always a probability that the test
 can fail if the system is slow / has other CPU intensive processes running
 etc.

 Ideally , you would handle such scenarios more gracefully . Have the
 test check if the file you are referring to is created , if not sleep for
 an interval and check again etc.

 Please make this change and send out a pull request

 Regards,
 Vishwas

 On Feb 14, 2018, at 9:39 AM, Kumaranath Fernando <
 kumaranathferna...@gmail.com> wrote:

 I've tested the develop branch and it's most likely because the result
 excel file takes a bit of time to be created, after the file is created I'm
 trying to read a value of a column.
 Since the file is not created by the time FileInputStream reads the
 file, you get a FileNotException.

 You could fix this issue by increasing the number of milliseconds 1
 on Thread.sleep() line in the respective tests.Ping me if this resolves the
 issue and I'll send PR.

 Vishwas/Nazeer awaiting your confirmation!.

 Regards,
 Kumaranath Fernando


 On Wed, Feb 14, 2018 at 10:59 AM, vishwas <
 vish...@confluxtechnologies.com> wrote:

> Hi Kumaranath,
>
> You should be able to reproduce this issue if you fetch the latest
> fineract code in a seperate workspace.
>
> If the remember correctly, the crux of the issue seemed be be that
> files you were referring to in the test cases , i.e
> fineract-provider/src/integrationtest/resources/bulkimport/importhandler/officer
> are not present and all these tests cases throw a file not found 
> exception.
>
> Regards,
> Vishwas
>
>
>
> > On Feb 13, 2018, at 6:43 PM, Kumaranath Fernando <
> kumaranathferna...@gmail.com> wrote:
> >
> > Hi Nazeer!
> >
> > Could you please send in the stack traces for investigation.
> >
> > Regards,
> > Kumaranath Fernando
> >
> > On Wed, Feb 14, 2018 at 12:43 AM, Ed Cable  > wrote:
> >
> >> Please keep the community posted and try to address as quickly as
> you can
> >> we have one other issue we're fixing and then once these
> integration tests
> >> pass, we can call for a vote to ship the release.
> >>
> >> Ed
> >>
> >> On Tue, Feb 13, 2018 at 6:02 AM, Kumaranath Fernando <
> >> kumaranathferna...@gmail.com> wrote:
> >>
> >>> Hello Ed!
> >>>
> >>> Sure. I'll take a look at it!
> >>>
> >>> Regards,
> >>>