[GitHub] incubator-fineract pull request: adding organisation start in glob...

2016-02-28 Thread rajuan
Github user rajuan commented on a diff in the pull request: https://github.com/apache/incubator-fineract/pull/12#discussion_r54368112 --- Diff: fineract-provider/src/main/java/org/apache/fineract/infrastructure/configuration/data/GlobalConfigurationDataValidator.java --- @@ -71,6

[GitHub] incubator-fineract pull request: adding organisation start in glob...

2016-02-28 Thread rajuan
Github user rajuan commented on a diff in the pull request: https://github.com/apache/incubator-fineract/pull/12#discussion_r54368208 --- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanAccountDomainServiceJpa.java --- @@ -437,6 +438,8

[GitHub] incubator-fineract pull request: adding organisation start in glob...

2016-02-28 Thread rajuan
Github user rajuan commented on a diff in the pull request: https://github.com/apache/incubator-fineract/pull/12#discussion_r54368217 --- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanAccountDomainServiceJpa.java --- @@ -437,6 +438,8

[GitHub] incubator-fineract pull request: adding organisation start in glob...

2016-02-28 Thread rajuan
Github user rajuan commented on a diff in the pull request: https://github.com/apache/incubator-fineract/pull/12#discussion_r54368261 --- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanAccountDomainServiceJpa.java --- @@ -454,7 +457,7

[GitHub] incubator-fineract pull request: adding organisation start in glob...

2016-02-28 Thread rajuan
Github user rajuan commented on a diff in the pull request: https://github.com/apache/incubator-fineract/pull/12#discussion_r54368307 --- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanReadPlatformServiceImpl.java --- @@ -1566,15

[GitHub] incubator-fineract pull request: adding organisation start in glob...

2016-02-28 Thread rajuan
Github user rajuan commented on a diff in the pull request: https://github.com/apache/incubator-fineract/pull/12#discussion_r54368300 --- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanReadPlatformServiceImpl.java --- @@ -1559,6

[GitHub] incubator-fineract pull request: Provision for notes while editing...

2016-03-21 Thread rajuan
Github user rajuan commented on a diff in the pull request: https://github.com/apache/incubator-fineract/pull/38#discussion_r56933937 --- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/note/domain/NoteRepository.java --- @@ -41,5 +41,6 @@ List

[GitHub] incubator-fineract pull request: Display Full Name instead of Firs...

2016-03-03 Thread rajuan
Github user rajuan commented on the pull request: https://github.com/apache/incubator-fineract/pull/23#issuecomment-192129738 In the code, there is only addition of new global configuration. This global configuration is not used for any validations or data management

[GitHub] incubator-fineract pull request: Correction in interest recalculat...

2016-03-02 Thread rajuan
GitHub user rajuan opened a pull request: https://github.com/apache/incubator-fineract/pull/18 Correction in interest recalculation scheduler job to avoid infinite loop You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajuan

[GitHub] incubator-fineract pull request: insert script for organisation st...

2016-03-02 Thread rajuan
Github user rajuan commented on a diff in the pull request: https://github.com/apache/incubator-fineract/pull/19#discussion_r54701250 --- Diff: fineract-provider/src/main/resources/sql/migrations/core_db/V292__update_organisation_start_date.sql --- @@ -0,0 +1 @@ +INSERT

[GitHub] incubator-fineract pull request: Skipping Meeting which Falls On F...

2016-03-23 Thread rajuan
Github user rajuan commented on the pull request: https://github.com/apache/incubator-fineract/pull/48#issuecomment-200246306 This PR has compilation issues --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] incubator-fineract pull request: [FINERACT-160] - Not able to add ...

2016-05-23 Thread rajuan
GitHub user rajuan opened a pull request: https://github.com/apache/incubator-fineract/pull/121 [FINERACT-160] - Not able to add any charges after the savings applic… …ation is submitted You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] incubator-fineract pull request: [MIFOSX-2656] - Accrual transacti...

2016-05-24 Thread rajuan
GitHub user rajuan opened a pull request: https://github.com/apache/incubator-fineract/pull/122 [MIFOSX-2656] - Accrual transaction should be added only on the first… … tranche disbursal You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] incubator-fineract pull request: FINERACT-37 Reschedule payments t...

2016-05-12 Thread rajuan
Github user rajuan commented on a diff in the pull request: https://github.com/apache/incubator-fineract/pull/110#discussion_r62999595 --- Diff: fineract-provider/src/main/java/org/apache/fineract/organisation/workingdays/domain/WorkingDays.java --- @@ -74,6 +78,8 @@ public

[GitHub] incubator-fineract pull request: FINERACT-37 Reschedule payments t...

2016-05-12 Thread rajuan
Github user rajuan commented on a diff in the pull request: https://github.com/apache/incubator-fineract/pull/110#discussion_r62999640 --- Diff: fineract-provider/src/main/java/org/apache/fineract/organisation/workingdays/domain/WorkingDays.java --- @@ -41,15 +41,19

[GitHub] incubator-fineract pull request: FINERACT-37 Reschedule payments t...

2016-05-12 Thread rajuan
Github user rajuan commented on a diff in the pull request: https://github.com/apache/incubator-fineract/pull/110#discussion_r62999753 --- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/domain/DefaultScheduledDateGenerator.java

[GitHub] incubator-fineract pull request: FINERACT-37 Reschedule payments t...

2016-05-12 Thread rajuan
Github user rajuan commented on a diff in the pull request: https://github.com/apache/incubator-fineract/pull/110#discussion_r63000180 --- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/domain/DefaultScheduledDateGenerator.java

[GitHub] incubator-fineract pull request: [FINERACT-152][FINERACT-153] - Do...

2016-05-11 Thread rajuan
GitHub user rajuan opened a pull request: https://github.com/apache/incubator-fineract/pull/113 [FINERACT-152][FINERACT-153] - Dormant Savings Issues Corrections You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajuan/incubator

[GitHub] incubator-fineract pull request: Integration tests for Savings Dor...

2016-05-10 Thread rajuan
GitHub user rajuan opened a pull request: https://github.com/apache/incubator-fineract/pull/108 Integration tests for Savings Dormancy Tracking feature You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajuan/incubator-fineract