Re: [FlexJS MDL] release build broken

2017-02-17 Thread Alex Harui 


On 2/17/17, 5:54 AM, "carlos.rov...@gmail.com on behalf of Carlos Rovira"
 wrote:

>2017-02-17 12:36 GMT+01:00 Harbs :
>
>> Simply specifying strings instead of the constants would be the most
>> efficient currently.
>>
>
>But that's what we try to avoid in order to support type safe code
>
>I put on my plate to break the class in 16 classes, but as I'm working on
>other things I invite people to do this instead of me.

Probably better to look into compiler changes instead.  Can anyone think
of why the values can't be in-lined if the initializer is a literal?

-Alex

Re: [FlexJS MDL] release build broken

2017-02-17 Thread Carlos Rovira 
2017-02-17 12:36 GMT+01:00 Harbs :

> Simply specifying strings instead of the constants would be the most
> efficient currently.
>

But that's what we try to avoid in order to support type safe code

I put on my plate to break the class in 16 classes, but as I'm working on
other things I invite people to do this instead of me.

Thanks


-- 
Carlos Rovira
http://about.me/carlosrovira

Re: [FlexJS MDL] release build broken

2017-02-17 Thread Harbs 
I’d really like to eventually see the compiler to optimize constants better, 
but yes, breaking the constant classes into smaller categories will help if 
only some of them are used.

Simply specifying strings instead of the constants would be the most efficient 
currently.

> On Feb 17, 2017, at 1:16 PM, Carlos Rovira  
> wrote:
> 
> Hi Harbs,
> 
> if we don't use constants what you suggest?
> One of the things we provide is "type safe". I think this is the minimal
> version we can provide. Think that before we was creating a class per icon,
> given the 900+ icons would be a problem to both in terms of coding and
> space used.
> 
> The only thing I see is to separate in pieces. For example there is various
> sections in
> 
> https://material.io/icons/
> 
> * Action
> * Alert
> * AV
> * Communication
> * Content
> * Device
> * Editor
> * File
> * Hardware
> * Image
> * Maps
> * Navigation
> * Notification
> * Places
> * Social
> * Toggle
> 
> That makes 16 categories. So splitting in 16 files could be better right?
> 
> 
> 
> 2017-02-16 21:34 GMT+01:00 Harbs :
> 
>> When I’ve had these kinds of issues in my app, it’s because of minified
>> renaming.
>> 
>> Tangentially:
>> FWIW, I’m not sure how wise it is to use constants to specify the icon
>> text. The minified version of just the definitions for the
>> MaterialIconTypes is a full 77KB!
>> 
>> Until we have a way to stripped out unused constants during compilation, I
>> think extra const definitions should be avoided.
>> 
>> Harbs
>> 
>>> On Feb 16, 2017, at 8:34 PM, Carlos Rovira <
>> carlos.rov...@codeoscopic.com> wrote:
>>> 
>>> Hi Harbs,
>>> 
>>> Thanks for seeing that.
>>> 
>>> @Pitor, I looked at the code and seems something related to binding,
>>> 
>>> 
>>>   
>>>   
>>> 
>>> 
>>>   
>>>   
>>>   
>>>   
>>> 
>>> The binding is not working and no text is retrieved. The output is:
>>> 
>>> 
>>> 
>>> So no text in the i element tag seems the binding not doing its work.
>> Maybe
>>> some latest changes in binding caused this?
>>> 
>>> Thanks
>>> 
>>> 
>>> 2017-02-16 11:03 GMT+01:00 Harbs :
>>> 
 1. Go here: http://apacheflexbuild.cloudapp.net:8080/job/MDLExample/
 lastSuccessfulBuild/artifact/examples/flexjs/MDLExample/
 bin/js-release/index.html > cloudapp.net:8080/job/
 MDLExample/lastSuccessfulBuild/artifact/examples/flexjs/MDLExample/
 bin/js-release/index.html>
 
 2. Click on Toggles
 
 You will see that the two IconToggles have no content. It seems like the
 Material Design font is not beiing used for some reason in the release
 build. The same thing works in the debug build.
 
 Harbs
>>> 
>>> 
>>> 
>>> 
>>> --
>>> 
>>> Carlos Rovira
>>> Director General
>>> M: +34 607 22 60 05
>>> http://www.codeoscopic.com
>>> http://www.avant2.es
>>> 
>>> Este mensaje se dirige exclusivamente a su destinatario y puede contener
>>> información privilegiada o confidencial. Si ha recibido este mensaje por
>>> error, le rogamos que nos lo comunique inmediatamente por esta misma vía
>> y
>>> proceda a su destrucción.
>>> 
>>> De la vigente Ley Orgánica de Protección de Datos (15/1999), le
>> comunicamos
>>> que sus datos forman parte de un fichero cuyo responsable es CODEOSCOPIC
>>> S.A. La finalidad de dicho tratamiento es facilitar la prestación del
>>> servicio o información solicitados, teniendo usted derecho de acceso,
>>> rectificación, cancelación y oposición de sus datos dirigiéndose a
>> nuestras
>>> oficinas c/ Paseo de la Habana 9-11, 28036, Madrid con la documentación
>>> necesaria.
>> 
>> 
> 
> 
> -- 
> 
> Carlos Rovira
> Director General
> M: +34 607 22 60 05
> http://www.codeoscopic.com
> http://www.avant2.es
> 
> Este mensaje se dirige exclusivamente a su destinatario y puede contener
> información privilegiada o confidencial. Si ha recibido este mensaje por
> error, le rogamos que nos lo comunique inmediatamente por esta misma vía y
> proceda a su destrucción.
> 
> De la vigente Ley Orgánica de Protección de Datos (15/1999), le comunicamos
> que sus datos forman parte de un fichero cuyo responsable es CODEOSCOPIC
> S.A. La finalidad de dicho tratamiento es facilitar la prestación del
> servicio o información solicitados, teniendo usted derecho de acceso,
> rectificación, cancelación y oposición de sus datos dirigiéndose a nuestras
> oficinas c/ Paseo de la Habana 9-11, 28036, Madrid con la documentación
> necesaria.

Re: [FlexJS MDL] release build broken

2017-02-17 Thread Carlos Rovira 
Hi Harbs,

if we don't use constants what you suggest?
One of the things we provide is "type safe". I think this is the minimal
version we can provide. Think that before we was creating a class per icon,
given the 900+ icons would be a problem to both in terms of coding and
space used.

The only thing I see is to separate in pieces. For example there is various
sections in

 https://material.io/icons/

* Action
* Alert
* AV
* Communication
* Content
* Device
* Editor
* File
* Hardware
* Image
* Maps
* Navigation
* Notification
* Places
* Social
* Toggle

That makes 16 categories. So splitting in 16 files could be better right?



2017-02-16 21:34 GMT+01:00 Harbs :

> When I’ve had these kinds of issues in my app, it’s because of minified
> renaming.
>
> Tangentially:
> FWIW, I’m not sure how wise it is to use constants to specify the icon
> text. The minified version of just the definitions for the
> MaterialIconTypes is a full 77KB!
>
> Until we have a way to stripped out unused constants during compilation, I
> think extra const definitions should be avoided.
>
> Harbs
>
> > On Feb 16, 2017, at 8:34 PM, Carlos Rovira <
> carlos.rov...@codeoscopic.com> wrote:
> >
> > Hi Harbs,
> >
> > Thanks for seeing that.
> >
> > @Pitor, I looked at the code and seems something related to binding,
> >
> > 
> >
> >
> >
> > 
> >
> >
> >
> >
> >
> > The binding is not working and no text is retrieved. The output is:
> >
> > 
> >
> > So no text in the i element tag seems the binding not doing its work.
> Maybe
> > some latest changes in binding caused this?
> >
> > Thanks
> >
> >
> > 2017-02-16 11:03 GMT+01:00 Harbs :
> >
> >> 1. Go here: http://apacheflexbuild.cloudapp.net:8080/job/MDLExample/
> >> lastSuccessfulBuild/artifact/examples/flexjs/MDLExample/
> >> bin/js-release/index.html  cloudapp.net:8080/job/
> >> MDLExample/lastSuccessfulBuild/artifact/examples/flexjs/MDLExample/
> >> bin/js-release/index.html>
> >>
> >> 2. Click on Toggles
> >>
> >> You will see that the two IconToggles have no content. It seems like the
> >> Material Design font is not beiing used for some reason in the release
> >> build. The same thing works in the debug build.
> >>
> >> Harbs
> >
> >
> >
> >
> > --
> >
> > Carlos Rovira
> > Director General
> > M: +34 607 22 60 05
> > http://www.codeoscopic.com
> > http://www.avant2.es
> >
> > Este mensaje se dirige exclusivamente a su destinatario y puede contener
> > información privilegiada o confidencial. Si ha recibido este mensaje por
> > error, le rogamos que nos lo comunique inmediatamente por esta misma vía
> y
> > proceda a su destrucción.
> >
> > De la vigente Ley Orgánica de Protección de Datos (15/1999), le
> comunicamos
> > que sus datos forman parte de un fichero cuyo responsable es CODEOSCOPIC
> > S.A. La finalidad de dicho tratamiento es facilitar la prestación del
> > servicio o información solicitados, teniendo usted derecho de acceso,
> > rectificación, cancelación y oposición de sus datos dirigiéndose a
> nuestras
> > oficinas c/ Paseo de la Habana 9-11, 28036, Madrid con la documentación
> > necesaria.
>
>


-- 

Carlos Rovira
Director General
M: +34 607 22 60 05
http://www.codeoscopic.com
http://www.avant2.es

Este mensaje se dirige exclusivamente a su destinatario y puede contener
información privilegiada o confidencial. Si ha recibido este mensaje por
error, le rogamos que nos lo comunique inmediatamente por esta misma vía y
proceda a su destrucción.

De la vigente Ley Orgánica de Protección de Datos (15/1999), le comunicamos
que sus datos forman parte de un fichero cuyo responsable es CODEOSCOPIC
S.A. La finalidad de dicho tratamiento es facilitar la prestación del
servicio o información solicitados, teniendo usted derecho de acceso,
rectificación, cancelación y oposición de sus datos dirigiéndose a nuestras
oficinas c/ Paseo de la Habana 9-11, 28036, Madrid con la documentación
necesaria.

Re: [FlexJS MDL] release build broken

2017-02-16 Thread Alex Harui 


On 2/16/17, 12:34 PM, "Harbs"  wrote:

>When I’ve had these kinds of issues in my app, it’s because of minified
>renaming.

Yep, and there is code in one of the Binding classes that does some
trickery to look up a constant when minified.  That code might need to be
used in this scenario.

-Alex

Re: [FlexJS MDL] release build broken

2017-02-16 Thread Harbs 
When I’ve had these kinds of issues in my app, it’s because of minified 
renaming.

Tangentially:
FWIW, I’m not sure how wise it is to use constants to specify the icon text. 
The minified version of just the definitions for the MaterialIconTypes is a 
full 77KB!

Until we have a way to stripped out unused constants during compilation, I 
think extra const definitions should be avoided.

Harbs

> On Feb 16, 2017, at 8:34 PM, Carlos Rovira  
> wrote:
> 
> Hi Harbs,
> 
> Thanks for seeing that.
> 
> @Pitor, I looked at the code and seems something related to binding,
> 
> 
>
>
> 
> 
>
>
>
>
> 
> The binding is not working and no text is retrieved. The output is:
> 
> 
> 
> So no text in the i element tag seems the binding not doing its work. Maybe
> some latest changes in binding caused this?
> 
> Thanks
> 
> 
> 2017-02-16 11:03 GMT+01:00 Harbs :
> 
>> 1. Go here: http://apacheflexbuild.cloudapp.net:8080/job/MDLExample/
>> lastSuccessfulBuild/artifact/examples/flexjs/MDLExample/
>> bin/js-release/index.html > MDLExample/lastSuccessfulBuild/artifact/examples/flexjs/MDLExample/
>> bin/js-release/index.html>
>> 
>> 2. Click on Toggles
>> 
>> You will see that the two IconToggles have no content. It seems like the
>> Material Design font is not beiing used for some reason in the release
>> build. The same thing works in the debug build.
>> 
>> Harbs
> 
> 
> 
> 
> -- 
> 
> Carlos Rovira
> Director General
> M: +34 607 22 60 05
> http://www.codeoscopic.com
> http://www.avant2.es
> 
> Este mensaje se dirige exclusivamente a su destinatario y puede contener
> información privilegiada o confidencial. Si ha recibido este mensaje por
> error, le rogamos que nos lo comunique inmediatamente por esta misma vía y
> proceda a su destrucción.
> 
> De la vigente Ley Orgánica de Protección de Datos (15/1999), le comunicamos
> que sus datos forman parte de un fichero cuyo responsable es CODEOSCOPIC
> S.A. La finalidad de dicho tratamiento es facilitar la prestación del
> servicio o información solicitados, teniendo usted derecho de acceso,
> rectificación, cancelación y oposición de sus datos dirigiéndose a nuestras
> oficinas c/ Paseo de la Habana 9-11, 28036, Madrid con la documentación
> necesaria.

Re: [FlexJS MDL] release build broken

2017-02-16 Thread piotrz 
Hi Carlos,

I will look into that through the weekend. When I was doing Binding changes
I have to admit that I didn't check release version. But I think it's
something in the compiler.

Piotr



-
Apache Flex PMC
piotrzarzyck...@gmail.com
--
View this message in context: 
http://apache-flex-development.247.n4.nabble.com/FlexJS-MDL-release-build-broken-tp59537p59564.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.

[FlexJS MDL] release build broken

2017-02-16 Thread Harbs 
1. Go here: 
http://apacheflexbuild.cloudapp.net:8080/job/MDLExample/lastSuccessfulBuild/artifact/examples/flexjs/MDLExample/bin/js-release/index.html
 


2. Click on Toggles

You will see that the two IconToggles have no content. It seems like the 
Material Design font is not beiing used for some reason in the release build. 
The same thing works in the debug build.

Harbs